From: Can Guo <cang@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, andy.teng@mediatek.com,
jejb@linux.ibm.com, chun-hung.wu@mediatek.com,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
cc.chou@mediatek.com, avri.altman@wdc.com,
alice.chao@mediatek.com, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, alim.akhtar@samsung.com,
matthias.bgg@gmail.com, asutoshd@codeaurora.org,
chaotian.jing@mediatek.com, bvanassche@acm.org,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v2 1/4] scsi: ufs: Refactor cancelling clkscaling works
Date: Fri, 18 Dec 2020 14:08:35 +0800 [thread overview]
Message-ID: <0a96e3c62a0a77c78285fe92f2db2cd3@codeaurora.org> (raw)
In-Reply-To: <20201216131639.4128-2-stanley.chu@mediatek.com>
On 2020-12-16 21:16, Stanley Chu wrote:
> Cancelling suspend_work and resume_work is only required while
> suspending clk-scaling. Thus moving these two invokes into
> ufshcd_suspend_clkscaling() function.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 052479a56a6f..a91b73a1fc48 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1451,6 +1451,9 @@ static void ufshcd_suspend_clkscaling(struct
> ufs_hba *hba)
> if (!ufshcd_is_clkscaling_supported(hba))
> return;
>
> + cancel_work_sync(&hba->clk_scaling.suspend_work);
> + cancel_work_sync(&hba->clk_scaling.resume_work);
> +
> spin_lock_irqsave(hba->host->host_lock, flags);
> if (!hba->clk_scaling.is_suspended) {
> suspend = true;
> @@ -1514,9 +1517,6 @@ static ssize_t
> ufshcd_clkscale_enable_store(struct device *dev,
> pm_runtime_get_sync(hba->dev);
> ufshcd_hold(hba, false);
>
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> -
> if (value) {
> ufshcd_resume_clkscaling(hba);
> } else {
> @@ -5663,11 +5663,8 @@ static void ufshcd_err_handling_prepare(struct
> ufs_hba *hba)
> ufshcd_vops_resume(hba, UFS_RUNTIME_PM);
> } else {
> ufshcd_hold(hba, false);
> - if (hba->clk_scaling.is_enabled) {
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> + if (hba->clk_scaling.is_enabled)
> ufshcd_suspend_clkscaling(hba);
> - }
> }
> down_write(&hba->clk_scaling_lock);
> hba->clk_scaling.is_allowed = false;
> @@ -8512,11 +8509,9 @@ static int ufshcd_suspend(struct ufs_hba *hba,
> enum ufs_pm_op pm_op)
> ufshcd_hold(hba, false);
> hba->clk_gating.is_suspended = true;
>
> - if (hba->clk_scaling.is_enabled) {
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> + if (hba->clk_scaling.is_enabled)
> ufshcd_suspend_clkscaling(hba);
> - }
> +
> down_write(&hba->clk_scaling_lock);
> hba->clk_scaling.is_allowed = false;
> up_write(&hba->clk_scaling_lock);
Reviewed-by: Can Guo <cang@codeaurora.org>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Can Guo <cang@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com,
beanhuo@micron.com, asutoshd@codeaurora.org,
matthias.bgg@gmail.com, bvanassche@acm.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
andy.teng@mediatek.com, chaotian.jing@mediatek.com,
cc.chou@mediatek.com, jiajie.hao@mediatek.com,
alice.chao@mediatek.com
Subject: Re: [PATCH v2 1/4] scsi: ufs: Refactor cancelling clkscaling works
Date: Fri, 18 Dec 2020 14:08:35 +0800 [thread overview]
Message-ID: <0a96e3c62a0a77c78285fe92f2db2cd3@codeaurora.org> (raw)
In-Reply-To: <20201216131639.4128-2-stanley.chu@mediatek.com>
On 2020-12-16 21:16, Stanley Chu wrote:
> Cancelling suspend_work and resume_work is only required while
> suspending clk-scaling. Thus moving these two invokes into
> ufshcd_suspend_clkscaling() function.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 052479a56a6f..a91b73a1fc48 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1451,6 +1451,9 @@ static void ufshcd_suspend_clkscaling(struct
> ufs_hba *hba)
> if (!ufshcd_is_clkscaling_supported(hba))
> return;
>
> + cancel_work_sync(&hba->clk_scaling.suspend_work);
> + cancel_work_sync(&hba->clk_scaling.resume_work);
> +
> spin_lock_irqsave(hba->host->host_lock, flags);
> if (!hba->clk_scaling.is_suspended) {
> suspend = true;
> @@ -1514,9 +1517,6 @@ static ssize_t
> ufshcd_clkscale_enable_store(struct device *dev,
> pm_runtime_get_sync(hba->dev);
> ufshcd_hold(hba, false);
>
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> -
> if (value) {
> ufshcd_resume_clkscaling(hba);
> } else {
> @@ -5663,11 +5663,8 @@ static void ufshcd_err_handling_prepare(struct
> ufs_hba *hba)
> ufshcd_vops_resume(hba, UFS_RUNTIME_PM);
> } else {
> ufshcd_hold(hba, false);
> - if (hba->clk_scaling.is_enabled) {
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> + if (hba->clk_scaling.is_enabled)
> ufshcd_suspend_clkscaling(hba);
> - }
> }
> down_write(&hba->clk_scaling_lock);
> hba->clk_scaling.is_allowed = false;
> @@ -8512,11 +8509,9 @@ static int ufshcd_suspend(struct ufs_hba *hba,
> enum ufs_pm_op pm_op)
> ufshcd_hold(hba, false);
> hba->clk_gating.is_suspended = true;
>
> - if (hba->clk_scaling.is_enabled) {
> - cancel_work_sync(&hba->clk_scaling.suspend_work);
> - cancel_work_sync(&hba->clk_scaling.resume_work);
> + if (hba->clk_scaling.is_enabled)
> ufshcd_suspend_clkscaling(hba);
> - }
> +
> down_write(&hba->clk_scaling_lock);
> hba->clk_scaling.is_allowed = false;
> up_write(&hba->clk_scaling_lock);
Reviewed-by: Can Guo <cang@codeaurora.org>
next prev parent reply other threads:[~2020-12-18 6:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:16 [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` [PATCH v2 1/4] scsi: ufs: Refactor cancelling clkscaling works Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-18 6:08 ` Can Guo [this message]
2020-12-18 6:08 ` Can Guo
2020-12-16 13:16 ` [PATCH v2 2/4] scsi: ufs: Remove redundant null checking of devfreq instance Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-18 5:58 ` Can Guo
2020-12-18 5:58 ` Can Guo
2020-12-18 6:09 ` Can Guo
2020-12-18 6:09 ` Can Guo
2020-12-16 13:16 ` [PATCH v2 3/4] scsi: ufs: Cleanup and refactor clk-scaling feature Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-18 6:16 ` Can Guo
2020-12-18 6:16 ` Can Guo
2020-12-16 13:16 ` [PATCH v2 4/4] scsi: ufs: Fix build warning by incorrect function description Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-16 13:16 ` Stanley Chu
2020-12-18 6:16 ` Can Guo
2020-12-18 6:16 ` Can Guo
2020-12-18 6:20 ` [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling Can Guo
2020-12-18 6:20 ` Can Guo
2020-12-18 6:24 ` Stanley Chu
2020-12-18 6:24 ` Stanley Chu
2020-12-18 6:24 ` Stanley Chu
2020-12-18 6:30 ` Can Guo
2020-12-18 6:30 ` Can Guo
2021-01-06 2:47 ` Martin K. Petersen
2021-01-06 2:47 ` Martin K. Petersen
2021-01-06 2:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a96e3c62a0a77c78285fe92f2db2cd3@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.