Re: [PATCH v6 04/18] drm/i915/alpm: Enable debugfs for DP2.1

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Thu, 2026-10-01 at 11:32 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@intel.com>
> > Sent: Monday, September 28, 2026 4:53 PM
> > To: intel-xe@lists.freedesktop.org;
> > dri-devel@lists.freedesktop.org; Manna,
> > Animesh <animesh.manna@intel.com>; intel-gfx@lists.freedesktop.org
> > Cc: Kandpal, Suraj <suraj.kandpal@intel.com>; Nikula, Jani
> > <jani.nikula@intel.com>
> > Subject: Re: [PATCH v6 04/18] drm/i915/alpm: Enable debugfs for
> > DP2.1
> > 
> > On Tue, 2026-09-15 at 23:34 +0530, Animesh Manna wrote:
> > > Enable ALPM debug info through lobf debug info.
> > > 
> > > v2: cosmetic change. [Suraj]
> > > v3: Use common api instead of DISPLAY_VER check in multiple
> > > places.
> > > [Jani]
> > > v4: Add display-version check as it dropped for EDP.
> > > 
> > > Cc: Jouni Högander <jouni.hogander@intel.com>
> > > Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> > > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_alpm.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> > > b/drivers/gpu/drm/i915/display/intel_alpm.c
> > > index 4801fc6bade2..901493bb1448 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> > > @@ -739,8 +739,10 @@ void intel_alpm_lobf_debugfs_add(struct
> > > intel_connector *connector)
> > >  	struct intel_display *display =
> > > to_intel_display(connector);
> > >  	struct dentry *root = connector->base.debugfs_entry;
> > > 
> > > -	if (DISPLAY_VER(display) < 20 ||
> > > -	    connector->base.connector_type !=
> > > DRM_MODE_CONNECTOR_eDP)
> > > +	if (DISPLAY_VER(display) < 20)
> > > +		return;
> > > +
> > > +	if (!intel_alpm_source_supported(connector))
> > >  		return;
> > > 
> > >  	debugfs_create_file("i915_edp_lobf_debug", 0644, root,
> > 
> > These are named as i915_edp_lobf_debug even if they are created on
> > DP
> > connector.
> 
> We have couple of options,
> i) rename to i915_lobf_debug, but backward compatibility will be
> broken.
> ii) create a new debugfs for dp - i915_dp_lobf_debug. Code
> duplication will be there.
> ii) as LOBF introduced first on edp to so DP will use existing edp-
> interface. 
> 
> Good to know your opinion, I see all these options have pros and
> cons.

I would vote for naming both as i915_lobf_debug. DP/eDP is already in
connector path. Code (IGT in practice) could first try new interface
and then if not found try old naming.

BR,
Jouni Högander

> 
> Regards,
> Animesh 
> > 
> > BR,
> > Jouni Högander
>