From: David Vrabel <dvrabel@cantab.net>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Jan Beulich <jbeulich@suse.com>,
"moderated list:XEN HYPERVISOR INTERFACE"
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared
Date: Thu, 17 Nov 2022 12:54:51 +0000 [thread overview]
Message-ID: <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> (raw)
In-Reply-To: <20221117114122.1588338-1-marmarek@invisiblethingslab.com>
On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote:
> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until
> the table is filled. Then it disables INTx just before clearing MASKALL
> bit. Currently this approach is rejected by xen-pciback.
> Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long
> as PCI_MSIX_FLAGS_MASKALL is set too.
The use of MSI-X interrupts is conditional on only the MSI-X Enable bit.
Setting MSI-X Enable effectively overrides the Interrupt Disable bit in
the Command register.
PCIe 6.0.1 section 7.7.2.2. "MSI-X Enable ... is prohibited from using
INTx interrupts (if implemented)." And there is similar wording for MSI
Enable.
I think you need to shuffle the checks for MSI/MSI-X in
xen_pcibk_get_interrupt_type() so they are _before_ the check of the
Interrupt Disable bit in the Command register.
David
next prev parent reply other threads:[~2022-11-17 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:41 [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Marek Marczykowski-Górecki
2022-11-17 12:28 ` Andrew Cooper
2022-11-17 13:43 ` Jan Beulich
2022-11-17 12:54 ` David Vrabel [this message]
2022-11-17 13:13 ` Marek Marczykowski-Górecki
2022-11-17 13:33 ` Jan Beulich
2022-11-17 14:32 ` Marek Marczykowski-Górecki
2022-11-17 13:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net \
--to=dvrabel@cantab.net \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.