All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Kalle Valo <kvalo@codeaurora.org>,
	Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH V2] ath11k: add tx hw 802.11 encapusaltion offloading support
Date: Fri, 18 Sep 2020 18:58:13 +0800	[thread overview]
Message-ID: <0b4abf6c2b7408664cacff5392902720@codeaurora.org> (raw)
In-Reply-To: <20200430152814.18481-1-john@phrozen.org>

On 2020-04-30 23:28, John Crispin wrote:
> This patch adds support for ethernet rxtx mode to the driver. The 
> feature
> is enabled via a new module parameter. If enabled to driver will enable
> the feature on a per vif basis if all other requirements were met.
> 
[...]
> @@ -4339,7 +4352,22 @@ static int ath11k_mac_op_add_interface(struct
> ieee80211_hw *hw,
>  	spin_unlock_bh(&ar->data_lock);
> 
>  	param_id = WMI_VDEV_PARAM_TX_ENCAP_TYPE;
> -	param_value = ATH11K_HW_TXRX_NATIVE_WIFI;
> +	if (ath11k_ath11k_frame_mode == ATH11K_HW_TXRX_ETHERNET)
> +		switch (vif->type) {
> +		case NL80211_IFTYPE_STATION:
> +		case NL80211_IFTYPE_AP_VLAN:
> +		case NL80211_IFTYPE_AP:
> +			hw_encap = 1;
> +			break;
> +		default:
> +			break;
> +		}
> +
> +	if (ieee80211_set_hw_80211_encap(vif, hw_encap))
I see ieee80211_set_hw_80211_encap have check like this:
if (key->conf.cipher == WLAN_CIPHER_SUITE_TKIP)
         enable = false;

so is it beeter to call it after associated/install key?
> +		param_value = ATH11K_HW_TXRX_ETHERNET;
> +	else
> +		param_value = ATH11K_HW_TXRX_NATIVE_WIFI;
> +
>  	ret = ath11k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
>  					    param_id, param_value);
>  	if (ret) {

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Shashidhar Lakkavalli <slakkavalli@datto.com>,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH V2] ath11k: add tx hw 802.11 encapusaltion offloading support
Date: Fri, 18 Sep 2020 18:58:13 +0800	[thread overview]
Message-ID: <0b4abf6c2b7408664cacff5392902720@codeaurora.org> (raw)
In-Reply-To: <20200430152814.18481-1-john@phrozen.org>

On 2020-04-30 23:28, John Crispin wrote:
> This patch adds support for ethernet rxtx mode to the driver. The 
> feature
> is enabled via a new module parameter. If enabled to driver will enable
> the feature on a per vif basis if all other requirements were met.
> 
[...]
> @@ -4339,7 +4352,22 @@ static int ath11k_mac_op_add_interface(struct
> ieee80211_hw *hw,
>  	spin_unlock_bh(&ar->data_lock);
> 
>  	param_id = WMI_VDEV_PARAM_TX_ENCAP_TYPE;
> -	param_value = ATH11K_HW_TXRX_NATIVE_WIFI;
> +	if (ath11k_ath11k_frame_mode == ATH11K_HW_TXRX_ETHERNET)
> +		switch (vif->type) {
> +		case NL80211_IFTYPE_STATION:
> +		case NL80211_IFTYPE_AP_VLAN:
> +		case NL80211_IFTYPE_AP:
> +			hw_encap = 1;
> +			break;
> +		default:
> +			break;
> +		}
> +
> +	if (ieee80211_set_hw_80211_encap(vif, hw_encap))
I see ieee80211_set_hw_80211_encap have check like this:
if (key->conf.cipher == WLAN_CIPHER_SUITE_TKIP)
         enable = false;

so is it beeter to call it after associated/install key?
> +		param_value = ATH11K_HW_TXRX_ETHERNET;
> +	else
> +		param_value = ATH11K_HW_TXRX_NATIVE_WIFI;
> +
>  	ret = ath11k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
>  					    param_id, param_value);
>  	if (ret) {

  parent reply	other threads:[~2020-09-18 10:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 15:28 [PATCH V2] ath11k: add tx hw 802.11 encapusaltion offloading support John Crispin
2020-04-30 15:28 ` John Crispin
2020-05-05  8:06 ` Kalle Valo
2020-05-05  8:06   ` Kalle Valo
2020-05-05  8:17   ` John Crispin
2020-05-05  8:17     ` John Crispin
2020-05-06  6:13 ` Kalle Valo
2020-05-06  6:13 ` Kalle Valo
2020-09-18 10:58 ` Wen Gong [this message]
2020-09-18 10:58   ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b4abf6c2b7408664cacff5392902720@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=slakkavalli@datto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.