From: Kukjin Kim <kgene@kernel.org>
To: 'Kukjin Kim' <kgene.kim@samsung.com>,
'Taehun Kim' <kth3321@gmail.com>,
'Ben Dooks' <ben-linux@fluff.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, sylvester.nawrocki@gmail.com
Subject: RE: [PATCH v3] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support
Date: Tue, 20 Nov 2012 13:54:01 +0900 [thread overview]
Message-ID: <0b6f01cdc6db$0ed72290$2c8567b0$@org> (raw)
In-Reply-To:
Kukjin Kim wrote:
>
> Taehun Kim wrote:
> >
> > - The gpio routines are changed to use the gpio_request() functions from
> > comments of Vasily and Sylwester.
> > - The mistake of adding a character by my email client automatically is
> > fixed.
> >
> > Please review this patch and apply it if do not have any problems.
> >
>
> Taehun,
>
> Above area is for adding comments like 'This patch adds WIZnet W5300E01
> board' because it will be remained in its git log and nobody want to see
> your old request in there. If any comments which are not related to
> changes just put it after '---' around your sign. It doesn't hurt your
> patch.
>
> And you need to update this against on for-next of my tree because some
> S3C2410 gpio APIs have been gone.(See the Sylwester's comments) Please re-
> send this.
>
Any updates on this?
K-Gene <kgene@kernel.org>
>
>
> > Signed-off-by: Taehun Kim <kth3321@gmail.com>
> > ---
> > arch/arm/mach-s3c24xx/Kconfig | 5 +
> > arch/arm/mach-s3c24xx/Makefile | 1 +
> > arch/arm/mach-s3c24xx/mach-w5300e01.c | 193
> > +++++++++++++++++++++++++++++++++
> > 3 files changed, 199 insertions(+)
> > create mode 100644 arch/arm/mach-s3c24xx/mach-w5300e01.c
> >
> [snip]
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support
Date: Tue, 20 Nov 2012 13:54:01 +0900 [thread overview]
Message-ID: <0b6f01cdc6db$0ed72290$2c8567b0$@org> (raw)
In-Reply-To: 1346905640.2573.14.camel@taehun-desktop
Kukjin Kim wrote:
>
> Taehun Kim wrote:
> >
> > - The gpio routines are changed to use the gpio_request() functions from
> > comments of Vasily and Sylwester.
> > - The mistake of adding a character by my email client automatically is
> > fixed.
> >
> > Please review this patch and apply it if do not have any problems.
> >
>
> Taehun,
>
> Above area is for adding comments like 'This patch adds WIZnet W5300E01
> board' because it will be remained in its git log and nobody want to see
> your old request in there. If any comments which are not related to
> changes just put it after '---' around your sign. It doesn't hurt your
> patch.
>
> And you need to update this against on for-next of my tree because some
> S3C2410 gpio APIs have been gone.(See the Sylwester's comments) Please re-
> send this.
>
Any updates on this?
K-Gene <kgene@kernel.org>
>
>
> > Signed-off-by: Taehun Kim <kth3321@gmail.com>
> > ---
> > arch/arm/mach-s3c24xx/Kconfig | 5 +
> > arch/arm/mach-s3c24xx/Makefile | 1 +
> > arch/arm/mach-s3c24xx/mach-w5300e01.c | 193
> > +++++++++++++++++++++++++++++++++
> > 3 files changed, 199 insertions(+)
> > create mode 100644 arch/arm/mach-s3c24xx/mach-w5300e01.c
> >
> [snip]
next prev parent reply other threads:[~2012-11-20 4:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 6:20 [PATCH] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support Taehun Kim
2012-09-03 6:20 ` Taehun Kim
2012-09-03 7:56 ` Vasily Khoruzhick
2012-09-03 7:56 ` Vasily Khoruzhick
2012-09-03 8:54 ` Sylwester Nawrocki
2012-09-03 8:54 ` Sylwester Nawrocki
2012-09-03 15:39 ` Taehun Kim
2012-09-03 15:39 ` Taehun Kim
2012-09-03 17:36 ` [PATCH v2] " Taehun Kim
2012-09-03 17:36 ` Taehun Kim
2012-09-03 18:00 ` Vasily Khoruzhick
2012-09-03 18:00 ` Vasily Khoruzhick
2012-09-03 19:26 ` Sylwester Nawrocki
2012-09-03 19:26 ` Sylwester Nawrocki
2012-09-04 18:32 ` Taehun Kim
2012-09-04 18:32 ` Taehun Kim
2012-09-06 4:27 ` [PATCH v3] " Taehun Kim
2012-09-06 4:27 ` Taehun Kim
2012-09-19 23:38 ` Kukjin Kim
2012-09-19 23:38 ` Kukjin Kim
2012-11-20 4:54 ` Kukjin Kim [this message]
2012-11-20 4:54 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0b6f01cdc6db$0ed72290$2c8567b0$@org' \
--to=kgene@kernel.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kth3321@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.