From: Eric Farman <farman@linux.ibm.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>,
Farhan Ali <alifm@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: cohuck@redhat.com, oelghoul@linux.ibm.com,
qemu-stable@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Subject: Re: [PATCH v3 2/2] s390x/pci: Change reset method from legacy to resettable exit
Date: Thu, 29 Oct 2026 15:58:56 -0400 [thread overview]
Message-ID: <0bcc6ac7-bf7a-432d-acaa-d04df9d378fe@linux.ibm.com> (raw)
In-Reply-To: <956ae61c-281e-44c4-87ed-7a1cdfc70297@linux.ibm.com>
On 10/29/26 1:56 PM, Matthew Rosato wrote:
> On 10/28/26 6:46 PM, Farhan Ali wrote:
>> On subsystem reset of the s390 PCI host bridge (TYPE_S390_PCI_HOST_BRIDGE),
>> child buses S390PCIBus and PCIBus are reset in order. Because S390PCIBus
>> devices are reset first via the legacy reset hook, IOMMU mappings are torn
>> down before the PCI device itself is reset. For a PCI passthrough device
>> this opens a window where the device may issue DMA to addresses that no
>> longer have valid IOMMU mappings, causing an error (PEC 0x7) on the host.
>>
>> The QEMU reset documentation (docs/devel/reset.rst) specifies that IOMMUs
>> should perform teardown in the resettable 'exit' phase, after all devices
>> have completed their 'hold' phase. Move the S390PCIBusDevice reset logic
>> from the legacy reset hook to the resettable exit phase to close this
>> window.
>>
>> Fixes: 3e5cfba3ca0a ("s390x/pci: introduce S390PCIBusDevice qdev")
>> Cc: qemu-stable@nongnu.org
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
>> Tested-by: Omar Elghoul <oelghoul@linux.ibm.com>
>> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Thanks! Applied both of these to the queue for 11.2.
next prev parent reply other threads:[~2026-10-29 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:46 [PATCH v3 1/2] s390x/pci: Free FMB timer on zPCI device unplug Farhan Ali
2026-10-28 22:46 ` [PATCH v3 2/2] s390x/pci: Change reset method from legacy to resettable exit Farhan Ali
2026-10-29 17:56 ` Matthew Rosato
2026-10-29 19:58 ` Eric Farman [this message]
2026-10-29 17:55 ` [PATCH v3 1/2] s390x/pci: Free FMB timer on zPCI device unplug Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bcc6ac7-bf7a-432d-acaa-d04df9d378fe@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=oelghoul@linux.ibm.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.