From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Farhan Ali <alifm@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: farman@linux.ibm.com, cohuck@redhat.com, oelghoul@linux.ibm.com,
qemu-stable@nongnu.org
Subject: Re: [PATCH v3 1/2] s390x/pci: Free FMB timer on zPCI device unplug
Date: Thu, 29 Oct 2026 13:55:40 -0400 [thread overview]
Message-ID: <fb146831-3e5d-4ece-96cd-b68d00315c93@linux.ibm.com> (raw)
In-Reply-To: <20261028224611.240515-1-alifm@linux.ibm.com>
On 10/28/26 6:46 PM, Farhan Ali wrote:
> On an SCLP deconfigure we don't clean up the FMB timer. If there is a
> pending unplug request then we can destroy the S390PCIBusDevice object
> without correctly cleaning up the timer. So fmb_update() will then run on
> freed memory. Clean up the FMB timer before we destroy the S390PCIBusDevice
> object to prevent this use after free.
>
> When FMB was introduced with commit 6e92c70c37 ("s390x/pci: add common
> function measurement block") we originally cleaned up the FMB timer in
> s390_pcihost_unplug(). This behavior was changed in the re-work done with
> commit e0998fe89104 ("s390x/pci: Introduce unplug requests and split unplug
> handler").
>
> Fixes: e0998fe89104 ("s390x/pci: Introduce unplug requests and split unplug handler")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
prev parent reply other threads:[~2026-10-29 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:46 [PATCH v3 1/2] s390x/pci: Free FMB timer on zPCI device unplug Farhan Ali
2026-10-28 22:46 ` [PATCH v3 2/2] s390x/pci: Change reset method from legacy to resettable exit Farhan Ali
2026-10-29 17:56 ` Matthew Rosato
2026-10-29 19:58 ` Eric Farman
2026-10-29 17:55 ` Matthew Rosato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb146831-3e5d-4ece-96cd-b68d00315c93@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=oelghoul@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.