All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, bp@alien8.de, tglx@linutronix.de,
	seanjc@google.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] kvm/sev: make SEV/SEV-ES asids configurable
Date: Tue, 10 Oct 2023 15:20:02 +0300	[thread overview]
Message-ID: <0c73f3ee77afe22879fbbed8a34f838f@foxhound.fi> (raw)
In-Reply-To: <5c19c422-41ad-430b-664c-15f3e2087922@redhat.com>

On 2023-10-10 14:40, Paolo Bonzini wrote:
> On 10/10/23 13:35, Greg KH wrote:
>> On Tue, Oct 10, 2023 at 01:04:39PM +0300, José Pekkarinen wrote:
>>> There are bioses that doesn't allow to configure the
>>> number of asids allocated for SEV/SEV-ES, for those
>>> cases, the default behaviour allocates all the asids
>>> for SEV, leaving no room for SEV-ES to have some fun.
> 
> In addition to what Greg pointed out (and there are many more cases
> that have to be checked for errors, including possible overflows), why
> is it correct to just ignore what's in CPUID?

     I'll check if I can use cpuid info to improve this
for v2, I just noticed my cpu advertises sev_es but
the kernel doesn't activate it despite of the kvm_amd
parameter being set, so I tried to fix it this way, but
any comments or ideas for improvement are welcomed.

     Thanks!

     José.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	seanjc@google.com, skhan@linuxfoundation.org,
	dave.hansen@linux.intel.com, kvm@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, tglx@linutronix.de,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] kvm/sev: make SEV/SEV-ES asids configurable
Date: Tue, 10 Oct 2023 15:20:02 +0300	[thread overview]
Message-ID: <0c73f3ee77afe22879fbbed8a34f838f@foxhound.fi> (raw)
In-Reply-To: <5c19c422-41ad-430b-664c-15f3e2087922@redhat.com>

On 2023-10-10 14:40, Paolo Bonzini wrote:
> On 10/10/23 13:35, Greg KH wrote:
>> On Tue, Oct 10, 2023 at 01:04:39PM +0300, José Pekkarinen wrote:
>>> There are bioses that doesn't allow to configure the
>>> number of asids allocated for SEV/SEV-ES, for those
>>> cases, the default behaviour allocates all the asids
>>> for SEV, leaving no room for SEV-ES to have some fun.
> 
> In addition to what Greg pointed out (and there are many more cases
> that have to be checked for errors, including possible overflows), why
> is it correct to just ignore what's in CPUID?

     I'll check if I can use cpuid info to improve this
for v2, I just noticed my cpu advertises sev_es but
the kernel doesn't activate it despite of the kvm_amd
parameter being set, so I tried to fix it this way, but
any comments or ideas for improvement are welcomed.

     Thanks!

     José.

  reply	other threads:[~2023-10-10 15:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 10:04 [PATCH] kvm/sev: make SEV/SEV-ES asids configurable José Pekkarinen
2023-10-10 10:04 ` José Pekkarinen
2023-10-10 11:35 ` Greg KH
2023-10-10 11:35   ` Greg KH
2023-10-10 11:40   ` Paolo Bonzini
2023-10-10 11:40     ` Paolo Bonzini
2023-10-10 12:20     ` José Pekkarinen [this message]
2023-10-10 12:20       ` José Pekkarinen
2023-10-10 12:01   ` José Pekkarinen
2023-10-10 12:01     ` José Pekkarinen
2023-10-10 16:49 ` Peter Gonda via Linux-kernel-mentees
2023-10-10 16:49   ` Peter Gonda
2023-10-10 18:03   ` José Pekkarinen
2023-10-10 18:03     ` José Pekkarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c73f3ee77afe22879fbbed8a34f838f@foxhound.fi \
    --to=jose.pekkarinen@foxhound.fi \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.