[PATCH net-next] amd-xgbe: let the MAC manage PHY PM

[PATCH net-next] amd-xgbe: let the MAC manage PHY PM

[Raju Rangoju]

Use the MAC managed PM flag to indicate that MAC driver takes care of
suspending/resuming the PHY, and reset it when the device is brought up.

Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
---
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c    | 3 +++
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index f3adf29b222b..1c03fb138ce6 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -1266,6 +1266,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata)
 
 	clear_bit(XGBE_STOPPED, &pdata->dev_state);
 
+	/* Reset the phy settings */
+	xgbe_phy_reset(pdata);
+
 	return 0;
 
 err_irqs:
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
index 35a381a83647..a68757e8fd22 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
@@ -989,6 +989,7 @@ static int xgbe_phy_find_phy_device(struct xgbe_prv_data *pdata)
 		return ret;
 	}
 	phy_data->phydev = phydev;
+	phy_data->phydev->mac_managed_pm = true;
 
 	xgbe_phy_external_phy_quirks(pdata);
 
-- 
2.34.1

Re: [PATCH net-next] amd-xgbe: let the MAC manage PHY PM

[Maxime Chevallier]

Hi Raju,

On 19/11/2025 10:31, Raju Rangoju wrote:
> Use the MAC managed PM flag to indicate that MAC driver takes care of
> suspending/resuming the PHY, and reset it when the device is brought up.
> 
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c    | 3 +++
>  drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index f3adf29b222b..1c03fb138ce6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -1266,6 +1266,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata)
>  
>  	clear_bit(XGBE_STOPPED, &pdata->dev_state);
>  
> +	/* Reset the phy settings */
> +	xgbe_phy_reset(pdata);
> +

At a first glance, this looks like 2 different things, so maybe 2
different patches ?

That said, with this change does it still make sense to call
xgbe_phy_reset() in xgbe_open() ?

With this patch we have :

xgpe_open() {

  xgbe_phy_reset();

  xgbe_start() {
    xgbe_phy_reset(); /* again */
  }
}

Can you remove the first call in .ndo_open ?

Maxime

Re: [PATCH net-next] amd-xgbe: let the MAC manage PHY PM

[Rangoju, Raju]

On 11/19/2025 9:27 PM, Maxime Chevallier wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Raju,
> 
> On 19/11/2025 10:31, Raju Rangoju wrote:
>> Use the MAC managed PM flag to indicate that MAC driver takes care of
>> suspending/resuming the PHY, and reset it when the device is brought up.
>>
>> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
>> ---
>>   drivers/net/ethernet/amd/xgbe/xgbe-drv.c    | 3 +++
>>   drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 1 +
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
>> index f3adf29b222b..1c03fb138ce6 100644
>> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
>> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
>> @@ -1266,6 +1266,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata)
>>
>>        clear_bit(XGBE_STOPPED, &pdata->dev_state);
>>
>> +     /* Reset the phy settings */
>> +     xgbe_phy_reset(pdata);
>> +
> 
> At a first glance, this looks like 2 different things, so maybe 2
> different patches ?
> 

Hi Maxime,

Patch is setting MAC managed PM flag and moving the reset to appropriate 
place. Do you see a need for separate patch for this?

> That said, with this change does it still make sense to call
> xgbe_phy_reset() in xgbe_open() ?

No, calling it in xgbe_open() isn't needed.

> 
> With this patch we have :
> 
> xgpe_open() {
> 
>    xgbe_phy_reset();
> 
>    xgbe_start() {
>      xgbe_phy_reset(); /* again */
>    }
> }
> 
> Can you remove the first call in .ndo_open ?

sure, I'll take of this in V2.

> 
> Maxime
>