All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: "Huang, Kai" <kai.huang@intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
Cc: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"santosh.shukla@amd.com" <santosh.shukla@amd.com>,
	"bp@alien8.de" <bp@alien8.de>
Subject: Re: [RFC PATCH 1/4] KVM: x86: Carve out PML flush routine
Date: Thu, 28 Aug 2025 12:00:26 +0530	[thread overview]
Message-ID: <0cdeefa9-0b31-4321-9b72-cb1823afb418@amd.com> (raw)
In-Reply-To: <37959b67573fe11d1ff4f3c730c49776d3d229d4.camel@intel.com>



On 8/27/2025 3:23 PM, Huang, Kai wrote:
> On Tue, 2025-08-26 at 20:28 +0530, Nikunj A. Dadhania wrote:
>>
>> On 8/26/2025 3:36 PM, Huang, Kai wrote:
>>> On Mon, 2025-08-25 at 15:20 +0000, Nikunj A Dadhania wrote:
>>>
>>> Looking at the code change, IIUC the PML code that is moved to x86 common
>>> assumes AMD's PML also follows VMX's behaviour:
>>>
>>>  1) The PML buffer is a 4K page;
>>>  2) The hardware records the dirty GPA in backwards to the PML buffer
>>>
>>> Could we point this out in the changelog?
>>
>> Ack, will add in the next revision
> 
> Thanks.  Maybe one more to point out:
> 
>   3) AMD PML also clears bit 11:0 when recording the GPA.

Sure.


  reply	other threads:[~2025-08-28  6:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 15:20 [RFC PATCH 0/4] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2025-08-25 15:20 ` [RFC PATCH 1/4] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2025-08-26 10:06   ` Huang, Kai
2025-08-26 14:58     ` Nikunj A. Dadhania
2025-08-27  9:53       ` Huang, Kai
2025-08-28  6:30         ` Nikunj A. Dadhania [this message]
2025-08-25 15:20 ` [RFC PATCH 2/4] KVM: SEV: Skip SNP-safe allocation when HvInUseWrAllowed is supported Nikunj A Dadhania
2025-08-26 10:07   ` Huang, Kai
2025-08-26 15:07     ` Nikunj A. Dadhania
2025-08-27  9:54       ` Huang, Kai
2025-08-25 15:20 ` [RFC PATCH 3/4] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2025-08-25 15:25   ` Borislav Petkov
2025-08-25 15:20 ` [RFC PATCH 4/4] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2025-08-27 23:44   ` Huang, Kai
2025-08-28  6:37     ` Nikunj A. Dadhania
2025-08-28 10:33       ` Huang, Kai
2025-08-28 10:43         ` Nikunj A. Dadhania
2025-08-28 11:09           ` Huang, Kai
2025-08-28 11:17             ` Huang, Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cdeefa9-0b31-4321-9b72-cb1823afb418@amd.com \
    --to=nikunj@amd.com \
    --cc=bp@alien8.de \
    --cc=joao.m.martins@oracle.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=santosh.shukla@amd.com \
    --cc=seanjc@google.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.