From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"nikunj@amd.com" <nikunj@amd.com>
Cc: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"santosh.shukla@amd.com" <santosh.shukla@amd.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [RFC PATCH 4/4] KVM: SVM: Add Page modification logging support
Date: Wed, 27 Aug 2025 23:44:51 +0000 [thread overview]
Message-ID: <fb9f2dcb176b9a930557cabc24186b70522d945d.camel@intel.com> (raw)
In-Reply-To: <20250825152009.3512-5-nikunj@amd.com>
On Mon, 2025-08-25 at 15:20 +0000, Nikunj A Dadhania wrote:
> + if (pml) {
> + svm->pml_page = snp_safe_alloc_page();
> + if (!svm->pml_page)
> + goto error_free_vmsa_page;
> + }
I didn't see this yesterday. Is it mandatory for AMD PML to use
snp_safe_alloc_page() to allocate the PML buffer, or we can also use
normal page allocation API?
VMX PML just uses alloc_pages(). I was thinking the page allocation/free
code could be moved to x86 common as shared code too.
next prev parent reply other threads:[~2025-08-27 23:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 15:20 [RFC PATCH 0/4] KVM: SVM: Add Page Modification Logging (PML) support Nikunj A Dadhania
2025-08-25 15:20 ` [RFC PATCH 1/4] KVM: x86: Carve out PML flush routine Nikunj A Dadhania
2025-08-26 10:06 ` Huang, Kai
2025-08-26 14:58 ` Nikunj A. Dadhania
2025-08-27 9:53 ` Huang, Kai
2025-08-28 6:30 ` Nikunj A. Dadhania
2025-08-25 15:20 ` [RFC PATCH 2/4] KVM: SEV: Skip SNP-safe allocation when HvInUseWrAllowed is supported Nikunj A Dadhania
2025-08-26 10:07 ` Huang, Kai
2025-08-26 15:07 ` Nikunj A. Dadhania
2025-08-27 9:54 ` Huang, Kai
2025-08-25 15:20 ` [RFC PATCH 3/4] x86/cpufeatures: Add Page modification logging Nikunj A Dadhania
2025-08-25 15:25 ` Borislav Petkov
2025-08-25 15:20 ` [RFC PATCH 4/4] KVM: SVM: Add Page modification logging support Nikunj A Dadhania
2025-08-27 23:44 ` Huang, Kai [this message]
2025-08-28 6:37 ` Nikunj A. Dadhania
2025-08-28 10:33 ` Huang, Kai
2025-08-28 10:43 ` Nikunj A. Dadhania
2025-08-28 11:09 ` Huang, Kai
2025-08-28 11:17 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9f2dcb176b9a930557cabc24186b70522d945d.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.