All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	"abel.vesa@nxp.com" <abel.vesa@nxp.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"lakshmi.sowjanya.d@intel.com" <lakshmi.sowjanya.d@intel.com>,
	"aisheng.dong@nxp.com" <aisheng.dong@nxp.com>,
	"rafal@milecki.pl" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const
Date: Sun, 2 Jan 2022 00:58:06 +0100	[thread overview]
Message-ID: <0ce1b7cb-ae08-65fc-0e2e-1f58ebac7937@gmail.com> (raw)
In-Reply-To: <b9fe3fdd615fc0a91c9374a58f09d2f3ed38e0c3.camel@toradex.com>

On 2.01.2022 00:55, Marcel Ziswiler wrote:
> On Wed, 2021-12-22 at 22:24 +0200, Abel Vesa wrote:
>>> @@ -663,14 +664,16 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
>>>                  dev_err(ipctl->dev, "no groups defined in %pOF\n", np);
>>>                  return -EINVAL;
>>>          }
>>> -       func->group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
>>> -                                        sizeof(char *), GFP_KERNEL);
>>> +
>>> +       group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
>>> +                                  sizeof(char *), GFP_KERNEL);
>>>          if (!func->group_names)
>> This line needs to be:
>>          if (!group_names)
>>
>> Otherwise, the driver never probes successufully.
> 
> After my i.MX 8M Mini target running latest -next just hang early boot I bisected it to this commit.
> 
> I can confirm that this fixes it. Thanks!

Please note there is one more pending fix. Please apply both:
[PATCH] pinctrl: imx: fix allocation result check
[PATCH] pinctrl: imx: fix assigning groups names

WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	"abel.vesa@nxp.com" <abel.vesa@nxp.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"lakshmi.sowjanya.d@intel.com" <lakshmi.sowjanya.d@intel.com>,
	"aisheng.dong@nxp.com" <aisheng.dong@nxp.com>,
	"rafal@milecki.pl" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const
Date: Sun, 2 Jan 2022 00:58:06 +0100	[thread overview]
Message-ID: <0ce1b7cb-ae08-65fc-0e2e-1f58ebac7937@gmail.com> (raw)
In-Reply-To: <b9fe3fdd615fc0a91c9374a58f09d2f3ed38e0c3.camel@toradex.com>

On 2.01.2022 00:55, Marcel Ziswiler wrote:
> On Wed, 2021-12-22 at 22:24 +0200, Abel Vesa wrote:
>>> @@ -663,14 +664,16 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
>>>                  dev_err(ipctl->dev, "no groups defined in %pOF\n", np);
>>>                  return -EINVAL;
>>>          }
>>> -       func->group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
>>> -                                        sizeof(char *), GFP_KERNEL);
>>> +
>>> +       group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
>>> +                                  sizeof(char *), GFP_KERNEL);
>>>          if (!func->group_names)
>> This line needs to be:
>>          if (!group_names)
>>
>> Otherwise, the driver never probes successufully.
> 
> After my i.MX 8M Mini target running latest -next just hang early boot I bisected it to this commit.
> 
> I can confirm that this fixes it. Thanks!

Please note there is one more pending fix. Please apply both:
[PATCH] pinctrl: imx: fix allocation result check
[PATCH] pinctrl: imx: fix assigning groups names

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-01 23:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 16:22 [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const Rafał Miłecki
2021-12-16 16:22 ` Rafał Miłecki
2021-12-16 16:22 ` [PATCH V2 2/4] pinctrl: keembay: comment process of building functions a bit Rafał Miłecki
2021-12-16 16:22   ` Rafał Miłecki
2021-12-16 16:22 ` [PATCH V2 3/4] pinctrl: keembay: rework loops looking for groups names Rafał Miłecki
2021-12-16 16:22   ` Rafał Miłecki
2021-12-16 16:22 ` [PATCH V2 4/4] pinctrl: add one more "const" for generic function groups Rafał Miłecki
2021-12-16 16:22   ` Rafał Miłecki
2022-01-11 15:34   ` Nathan Chancellor
2022-01-11 15:34     ` Nathan Chancellor
2022-01-11 16:51     ` Rafał Miłecki
2022-01-11 16:51       ` Rafał Miłecki
2022-01-16  0:51       ` Linus Walleij
2022-01-16  0:51         ` Linus Walleij
2022-01-18  7:02       ` Uwe Kleine-König
2022-01-18  7:02         ` Uwe Kleine-König
2022-01-18  7:21         ` Rafał Miłecki
2022-01-18  7:21           ` Rafał Miłecki
2022-01-18  7:31           ` Uwe Kleine-König
2022-01-18  7:31             ` Uwe Kleine-König
2021-12-17  9:39 ` [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const Andy Shevchenko
2021-12-17  9:39   ` Andy Shevchenko
2021-12-22  1:58 ` Linus Walleij
2021-12-22  1:58   ` Linus Walleij
2021-12-22 20:24 ` Abel Vesa
2021-12-22 20:24   ` Abel Vesa
2022-01-01 23:55   ` Marcel Ziswiler
2022-01-01 23:55     ` Marcel Ziswiler
2022-01-01 23:58     ` Rafał Miłecki [this message]
2022-01-01 23:58       ` Rafał Miłecki
2022-01-01 23:59       ` Marcel Ziswiler
2022-01-01 23:59         ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ce1b7cb-ae08-65fc-0e2e-1f58ebac7937@gmail.com \
    --to=zajec5@gmail.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lakshmi.sowjanya.d@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=rafal@milecki.pl \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.