All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: Chao Yu <chao@kernel.org>, Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, jaegeuk@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
Date: Tue, 3 Dec 2024 19:29:46 +0800	[thread overview]
Message-ID: <0d23e561-65b9-4e9e-ad56-ae4e44bd91ed@kernel.org> (raw)
In-Reply-To: <20241202192835.seditdylbigpxte5@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On 2024/12/3 3:28, Zorro Lang wrote:
> On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
>> The bug related to this regression testcase has been fixed by commit
>> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
>> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
>> line.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   tests/f2fs/005 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/f2fs/005 b/tests/f2fs/005
>> index a817d51a..33d4fdb9 100755
>> --- a/tests/f2fs/005
>> +++ b/tests/f2fs/005
>> @@ -11,7 +11,7 @@
>>   . ./common/preamble
>>   _begin_fstest auto quick
>>   
>> -_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +_fixed_by_kernel_commit d5c367ef8287 \
>>   	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
> 
> I think we don't need to use 3 patches. As you just add missed commit id number,
> just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
> Or if you hope I can do that when I merge it, feel free to tell me :)

Zorro,

I've sent a new patch, can you please help to review it? thank you.

Thanks,

> 
> Others look good to me, with above change:
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
>>   
>>   _require_scratch
>> -- 
>> 2.40.1
>>
> 


WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Zorro Lang <zlang@redhat.com>
Cc: jaegeuk@kernel.org, Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
Date: Tue, 3 Dec 2024 19:29:46 +0800	[thread overview]
Message-ID: <0d23e561-65b9-4e9e-ad56-ae4e44bd91ed@kernel.org> (raw)
In-Reply-To: <20241202192835.seditdylbigpxte5@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On 2024/12/3 3:28, Zorro Lang wrote:
> On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
>> The bug related to this regression testcase has been fixed by commit
>> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
>> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
>> line.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   tests/f2fs/005 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/f2fs/005 b/tests/f2fs/005
>> index a817d51a..33d4fdb9 100755
>> --- a/tests/f2fs/005
>> +++ b/tests/f2fs/005
>> @@ -11,7 +11,7 @@
>>   . ./common/preamble
>>   _begin_fstest auto quick
>>   
>> -_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +_fixed_by_kernel_commit d5c367ef8287 \
>>   	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
> 
> I think we don't need to use 3 patches. As you just add missed commit id number,
> just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
> Or if you hope I can do that when I merge it, feel free to tell me :)

Zorro,

I've sent a new patch, can you please help to review it? thank you.

Thanks,

> 
> Others look good to me, with above change:
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
>>   
>>   _require_scratch
>> -- 
>> 2.40.1
>>
> 



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2024-12-03 11:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 11:41 [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line Chao Yu
2024-12-02 11:41 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2024-12-02 11:41 ` [PATCH 2/3] f2fs/006: " Chao Yu
2024-12-02 11:41   ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2024-12-02 11:41 ` [PATCH 3/3] f2fs/007: " Chao Yu
2024-12-02 11:41   ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2024-12-02 19:28 ` [PATCH 1/3] f2fs/005: " Zorro Lang
2024-12-02 19:28   ` [f2fs-dev] " Zorro Lang
2024-12-03 11:29   ` Chao Yu [this message]
2024-12-03 11:29     ` Chao Yu via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d23e561-65b9-4e9e-ad56-ae4e44bd91ed@kernel.org \
    --to=chao@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=zlang@kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.