From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Feng, Boqun" <boqun.feng@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] fix interrupt request miss problem in bsd ring for g4x
Date: Wed, 27 Apr 2011 08:39:14 +0100 [thread overview]
Message-ID: <0d30dc$m0pen7@orsmga001.jf.intel.com> (raw)
In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F224BDFB0E4@shsmsx501.ccr.corp.intel.com>
On Wed, 27 Apr 2011 14:08:57 +0800, "Feng, Boqun" <boqun.feng@intel.com> wrote:
> I am very sorry for my careless about whitespace.
>
> But my patch will not affect gen6+ paths, for gen6+, it use gen6_bsd_ring
> , bsd_ring is only used by g4x and ironlake.
Reviewer error, sorry. Saw the gen6_* in the diff header as the function
affected and believed it.
> Besides, since bsd_ring_get_irq/bsd_ring_put_irq/ring_get_irq/ring_put_irq
> are only used by bsd_ring, can we use a patch to merge them into two function?
Yes, once upon a time they differed, now they are the same so please do
merge them and give them a more useful name: g4x_ring_* so that there is a
constant reminder that g4x also has a BSD ring and that the functions are
not expected to be used with earlier chipsets.
Daniel has done similar things for gen6 once we decided to drop the
pre-production workarounds.
Obviously that is a separate patch to the bug fix. Thanks,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-27 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 10:12 [PATCH] fix interrupt request miss problem in bsd ring for g4x Feng, Boqun
2011-04-26 14:28 ` Chris Wilson
2011-04-27 6:08 ` Feng, Boqun
2011-04-27 7:39 ` Chris Wilson [this message]
2011-04-27 8:23 ` Feng, Boqun
2011-04-27 9:15 ` Chris Wilson
2011-04-27 11:07 ` Daniel Vetter
2011-04-27 16:07 ` Ben Widawsky
2011-04-26 17:55 ` Keith Packard
2011-04-27 4:58 ` Feng, Boqun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$m0pen7@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=boqun.feng@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.