From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
sakari.ailus@linux.intel.com, bingbu.cao@intel.com,
tian.shu.qiu@intel.com, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h
Date: Mon, 11 Nov 2024 10:38:54 +0800 [thread overview]
Message-ID: <0d546a5b-b56b-359c-5dae-4cb1cfd0f535@linux.intel.com> (raw)
In-Reply-To: <67c23810-259b-fc0a-2792-eecdbbcc292e@linux.intel.com>
On 11/11/24 10:12 AM, Bingbu Cao wrote:
> Li,
>
> Thanks for the patch.
>
> On 11/11/24 9:56 AM, Yang Li wrote:
>> The header files linux/iova.h is included twice in ipu6-dma.h,
>> so one inclusion of each can be removed.
>>
>> ./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
>> than once.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791
>
> It'd better to add:
> Fixes: 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")
Oops, I just noticed the commit above is on the road...
You can correct the hash after it is applied.
>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> index b51244add9e6..a902eec5c07a 100644
>> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> @@ -7,7 +7,6 @@
>> #include <linux/dma-map-ops.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/iova.h>
>> -#include <linux/iova.h>
>> #include <linux/scatterlist.h>
>> #include <linux/types.h>
>>
>>
>
> Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
>
>
--
Best regards,
Bingbu Cao
prev parent reply other threads:[~2024-11-11 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 1:56 [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h Yang Li
2024-11-11 2:12 ` Bingbu Cao
2024-11-11 2:38 ` Bingbu Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d546a5b-b56b-359c-5dae-4cb1cfd0f535@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=abaci@linux.alibaba.com \
--cc=bingbu.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.