* [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h
@ 2024-11-11 1:56 Yang Li
2024-11-11 2:12 ` Bingbu Cao
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2024-11-11 1:56 UTC (permalink / raw)
To: sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab
Cc: linux-media, linux-kernel, Yang Li, Abaci Robot
The header files linux/iova.h is included twice in ipu6-dma.h,
so one inclusion of each can be removed.
./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
index b51244add9e6..a902eec5c07a 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
+++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
@@ -7,7 +7,6 @@
#include <linux/dma-map-ops.h>
#include <linux/dma-mapping.h>
#include <linux/iova.h>
-#include <linux/iova.h>
#include <linux/scatterlist.h>
#include <linux/types.h>
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h
2024-11-11 1:56 [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h Yang Li
@ 2024-11-11 2:12 ` Bingbu Cao
2024-11-11 2:38 ` Bingbu Cao
0 siblings, 1 reply; 3+ messages in thread
From: Bingbu Cao @ 2024-11-11 2:12 UTC (permalink / raw)
To: Yang Li, sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab
Cc: linux-media, linux-kernel, Abaci Robot
Li,
Thanks for the patch.
On 11/11/24 9:56 AM, Yang Li wrote:
> The header files linux/iova.h is included twice in ipu6-dma.h,
> so one inclusion of each can be removed.
>
> ./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
> than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791
It'd better to add:
Fixes: 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
> index b51244add9e6..a902eec5c07a 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
> @@ -7,7 +7,6 @@
> #include <linux/dma-map-ops.h>
> #include <linux/dma-mapping.h>
> #include <linux/iova.h>
> -#include <linux/iova.h>
> #include <linux/scatterlist.h>
> #include <linux/types.h>
>
>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h
2024-11-11 2:12 ` Bingbu Cao
@ 2024-11-11 2:38 ` Bingbu Cao
0 siblings, 0 replies; 3+ messages in thread
From: Bingbu Cao @ 2024-11-11 2:38 UTC (permalink / raw)
To: Yang Li, sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab
Cc: linux-media, linux-kernel, Abaci Robot
On 11/11/24 10:12 AM, Bingbu Cao wrote:
> Li,
>
> Thanks for the patch.
>
> On 11/11/24 9:56 AM, Yang Li wrote:
>> The header files linux/iova.h is included twice in ipu6-dma.h,
>> so one inclusion of each can be removed.
>>
>> ./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
>> than once.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791
>
> It'd better to add:
> Fixes: 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")
Oops, I just noticed the commit above is on the road...
You can correct the hash after it is applied.
>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> index b51244add9e6..a902eec5c07a 100644
>> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> @@ -7,7 +7,6 @@
>> #include <linux/dma-map-ops.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/iova.h>
>> -#include <linux/iova.h>
>> #include <linux/scatterlist.h>
>> #include <linux/types.h>
>>
>>
>
> Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
>
>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-11 2:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-11 1:56 [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h Yang Li
2024-11-11 2:12 ` Bingbu Cao
2024-11-11 2:38 ` Bingbu Cao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.