From: David Ahern <dsahern@gmail.com>
To: Heiko Thiery <heiko.thiery@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Petr Vorel <petr.vorel@gmail.com>
Subject: Re: [PATCH iproute2-next v2] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented
Date: Sat, 1 May 2021 09:03:20 -0600 [thread overview]
Message-ID: <0daa2b24-e326-05d2-c219-8a7ade7376e0@gmail.com> (raw)
In-Reply-To: <20210430062632.21304-1-heiko.thiery@gmail.com>
On 4/30/21 12:26 AM, Heiko Thiery wrote:
> With commit d5e6ee0dac64b64e the usage of functions name_to_handle_at() and
that is a change to ss:
d5e6ee0dac64 ss: introduce cgroup2 cache and helper functions
> open_by_handle_at() are introduced. But these function are not available
> e.g. in uclibc-ng < 1.0.35. To have a backward compatibility check for the
> availability in the configure script and in case of absence do a direct
> syscall.
>
When you find the proper commit add a Fixes line before the Signed-off-by:
Fixes: <id> ("subject line")
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
make sure you cc the author of the original commit.
> v2:
> - small correction to subject
> - removed IP_CONFIG_HANDLE_AT:=y option since it is not required
> - fix indentation in check function
> - removed empty lines (thanks to Petr Vorel)
> - add #define _GNU_SOURCE in check (thanks to Petr Vorel)
> - check only for name_to_handle_at (thanks to Peter Vorel)
you have 3 responses to this commit. Please send an updated patch with
all the changes and the the above comments addressed.
Thanks,
next prev parent reply other threads:[~2021-05-01 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 6:26 [PATCH iproute2-next v2] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented Heiko Thiery
2021-04-30 18:43 ` Petr Vorel
2021-04-30 19:07 ` Petr Vorel
2021-04-30 19:29 ` Petr Vorel
2021-05-02 8:35 ` Heiko Thiery
2021-05-02 11:16 ` Petr Vorel
2021-05-01 15:03 ` David Ahern [this message]
2021-05-02 8:38 ` Heiko Thiery
2021-05-02 11:20 ` Petr Vorel
2021-05-02 13:07 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0daa2b24-e326-05d2-c219-8a7ade7376e0@gmail.com \
--to=dsahern@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.