All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next v2] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented
Date: Sun, 2 May 2021 13:20:46 +0200	[thread overview]
Message-ID: <YI6LDhpn/Esl+Rf8@pevik> (raw)
In-Reply-To: <CAEyMn7ZtziLf__KOGWJfY5OUDoaHSN8jopbKJeK9ZSD1NsZDjw@mail.gmail.com>

> Hi David,

> Am Sa., 1. Mai 2021 um 17:03 Uhr schrieb David Ahern <dsahern@gmail.com>:

> > On 4/30/21 12:26 AM, Heiko Thiery wrote:
> > > With commit d5e6ee0dac64b64e the usage of functions name_to_handle_at() and

> > that is a change to ss:

> > d5e6ee0dac64 ss: introduce cgroup2 cache and helper functions


> > > open_by_handle_at() are introduced. But these function are not available
> > > e.g. in uclibc-ng < 1.0.35. To have a backward compatibility check for the
> > > availability in the configure script and in case of absence do a direct
> > > syscall.


> > When you find the proper commit add a Fixes line before the Signed-off-by:

> What do you mean with finding the right commit? This (d5e6ee0dac64) is
> the commit that introduced the usage of the missing functions. Or have
> I overlooked something?

Just put into commit message before your Signed-off-by tag this:

Fixes: d5e6ee0d ("ss: introduce cgroup2 cache and helper functions")

> > Fixes: <id> ("subject line")
> > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > > ---


Kind regards,
Petr

  reply	other threads:[~2021-05-02 11:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30  6:26 [PATCH iproute2-next v2] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented Heiko Thiery
2021-04-30 18:43 ` Petr Vorel
2021-04-30 19:07 ` Petr Vorel
2021-04-30 19:29   ` Petr Vorel
2021-05-02  8:35     ` Heiko Thiery
2021-05-02 11:16       ` Petr Vorel
2021-05-01 15:03 ` David Ahern
2021-05-02  8:38   ` Heiko Thiery
2021-05-02 11:20     ` Petr Vorel [this message]
2021-05-02 13:07       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YI6LDhpn/Esl+Rf8@pevik \
    --to=petr.vorel@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=heiko.thiery@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.