All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] alloc_tag: expose profiling and compression states in /proc/allocinfo
@ 2026-07-30 23:48 Abhishek Bapat
  2026-07-31  2:41 ` Hao Ge
  0 siblings, 1 reply; 2+ messages in thread
From: Abhishek Bapat @ 2026-07-30 23:48 UTC (permalink / raw)
  To: Suren Baghdasaryan, Andrew Morton, Hao Ge
  Cc: linux-kernel, linux-mm, Abhishek Bapat

Currently, userspace has limited visibility into the exact active
runtime state of memory allocation profiling and its page extension
compression ('sysctl.vm.mem_profiling={0|1|never}[,compressed]').

While reading the sysctl provides basic on/off status, it is currently
impossible for userspace to natively determine whether page-tag
compression was successfully enabled without scraping dmesg boot logs.

Resolve this ambiguity by exposing the active compression state by
adding a new read-only sysctl `vm.memprofiling_compressed` to output the
state.

Signed-off-by: Abhishek Bapat <abhishekbapat@google.com>
---
 mm/alloc_tag.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c
index 52aece27b00e..877068241f06 100644
--- a/mm/alloc_tag.c
+++ b/mm/alloc_tag.c
@@ -1303,6 +1303,12 @@ static const struct ctl_table memory_allocation_profiling_sysctls[] = {
 		.mode		= 0644,
 		.proc_handler	= proc_mem_profiling_handler,
 	},
+	{
+		.procname	= "mem_profiling_compressed",
+		.data		= &mem_profiling_compressed,
+		.mode		= 0444,
+		.proc_handler	= proc_do_static_key,
+	},
 };
 
 static void __init sysctl_init(void)

base-commit: 2ed26e8a624f41887d64e2e37a2f6ab36a118d1f
-- 
2.55.0.508.g3f0d502094-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] alloc_tag: expose profiling and compression states in /proc/allocinfo
  2026-07-30 23:48 [PATCH v2] alloc_tag: expose profiling and compression states in /proc/allocinfo Abhishek Bapat
@ 2026-07-31  2:41 ` Hao Ge
  0 siblings, 0 replies; 2+ messages in thread
From: Hao Ge @ 2026-07-31  2:41 UTC (permalink / raw)
  To: Abhishek Bapat, Suren Baghdasaryan; +Cc: linux-kernel, linux-mm, Andrew Morton

Hi Abhishek


Thanks for the v2 patch.


On 2026/7/31 07:48, Abhishek Bapat wrote:
> Currently, userspace has limited visibility into the exact active
> runtime state of memory allocation profiling and its page extension
> compression ('sysctl.vm.mem_profiling={0|1|never}[,compressed]').
>
> While reading the sysctl provides basic on/off status, it is currently
> impossible for userspace to natively determine whether page-tag
> compression was successfully enabled without scraping dmesg boot logs.
>
> Resolve this ambiguity by exposing the active compression state by
> adding a new read-only sysctl `vm.memprofiling_compressed` to output the
> state.


I think this should be vm.mem_profiling_compressed.

Otherwise, you will need to adjust the procname for this new sysctl 
accordingly.

Also, kindly add docs at the linked path.

https://elixir.bootlin.com/linux/v7.2-rc4/source/Documentation/mm/allocation-profiling.rst#L33


> Signed-off-by: Abhishek Bapat <abhishekbapat@google.com>
> ---
>   mm/alloc_tag.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c
> index 52aece27b00e..877068241f06 100644
> --- a/mm/alloc_tag.c
> +++ b/mm/alloc_tag.c
> @@ -1303,6 +1303,12 @@ static const struct ctl_table memory_allocation_profiling_sysctls[] = {
>   		.mode		= 0644,
>   		.proc_handler	= proc_mem_profiling_handler,
>   	},
> +	{
> +		.procname	= "mem_profiling_compressed",
> +		.data		= &mem_profiling_compressed,
> +		.mode		= 0444,
> +		.proc_handler	= proc_do_static_key,
> +	},
>   };
>   


I think adding this sysctl alone won't be enough.

If we set boot arg sysctl.vm.mem_profiling=1,compressed but profiling 
gets disabled due to insufficient page flags,

this sysctl will still report 1 (compression enabled) even though 
profiling was shut down.

To verify this behavior, I have set up a test environment locally as 
shown below:


[    0.265503] 4046 allocation tags cannot be references using 5 
available page flag bits. Memory allocation profiling is disabled!

[root@localhost ~]# cat /proc/sys/vm/mem_profiling_compressed
1
[root@localhost ~]#


I'm unsure whether we should initialize this sysctl when profiling gets 
disabled at boot.
If we do, we should set mem_profiling_compressed to false in 
shutdown_mem_profiling.


Thanks

Best Regards

Hao


>   static void __init sysctl_init(void)
>
> base-commit: 2ed26e8a624f41887d64e2e37a2f6ab36a118d1f


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-31  2:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 23:48 [PATCH v2] alloc_tag: expose profiling and compression states in /proc/allocinfo Abhishek Bapat
2026-07-31  2:41 ` Hao Ge

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.