* [PATCH 2/4] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
2013-07-17 12:17 [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Mark Brown
@ 2013-07-17 12:17 ` Mark Brown
2013-07-17 12:17 ` [PATCH 3/4] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2013-07-17 12:17 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
Fixed voltage regulators (and other similar free standing things) are
supposed to go on a simple-bus for DT correctness reasons.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index dab40ae..fa5969a 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -432,18 +432,24 @@
vdd-supply = <&ldo8_reg>;
};
- mmc_reg: voltage-regulator {
- compatible = "regulator-fixed";
- regulator-name = "VDD_33ON_2.8V";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- gpio = <&gpx1 1 1>;
- enable-active-high;
- };
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mmc_reg: voltage-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "VDD_33ON_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ gpio = <&gpx1 1 1>;
+ enable-active-high;
+ };
- reg_hdmi_en: fixedregulator@0 {
- compatible = "regulator-fixed";
- regulator-name = "hdmi-en";
+ reg_hdmi_en: fixedregulator@0 {
+ compatible = "regulator-fixed";
+ regulator-name = "hdmi-en";
+ };
};
fixed-rate-clocks {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/4] ARM: dts: Hook up supplies for Arndale S5M8767
2013-07-17 12:17 [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Mark Brown
2013-07-17 12:17 ` [PATCH 2/4] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
@ 2013-07-17 12:17 ` Mark Brown
2013-07-17 12:17 ` [PATCH 4/4] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-24 1:51 ` [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Kukjin Kim
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2013-07-17 12:17 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
As part of this add nodes for the main wall supply as well as bucks 7
and 8 which are used to drop that down for several of the LDOs.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 35 ++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index fa5969a..69a8651 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -41,6 +41,26 @@
interrupt-parent = <&gpx3>;
interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+ vinb1-supply = <&main_dc_reg>;
+ vinb2-supply = <&main_dc_reg>;
+ vinb3-supply = <&main_dc_reg>;
+ vinb4-supply = <&main_dc_reg>;
+ vinb5-supply = <&main_dc_reg>;
+ vinb6-supply = <&main_dc_reg>;
+ vinb7-supply = <&main_dc_reg>;
+ vinb8-supply = <&main_dc_reg>;
+ vinb9-supply = <&main_dc_reg>;
+
+ vinl1-supply = <&buck7_reg>;
+ vinl2-supply = <&buck7_reg>;
+ vinl3-supply = <&buck7_reg>;
+ vinl4-supply = <&main_dc_reg>;
+ vinl5-supply = <&main_dc_reg>;
+ vinl6-supply = <&main_dc_reg>;
+ vinl7-supply = <&main_dc_reg>;
+ vinl8-supply = <&buck8_reg>;
+ vinl9-supply = <&buck8_reg>;
+
s5m8767,pmic-buck2-dvs-voltage = <1300000>;
s5m8767,pmic-buck3-dvs-voltage = <1100000>;
s5m8767,pmic-buck4-dvs-voltage = <1200000>;
@@ -279,6 +299,16 @@
op_mode = <1>;
};
+ buck7_reg: BUCK7 {
+ regulator-name = "PVDD_BUCK7";
+ regulator-always-on;
+ };
+
+ buck8_reg: BUCK8 {
+ regulator-name = "PVDD_BUCK8";
+ regulator-always-on;
+ };
+
buck9_reg: BUCK9 {
regulator-name = "VDD_33_OFF_EXT1";
regulator-min-microvolt = <750000>;
@@ -437,6 +467,11 @@
#address-cells = <1>;
#size-cells = <0>;
+ main_dc_reg: fixedregulator@1 {
+ compatible = "regulator-fixed";
+ regulator-name = "MAIN_DC";
+ };
+
mmc_reg: voltage-regulator {
compatible = "regulator-fixed";
regulator-name = "VDD_33ON_2.8V";
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] ARM: dts: Add WM1811A audio CODEC to Arndale bindings
2013-07-17 12:17 [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Mark Brown
2013-07-17 12:17 ` [PATCH 2/4] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-17 12:17 ` [PATCH 3/4] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
@ 2013-07-17 12:17 ` Mark Brown
2013-07-24 1:51 ` [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Kukjin Kim
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2013-07-17 12:17 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
The default audio module for the Arndale has a WM1811A on it. Add this to
the device tree bindings.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 69a8651..96d528d 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -328,7 +328,22 @@
};
i2c@12C90000 {
- status = "disabled";
+ wm1811a@1a {
+ compatible = "wlf,wm1811";
+ reg = <0x1a>;
+
+ AVDD2-supply = <&main_dc_reg>;
+ CPVDD-supply = <&main_dc_reg>;
+ DBVDD1-supply = <&main_dc_reg>;
+ DBVDD2-supply = <&main_dc_reg>;
+ DBVDD3-supply = <&main_dc_reg>;
+ LDO1VDD-supply = <&main_dc_reg>;
+ SPKVDD1-supply = <&main_dc_reg>;
+ SPKVDD2-supply = <&main_dc_reg>;
+
+ wlf,ldo1ena = <&gpb0 0 0>;
+ wlf,ldo2ena = <&gpb0 1 0>;
+ };
};
i2c@12CA0000 {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale
2013-07-17 12:17 [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale Mark Brown
` (2 preceding siblings ...)
2013-07-17 12:17 ` [PATCH 4/4] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
@ 2013-07-24 1:51 ` Kukjin Kim
3 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2013-07-24 1:51 UTC (permalink / raw)
To: 'Mark Brown'
Cc: linux-samsung-soc, linaro-kernel, 'Mark Brown'
Mark Brown wrote:
>
> From: Mark Brown <broonie@linaro.org>
>
> The out of tree code configures a pullup on the line indicating that it
> is an active low interrupt.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> arch/arm/boot/dts/exynos5250-arndale.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> b/arch/arm/boot/dts/exynos5250-arndale.dts
> index abc7272..dab40ae 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -11,6 +11,7 @@
>
> /dts-v1/;
> #include "exynos5250.dtsi"
> +#include <dt-bindings/interrupt-controller/irq.h>
>
> / {
> model = "Insignal Arndale evaluation board based on EXYNOS5250";
> @@ -37,6 +38,8 @@
> s5m8767_pmic@66 {
> compatible = "samsung,s5m8767-pmic";
> reg = <0x66>;
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
>
> s5m8767,pmic-buck2-dvs-voltage = <1300000>;
> s5m8767,pmic-buck3-dvs-voltage = <1100000>;
> --
> 1.8.3.2
I'm fine on this whole series. Applied 1 to 4, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread