From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Yang <hongliang.yang@cixtech.com>,
peter.chen@kernel.org, gregkh@linuxfoundation.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: p.zabel@pengutronix.de, vkoul@kernel.org,
neil.armstrong@linaro.org, pawell@cadence.com, rogerq@kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1
Date: Sun, 6 Sep 2026 08:41:37 +0200 [thread overview]
Message-ID: <0df645f6-6455-434a-a0fe-542b4c968679@kernel.org> (raw)
In-Reply-To: <20260906032440.470788-5-hongliang.yang@cixtech.com>
On 06/09/2026 05:24, Hongliang Yang wrote:
> Add USB4 and USB5 controller nodes for the CIX Sky1 SoC. Enable USB4
> and USB5 in host mode on the Radxa Orion O6 board.
>
> The per-controller RCSU registers are accessed through a syscon regmap
> referenced by the cix,usb-rcsu phandle.
>
> The shared RCSU slice of the two controllers is described by a syscon
> node; each controller references its registers through the cix,usb-rcsu
> phandle with offsets.
> Signed-off-by: Hongliang Yang <hongliang.yang@cixtech.com>
Odd style. Please read `git commit` help page to understand how to add
the tag properly.
> ---
> arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 42 +++++++++++
> arch/arm64/boot/dts/cix/sky1.dtsi | 88 +++++++++++++++++++++++
> 2 files changed, 130 insertions(+)
For the last time, read my v2 feedback
Which subsystems do you target here?
Which subsystems do you target in the previous patch?
Why are you combining them, even though I asked not?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-06 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 3:24 [PATCH v4 0/4] Add CIX Sky1 USBSSP controller support Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 1/4] dt-bindings: usb: Add CIX Sky1 USBSSP RCSU system controller Hongliang Yang
2026-09-06 6:45 ` Krzysztof Kozlowski
2026-09-07 8:15 ` Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 2/4] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-06 6:55 ` Krzysztof Kozlowski
2026-09-10 2:52 ` Hongliang Yang
2026-09-23 2:58 ` Hongliang Yang
2026-09-23 6:30 ` Krzysztof Kozlowski
2026-09-09 7:51 ` Krzysztof Kozlowski
2026-09-06 3:24 ` [PATCH v4 3/4] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-09-06 6:41 ` Krzysztof Kozlowski [this message]
2026-09-09 7:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df645f6-6455-434a-a0fe-542b4c968679@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hongliang.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.