From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Yang <hongliang.yang@cixtech.com>,
peter.chen@kernel.org, gregkh@linuxfoundation.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: p.zabel@pengutronix.de, vkoul@kernel.org,
neil.armstrong@linaro.org, pawell@cadence.com, rogerq@kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: usb: Add CIX Sky1 USBSSP RCSU system controller
Date: Sun, 6 Sep 2026 08:45:19 +0200 [thread overview]
Message-ID: <f76cef66-1283-440e-9530-6eb7168c6e58@kernel.org> (raw)
In-Reply-To: <20260906032440.470788-2-hongliang.yang@cixtech.com>
On 06/09/2026 05:24, Hongliang Yang wrote:
> Add device tree binding for the per-controller RCSU register regions
> of the CIX Sky1 USBSSP controllers. The regions are exposed as syscon
> nodes; USBSSP glue nodes reference their per-controller registers
> through the cix,usb-rcsu phandle with register offsets.
>
> The per-controller RCSU control and status registers live in a shared
> RCSU region described by the cix,sky1-usbss-rcsu binding and are
> referenced through the cix,usb-rcsu phandle.
> Signed-off-by: Hongliang Yang <hongliang.yang@cixtech.com>
> ---
> .../bindings/usb/cix,sky1-usbss-rcsu.yaml | 46 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/cix,sky1-usbss-rcsu.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/cix,sky1-usbss-rcsu.yaml b/Documentation/devicetree/bindings/usb/cix,sky1-usbss-rcsu.yaml
> new file mode 100644
> index 000000000000..d0c54fd2cd5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cix,sky1-usbss-rcsu.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/cix,sky1-usbss-rcsu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 USBSSP RCSU system controller
> +
> +maintainers:
> + - Hongliang Yang <hongliang.yang@cixtech.com>
> +
> +description:
> + The CIX Sky1 USBSSP controllers integrate their per-instance glue
> + registers (AXI bus attribute configuration and controller status)
> + inside a shared RCSU register region in the SoC system control
> + aperture. This binding describes that region as a syscon, so USBSSP
In the description you describe hardware, not binding.
> + glue nodes can reference their register offsets through the
> + cix,usb-rcsu phandle (see cix,sky1-usbssp.yaml).
Syscon is not a USB device. This is not supposed to be in USB.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-06 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 3:24 [PATCH v4 0/4] Add CIX Sky1 USBSSP controller support Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 1/4] dt-bindings: usb: Add CIX Sky1 USBSSP RCSU system controller Hongliang Yang
2026-09-06 6:45 ` Krzysztof Kozlowski [this message]
2026-09-07 8:15 ` Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 2/4] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-06 6:55 ` Krzysztof Kozlowski
2026-09-10 2:52 ` Hongliang Yang
2026-09-09 7:51 ` Krzysztof Kozlowski
2026-09-06 3:24 ` [PATCH v4 3/4] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-06 3:24 ` [PATCH v4 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-09-06 6:41 ` Krzysztof Kozlowski
2026-09-09 7:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f76cef66-1283-440e-9530-6eb7168c6e58@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hongliang.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.