All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Seongjae Jeong <jsjlee1020@gmail.com>
Cc: chao@kernel.org, jaegeuk@kernel.org, yi.sun@unisoc.com,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: skip further SIT updates for already invalidated blocks
Date: Thu, 12 Nov 2026 16:30:58 +0800	[thread overview]
Message-ID: <0e156b8a-2876-4bbe-b16c-55c70b3201b3@kernel.org> (raw)
In-Reply-To: <CAPHXVry2O-AYxTvGdzu+m6b3Q=ho=xL0kpWWqCn0vjj-gOe0ZQ@mail.gmail.com>

On 11/12/26 11:48, Seongjae Jeong wrote:
> Hi Chao,
> 
> Thanks for checking.
> I agree that 81ffbd224e5f is the right Fixes tag.
> 
> I’ve sent v2 with stable on Cc and an additional Fixes tag for
> a66cdd985532 to cover the discard bitmap handling. Does the second
> Fixes tag look appropriate to you?

Hi SeongJae,

I don't see how commit a66cdd985532 ("f2fs: introduce discard_map for f2fs_trim_fs")
introduce the bug? from the timeline, at that point there is no error handling in
update_sit_entries() if sit bitmap is inconsistent, right?

Thanks,

> 
> Thanks,
> Seongjae


WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Seongjae Jeong <jsjlee1020@gmail.com>
Cc: jaegeuk@kernel.org, yi.sun@unisoc.com,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: skip further SIT updates for already invalidated blocks
Date: Thu, 12 Nov 2026 16:30:58 +0800	[thread overview]
Message-ID: <0e156b8a-2876-4bbe-b16c-55c70b3201b3@kernel.org> (raw)
In-Reply-To: <CAPHXVry2O-AYxTvGdzu+m6b3Q=ho=xL0kpWWqCn0vjj-gOe0ZQ@mail.gmail.com>

On 11/12/26 11:48, Seongjae Jeong wrote:
> Hi Chao,
> 
> Thanks for checking.
> I agree that 81ffbd224e5f is the right Fixes tag.
> 
> I’ve sent v2 with stable on Cc and an additional Fixes tag for
> a66cdd985532 to cover the discard bitmap handling. Does the second
> Fixes tag look appropriate to you?

Hi SeongJae,

I don't see how commit a66cdd985532 ("f2fs: introduce discard_map for f2fs_trim_fs")
introduce the bug? from the timeline, at that point there is no error handling in
update_sit_entries() if sit bitmap is inconsistent, right?

Thanks,

> 
> Thanks,
> Seongjae



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-11-12  8:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04  6:10 [f2fs-dev] [PATCH] f2fs: skip further SIT updates for already invalidated blocks Seongjae Jeong
2026-10-04  6:10 ` Seongjae Jeong
2026-10-11  8:16 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-10-11  8:16   ` Chao Yu
2026-10-11 10:39   ` [f2fs-dev] " Seongjae Jeong
2026-10-11 10:39     ` Seongjae Jeong
2026-11-11  9:04     ` Chao Yu
2026-11-11  9:04       ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-12  3:48       ` Seongjae Jeong
2026-11-12  3:48         ` [f2fs-dev] " Seongjae Jeong
2026-11-12  8:30         ` Chao Yu [this message]
2026-11-12  8:30           ` Chao Yu via Linux-f2fs-devel
2026-11-12 10:36           ` Seongjae Jeong
2026-11-12 10:36             ` Seongjae Jeong
2026-11-13  9:31             ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-13  9:31               ` Chao Yu
2026-11-13 10:33               ` [f2fs-dev] " Seongjae Jeong
2026-11-13 10:33                 ` Seongjae Jeong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e156b8a-2876-4bbe-b16c-55c70b3201b3@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=jsjlee1020@gmail.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.sun@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.