From: Kukjin Kim <kgene@kernel.org>
To: 'Amit Daniel Kachhap' <amit.daniel@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
'Thomas Abraham' <thomas.abraham@linaro.org>,
'Abhilash Kesavan' <a.kesavan@samsung.com>
Subject: RE: [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's.
Date: Wed, 24 Jul 2013 14:15:34 +0900 [thread overview]
Message-ID: <0e2301ce882c$d39021a0$7ab064e0$@org> (raw)
In-Reply-To: <1371036526-16589-3-git-send-email-amit.daniel@samsung.com>
Amit Daniel Kachhap wrote:
>
> This patch registers the basic C0 state for all exynos SOC's but
> limits the C1(AFTR -Arm off top running) state in only the supported
> SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250).
>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
> arch/arm/mach-exynos/cpuidle.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-
> exynos/cpuidle.c
> index 2d071c6..ccb2b48 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -176,7 +176,9 @@ static int __init exynos4_init_cpuidle(void)
> device->cpu = cpu_id;
>
> /* Support IDLE only */
> - if (cpu_id != 0)
> + if (!(soc_is_exynos4210() || soc_is_exynos4212() ||
> + soc_is_exynos4412() || soc_is_exynos5250()) ||
> + cpu_id != 0)
How about exynos5420?
So...
+ if (soc_is_exynos5440() || cpu_id !=0) ?
> device->state_count = 1;
>
> ret = cpuidle_register_device(device);
> --
> 1.7.1
- Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's.
Date: Wed, 24 Jul 2013 14:15:34 +0900 [thread overview]
Message-ID: <0e2301ce882c$d39021a0$7ab064e0$@org> (raw)
In-Reply-To: <1371036526-16589-3-git-send-email-amit.daniel@samsung.com>
Amit Daniel Kachhap wrote:
>
> This patch registers the basic C0 state for all exynos SOC's but
> limits the C1(AFTR -Arm off top running) state in only the supported
> SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250).
>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
> arch/arm/mach-exynos/cpuidle.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-
> exynos/cpuidle.c
> index 2d071c6..ccb2b48 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -176,7 +176,9 @@ static int __init exynos4_init_cpuidle(void)
> device->cpu = cpu_id;
>
> /* Support IDLE only */
> - if (cpu_id != 0)
> + if (!(soc_is_exynos4210() || soc_is_exynos4212() ||
> + soc_is_exynos4412() || soc_is_exynos5250()) ||
> + cpu_id != 0)
How about exynos5420?
So...
+ if (soc_is_exynos5440() || cpu_id !=0) ?
> device->state_count = 1;
>
> ret = cpuidle_register_device(device);
> --
> 1.7.1
- Kukjin
next prev parent reply other threads:[~2013-07-24 5:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 11:28 [PATCH V2 0/2] ARM: EXYNOS: cpuidle: fixes in exynos cpuidle/PM Amit Daniel Kachhap
2013-06-12 11:28 ` Amit Daniel Kachhap
2013-06-12 11:28 ` [PATCH V2 1/2] ARM: SAMSUNG: Add SAMSUNG_PM config option to select pm Amit Daniel Kachhap
2013-06-12 11:28 ` Amit Daniel Kachhap
2013-06-13 12:42 ` Kukjin Kim
2013-06-13 12:42 ` Kukjin Kim
2013-06-14 4:25 ` amit daniel kachhap
2013-06-14 4:25 ` amit daniel kachhap
2013-07-24 4:54 ` Kukjin Kim
2013-07-24 4:54 ` Kukjin Kim
2013-07-24 5:58 ` amit daniel kachhap
2013-07-24 5:58 ` amit daniel kachhap
2013-06-12 11:28 ` [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's Amit Daniel Kachhap
2013-06-12 11:28 ` Amit Daniel Kachhap
2013-07-24 5:15 ` Kukjin Kim [this message]
2013-07-24 5:15 ` Kukjin Kim
2013-07-24 5:59 ` amit daniel kachhap
2013-07-24 5:59 ` amit daniel kachhap
2013-07-24 7:36 ` Kukjin Kim
2013-07-24 7:36 ` Kukjin Kim
2013-07-24 9:53 ` [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 Amit Daniel Kachhap
2013-07-24 9:53 ` Amit Daniel Kachhap
2013-07-24 11:47 ` Kukjin Kim
2013-07-24 11:47 ` Kukjin Kim
2013-07-28 7:10 ` Daniel Lezcano
2013-07-28 7:10 ` Daniel Lezcano
2013-07-28 9:22 ` Tomasz Figa
2013-07-28 9:22 ` Tomasz Figa
2013-07-28 10:31 ` Daniel Lezcano
2013-07-28 10:31 ` Daniel Lezcano
2013-07-28 10:46 ` Tomasz Figa
2013-07-28 10:46 ` Tomasz Figa
2013-07-29 4:46 ` amit daniel kachhap
2013-07-29 4:46 ` amit daniel kachhap
2013-07-29 5:34 ` Kukjin Kim
2013-07-29 5:34 ` Kukjin Kim
2013-07-29 8:33 ` Tomasz Figa
2013-07-29 8:33 ` Tomasz Figa
2013-07-29 9:33 ` amit daniel kachhap
2013-07-29 9:33 ` amit daniel kachhap
2013-07-29 10:06 ` Daniel Lezcano
2013-07-29 10:06 ` Daniel Lezcano
2013-07-25 11:19 ` Bartlomiej Zolnierkiewicz
2013-07-25 11:19 ` Bartlomiej Zolnierkiewicz
2013-07-24 9:55 ` [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's amit daniel kachhap
2013-07-24 9:55 ` amit daniel kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0e2301ce882c$d39021a0$7ab064e0$@org' \
--to=kgene@kernel.org \
--cc=a.kesavan@samsung.com \
--cc=amit.daniel@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.