From: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 3/9] media: iris: Replace enum-indexed clock and power domain tables with per-block structures
Date: Tue, 22 Sep 2026 23:39:17 +0530 [thread overview]
Message-ID: <0eea448d-da5c-434a-909f-b50cc7c57754@oss.qualcomm.com> (raw)
In-Reply-To: <20260917-glymur-v11-3-e0c8bc914742@oss.qualcomm.com>
On 9/17/2026 10:30 AM, Vishnu Reddy wrote:
> As new platforms are added, the platform_clk_type and
> platform_pm_domain_type enums keep growing. Every new clock or
> power domain requires a new enum entry, and every enable/disable
> path has to loop through the clock table to find the right clock
> by enum value, adding overhead and boilerplate on each path.
> The enum index space is also shared across all hardware blocks.
> On the Glymur platform, the VPP0 index for VPU4x and the VCODEC1
> index clash, making it error-prone to extend support without
> breaking existing platforms.
> Replace the flat tables and enum-based lookups with
> iris_power_domain, which bundles a power domain device and its
> associated clocks together per hardware block. Platform data
> describes each block via iris_power_domain_data, and the enable
> and disable helpers operate directly on an iris_power_domain
> instance, removing the need for any index lookup at runtime.
>
> Signed-off-by: Vishnu Reddy<busanna.reddy@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_core.h | 23 +++-
> .../platform/qcom/iris/iris_platform_common.h | 41 ++----
> .../platform/qcom/iris/iris_platform_sc7280.h | 28 ++++-
> .../platform/qcom/iris/iris_platform_sm8250.h | 26 +++-
> .../platform/qcom/iris/iris_platform_sm8550.h | 26 +++-
> .../platform/qcom/iris/iris_platform_sm8750.h | 29 +++--
> .../media/platform/qcom/iris/iris_platform_vpu2.c | 20 +--
> .../media/platform/qcom/iris/iris_platform_vpu3x.c | 32 ++---
> .../platform/qcom/iris/iris_platform_x1p42100.h | 27 +++-
> drivers/media/platform/qcom/iris/iris_probe.c | 137 +++++++++++++++++++--
> drivers/media/platform/qcom/iris/iris_resources.c | 81 ++++++------
> drivers/media/platform/qcom/iris/iris_resources.h | 8 +-
> drivers/media/platform/qcom/iris/iris_vpu3x.c | 37 +-----
> drivers/media/platform/qcom/iris/iris_vpu4x.c | 137 +++------------------
> drivers/media/platform/qcom/iris/iris_vpu_common.c | 98 ++-------------
> 15 files changed, 347 insertions(+), 403 deletions(-)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
next prev parent reply other threads:[~2026-09-22 18:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 5:00 [PATCH v11 0/9] media: iris: Add support for glymur platform Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 1/9] dt-bindings: media: qcom,glymur-iris: Add glymur video codec Vishnu Reddy
2026-09-22 12:59 ` Dmitry Baryshkov
2026-09-23 5:41 ` Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 2/9] media: iris: Enable Secure PAS support with IOMMU managed by Linux Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 3/9] media: iris: Replace enum-indexed clock and power domain tables with per-block structures Vishnu Reddy
2026-09-22 13:03 ` Dmitry Baryshkov
2026-09-22 18:09 ` Vikash Garodia [this message]
2026-09-17 5:00 ` [PATCH v11 4/9] media: iris: Add power sequence for glymur Vishnu Reddy
2026-09-22 13:02 ` Dmitry Baryshkov
2026-09-17 5:00 ` [PATCH v11 5/9] media: iris: Handle CPU_CS_SCIACMDARG3 register write via program bootup registers hook Vishnu Reddy
2026-09-22 18:10 ` Vikash Garodia
2026-09-17 5:00 ` [PATCH v11 6/9] media: iris: Add support to select core for dual core platforms Vishnu Reddy
2026-09-22 18:11 ` Vikash Garodia
2026-09-17 5:00 ` [PATCH v11 7/9] media: iris: Add platform data for glymur Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 8/9] arm64: dts: qcom: glymur: Add iris video node Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 9/9] arm64: dts: qcom: glymur-crd: Enable iris video codec node Vishnu Reddy
2026-09-17 7:09 ` [PATCH v11 0/9] media: iris: Add support for glymur platform Krzysztof Kozlowski
2026-09-17 7:11 ` Krzysztof Kozlowski
2026-09-18 6:57 ` Vishnu Reddy
2026-09-18 7:00 ` Krzysztof Kozlowski
2026-09-22 12:45 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eea448d-da5c-434a-909f-b50cc7c57754@oss.qualcomm.com \
--to=vikash.garodia@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.