All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: James Hilliard <james.hilliard1@gmail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>
Subject: Re: [PATCH v3 02/58] mtd: acquire an MTD handle from a referenced class device
Date: Thu, 19 Nov 2026 15:28:49 +0000	[thread overview]
Message-ID: <0f262ab4-9431-4720-9422-0ee2155fa933@linux.dev> (raw)
In-Reply-To: <20261111-submit-rawnand-retained-handle-lifetime-v1-v3-2-ce537999741d@gmail.com>

On 12/11/2026 01:27, James Hilliard wrote:
> PTP OCP locates flash through the device hierarchy and uses driver data
> directly. A class-device reference does not keep an MTD registered or own
> the backing object needed by an erase or write.
> 
> Look up the exact device under mtd_table_mutex and acquire an ordinary MTD
> handle before returning it. Use that handle for the OCP update and release
> it on every exit. A removed device cannot be confused with a replacement
> that reuses its name or number.
> 
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
> Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   drivers/mtd/mtdcore.c   | 23 +++++++++++++++++++++++
>   drivers/ptp/ptp_ocp.c   |  7 ++++++-
>   include/linux/mtd/mtd.h |  1 +
>   3 files changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 30b16f135f07..620326279957 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1329,6 +1329,29 @@ struct mtd_info *get_mtd_device(struct mtd_info *mtd, int num)
>   EXPORT_SYMBOL_GPL(get_mtd_device);
>   
>   
> +/**
> + * get_mtd_device_by_dev - acquire the MTD associated with a class device
> + * @dev: referenced MTD class device
> + *
> + * Return: a referenced MTD, or an error if the device has been removed.
> + */
> +struct mtd_info *get_mtd_device_by_dev(struct device *dev)
> +{
> +	struct mtd_info *mtd;
> +	int err;
> +
> +	guard(mutex)(&mtd_table_mutex);
> +	mtd_for_each_device(mtd) {
> +		if (&mtd->dev != dev)
> +			continue;
> +		err = __get_mtd_device(mtd);
> +		return err ? ERR_PTR(err) : mtd;
> +	}
> +	return ERR_PTR(-ENODEV);
> +}
> +EXPORT_SYMBOL_GPL(get_mtd_device_by_dev);
> +
> +
>   int __get_mtd_device(struct mtd_info *mtd)
>   {
>   	struct mtd_info *master = mtd_get_master(mtd);
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 3d26ec1f7b9e..459aeb24ae6b 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -2083,7 +2083,7 @@ static int
>   ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   		      const struct firmware *fw)
>   {
> -	struct mtd_info *mtd = dev_get_drvdata(dev);
> +	struct mtd_info *mtd;
>   	struct ptp_ocp *bp = devlink_priv(devlink);
>   	size_t off, len, size, resid, wrote;
>   	struct erase_info erase;
> @@ -2091,6 +2091,10 @@ ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   	const u8 *data;
>   	int err;
>   
> +	mtd = get_mtd_device_by_dev(dev);
> +	if (IS_ERR(mtd))
> +		return PTR_ERR(mtd);
> +
>   	err = ptp_ocp_devlink_fw_image(devlink, fw, &data, &size);
>   	if (err)
>   		goto out;
> @@ -2120,6 +2124,7 @@ ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   		resid -= len;
>   	}
>   out:
> +	put_mtd_device(mtd);
>   	return err;
>   }
>   
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index cd7b4671c456..745655e0d462 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -684,6 +684,7 @@ extern int mtd_device_parse_register(struct mtd_info *mtd,
>   	mtd_device_parse_register(master, NULL, NULL, parts, nr_parts)
>   extern int mtd_device_unregister(struct mtd_info *master);
>   extern struct mtd_info *get_mtd_device(struct mtd_info *mtd, int num);
> +struct mtd_info *get_mtd_device_by_dev(struct device *dev);
>   extern int __get_mtd_device(struct mtd_info *mtd);
>   extern void __put_mtd_device(struct mtd_info *mtd);
>   extern struct mtd_info *of_get_mtd_device_by_node(struct device_node *np);
> 

Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

WARNING: multiple messages have this Message-ID (diff)
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: James Hilliard <james.hilliard1@gmail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>
Subject: Re: [PATCH v3 02/58] mtd: acquire an MTD handle from a referenced class device
Date: Thu, 19 Nov 2026 15:28:49 +0000	[thread overview]
Message-ID: <0f262ab4-9431-4720-9422-0ee2155fa933@linux.dev> (raw)
In-Reply-To: <20261111-submit-rawnand-retained-handle-lifetime-v1-v3-2-ce537999741d@gmail.com>

On 12/11/2026 01:27, James Hilliard wrote:
> PTP OCP locates flash through the device hierarchy and uses driver data
> directly. A class-device reference does not keep an MTD registered or own
> the backing object needed by an erase or write.
> 
> Look up the exact device under mtd_table_mutex and acquire an ordinary MTD
> handle before returning it. Use that handle for the OCP update and release
> it on every exit. A removed device cannot be confused with a replacement
> that reuses its name or number.
> 
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
> Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   drivers/mtd/mtdcore.c   | 23 +++++++++++++++++++++++
>   drivers/ptp/ptp_ocp.c   |  7 ++++++-
>   include/linux/mtd/mtd.h |  1 +
>   3 files changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 30b16f135f07..620326279957 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1329,6 +1329,29 @@ struct mtd_info *get_mtd_device(struct mtd_info *mtd, int num)
>   EXPORT_SYMBOL_GPL(get_mtd_device);
>   
>   
> +/**
> + * get_mtd_device_by_dev - acquire the MTD associated with a class device
> + * @dev: referenced MTD class device
> + *
> + * Return: a referenced MTD, or an error if the device has been removed.
> + */
> +struct mtd_info *get_mtd_device_by_dev(struct device *dev)
> +{
> +	struct mtd_info *mtd;
> +	int err;
> +
> +	guard(mutex)(&mtd_table_mutex);
> +	mtd_for_each_device(mtd) {
> +		if (&mtd->dev != dev)
> +			continue;
> +		err = __get_mtd_device(mtd);
> +		return err ? ERR_PTR(err) : mtd;
> +	}
> +	return ERR_PTR(-ENODEV);
> +}
> +EXPORT_SYMBOL_GPL(get_mtd_device_by_dev);
> +
> +
>   int __get_mtd_device(struct mtd_info *mtd)
>   {
>   	struct mtd_info *master = mtd_get_master(mtd);
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 3d26ec1f7b9e..459aeb24ae6b 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -2083,7 +2083,7 @@ static int
>   ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   		      const struct firmware *fw)
>   {
> -	struct mtd_info *mtd = dev_get_drvdata(dev);
> +	struct mtd_info *mtd;
>   	struct ptp_ocp *bp = devlink_priv(devlink);
>   	size_t off, len, size, resid, wrote;
>   	struct erase_info erase;
> @@ -2091,6 +2091,10 @@ ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   	const u8 *data;
>   	int err;
>   
> +	mtd = get_mtd_device_by_dev(dev);
> +	if (IS_ERR(mtd))
> +		return PTR_ERR(mtd);
> +
>   	err = ptp_ocp_devlink_fw_image(devlink, fw, &data, &size);
>   	if (err)
>   		goto out;
> @@ -2120,6 +2124,7 @@ ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
>   		resid -= len;
>   	}
>   out:
> +	put_mtd_device(mtd);
>   	return err;
>   }
>   
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index cd7b4671c456..745655e0d462 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -684,6 +684,7 @@ extern int mtd_device_parse_register(struct mtd_info *mtd,
>   	mtd_device_parse_register(master, NULL, NULL, parts, nr_parts)
>   extern int mtd_device_unregister(struct mtd_info *master);
>   extern struct mtd_info *get_mtd_device(struct mtd_info *mtd, int num);
> +struct mtd_info *get_mtd_device_by_dev(struct device *dev);
>   extern int __get_mtd_device(struct mtd_info *mtd);
>   extern void __put_mtd_device(struct mtd_info *mtd);
>   extern struct mtd_info *of_get_mtd_device_by_node(struct device_node *np);
> 

Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-19 15:28 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  1:27 [PATCH v3 00/58] mtd: rawnand: retain chip and controller state across removal James Hilliard
2026-11-12  1:27 ` James Hilliard
2026-11-12  1:27 ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 01/58] nvmem: disconnect provider callbacks before unregister returns James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  2:00   ` sashiko-bot
2026-11-12  1:27 ` [PATCH v3 02/58] mtd: acquire an MTD handle from a referenced class device James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-19 15:28   ` Vadim Fedorenko [this message]
2026-11-19 15:28     ` Vadim Fedorenko
2026-11-12  1:27 ` [PATCH v3 03/58] mtd: separate class devices from retained backing objects James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  2:48   ` sashiko-bot
2026-11-12  1:27 ` [PATCH v3 04/58] mtd: retain virtual concatenations across component removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  3:09   ` sashiko-bot
2026-11-12  1:27 ` [PATCH v3 05/58] mtd: rawnand: separate hardware disconnection from cleanup James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 06/58] mtd: rawnand: share retained chip and controller ownership James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 07/58] mtd: rawnand: sunxi: retain chip state until the final MTD put James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 08/58] mtd: rawnand: plat_nand: retain open-handle state on removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 09/58] mtd: rawnand: gpio: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 10/58] mtd: rawnand: stm32_fmc2: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 11/58] mtd: rawnand: denali: retain chips across controller removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 12/58] mtd: rawnand: arasan: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 13/58] mtd: rawnand: mxic: retain open-handle state on removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 14/58] mtd: rawnand: intel: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 15/58] mtd: rawnand: tegra: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 16/58] mtd: rawnand: mtk: retain chips across controller removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 17/58] mtd: rawnand: rockchip: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 18/58] mtd: rawnand: atmel: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 19/58] mtd: rawnand: orion: retain open-handle state on removal James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:27 ` [PATCH v3 20/58] mtd: rawnand: socrates: " James Hilliard
2026-11-12  1:27   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 21/58] mtd: rawnand: fsl_upm: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 22/58] mtd: rawnand: pasemi: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 23/58] mtd: rawnand: ams-delta: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 24/58] mtd: rawnand: xway: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 25/58] mtd: rawnand: hisi504: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 26/58] mtd: rawnand: vf610: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 27/58] mtd: rawnand: technologic: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 28/58] mtd: rawnand: loongson: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 29/58] mtd: rawnand: ma35d1: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 30/58] mtd: rawnand: pl35x: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 31/58] mtd: rawnand: mxc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 32/58] mtd: rawnand: fsmc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 33/58] mtd: rawnand: gpmi: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 34/58] mtd: rawnand: omap2: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 35/58] mtd: rawnand: marvell: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 36/58] mtd: rawnand: renesas: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 37/58] mtd: rawnand: meson: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 38/58] mtd: rawnand: cadence: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 39/58] mtd: rawnand: qcom: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 40/58] mtd: rawnand: cafe: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 41/58] mtd: rawnand: brcmnand: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 42/58] mtd: rawnand: au1550nd: retain chip state across removal James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 43/58] mtd: rawnand: sharpsl: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 44/58] mtd: rawnand: davinci: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 45/58] mtd: rawnand: sh_flctl: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 46/58] mtd: rawnand: lpc32xx_slc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 47/58] mtd: rawnand: lpc32xx_mlc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 48/58] mtd: rawnand: ndfc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 49/58] mtd: rawnand: txx9ndfmc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 50/58] mtd: rawnand: ingenic: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 51/58] mtd: rawnand: mpc5121: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 52/58] mtd: rawnand: bcm47xxnflash: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 53/58] mtd: rawnand: fsl_elbc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 54/58] mtd: rawnand: fsl_ifc: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 55/58] mtd: rawnand: r852: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 56/58] mtd: rawnand: nandsim: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 57/58] mtd: rawnand: cs553x: " James Hilliard
2026-11-12  1:28   ` James Hilliard
2026-11-12  1:28 ` [PATCH v3 58/58] mtd: rawnand: diskonchip: " James Hilliard
2026-11-12  1:28   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f262ab4-9431-4720-9422-0ee2155fa933@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hilliard1@gmail.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=richardcochran@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.