From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Matt Fleming <matt@readmodwrite.com>
Cc: John Stultz <jstultz@google.com>, Ingo Molnar <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
<linux-kernel@vger.kernel.org>, <kernel-team@cloudflare.com>,
Matt Fleming <mfleming@cloudflare.com>,
"Oleg Nesterov" <oleg@redhat.com>,
Chris Arges <carges@cloudflare.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks"
Date: Mon, 29 Sep 2025 09:23:06 +0530 [thread overview]
Message-ID: <0fc0943c-8ec1-47dd-9b3a-82c68c6bde34@amd.com> (raw)
In-Reply-To: <CAENh_SRj9pMyMLZAM0WVr3tuD5ogMQySzkPoiHu4SRoGFkmnZw@mail.gmail.com>
Hello Matt,
On 9/26/2025 9:04 PM, Matt Fleming wrote:
> On Fri, Sep 26, 2025 at 3:43 AM K Prateek Nayak <kprateek.nayak@amd.com> wrote:
>>
>> Hello John, Matt,
>>
>> On 9/26/2025 5:35 AM, John Stultz wrote:
>>>
>>> However, there are two spots where we might exit dequeue_entities()
>>> early when cfs_rq_throttled(rq), so maybe that's what's catching us
>>> here?
>>
>> That could very likely be it.
>
> That tracks -- we're heavy users of cgroups and this particular issue
> only appeared on our kubernetes nodes.
>
>> Matt, if possible can you try the patch attached below to check if the
>> bailout for throttled hierarchy is indeed the root cause. Thanks in
>> advance.
>
> I've been running our reproducer with this patch for the last few
> hours without any issues, so the fix looks good to me.
>
> Tested-by: Matt Fleming <mfleming@cloudflare.com>
Thank you for testing the diff. I see Ingo has already posted the
scheduler pull for v6.18 which indirectly solves this by removing those
early returns.
Once that lands, I'll attach a formal commit log and send out a patch
targeting the stable kernels >= 6.12.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2025-09-29 3:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 13:33 [PATCH] Revert "sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks" Matt Fleming
2025-09-26 0:05 ` John Stultz
2025-09-26 0:06 ` John Stultz
2025-09-26 2:43 ` K Prateek Nayak
2025-09-26 15:34 ` Matt Fleming
2025-09-29 3:53 ` K Prateek Nayak [this message]
2025-10-14 10:15 ` Matt Fleming
2025-10-15 6:03 ` [PATCH v6.12] sched/fair: Block delayed tasks on throttled hierarchy during dequeue K Prateek Nayak
2025-10-15 6:14 ` Greg Kroah-Hartman
2025-10-15 6:27 ` K Prateek Nayak
2025-10-15 7:27 ` Greg Kroah-Hartman
2025-10-15 8:22 ` Peter Zijlstra
2025-10-23 4:03 ` [PATCH 6.17] " K Prateek Nayak
2025-09-29 10:38 ` [PATCH] Revert "sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks" Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc0943c-8ec1-47dd-9b3a-82c68c6bde34@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=carges@cloudflare.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@readmodwrite.com \
--cc=mfleming@cloudflare.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.