All of lore.kernel.org
 help / color / mirror / Atom feed
From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>, <stable@vger.kernel.org>,
	Matt Fleming <matt@readmodwrite.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	<linux-kernel@vger.kernel.org>,
	"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	"Valentin Schneider" <vschneid@redhat.com>,
	<kernel-team@cloudflare.com>,
	Matt Fleming <mfleming@cloudflare.com>,
	Oleg Nesterov <oleg@redhat.com>, John Stultz <jstultz@google.com>,
	Chris Arges <carges@cloudflare.com>
Subject: Re: [PATCH v6.12] sched/fair: Block delayed tasks on throttled hierarchy during dequeue
Date: Wed, 15 Oct 2025 11:57:19 +0530	[thread overview]
Message-ID: <fe9320d4-9da0-4de8-8e1e-ec03ecf582a1@amd.com> (raw)
In-Reply-To: <2025101516-skeletal-munchkin-0e85@gregkh>

Hello Greg,

On 10/15/2025 11:44 AM, Greg Kroah-Hartman wrote:
>> Greg, Sasha,
>>
>> This fix cleanly applies on top of v6.16.y and v6.17.y stable kernels
>> too when cherry-picked from v6.12.y branch (or with 'git am -3'). Let me
>> know if you would like me to send a seperate patch for each.
>>
>> As mentioned above, the upstream fixes this as a part of larger feature
>> and we would only like these bits backported. If there are any future
>> conflicts in this area during backporting, I would be more than happy to
>> help out resolve them.
> 
> Why not just backport all of the mainline changes instead?  As I say a
> lot, whenever we do these "one off" changes, it's almost always wrong
> and causes problems over the years going forward as other changes around
> the same area can not be backported either.
> 
> So please, try to just backport the original commits.

Peter was in favor of backporting just the necessary bits in
https://lore.kernel.org/all/20250929103836.GK3419281@noisy.programming.kicks-ass.net/

Backporting the whole of per-task throttle feature is lot more heavy
handed with the core changes adding:

 include/linux/sched.h |   5 +
 kernel/sched/core.c   |   3 +
 kernel/sched/fair.c   | 451 ++++++++++++++++++++++++------------------
 kernel/sched/pelt.h   |   4 +-
 kernel/sched/sched.h  |   7 +-
 5 files changed, 274 insertions(+), 196 deletions(-)

And a few more fixes that will add to the above before v6.18. I'll defer
to Peter to decide the best course of action.

-- 
Thanks and Regards,
Prateek


  reply	other threads:[~2025-10-15  6:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 13:33 [PATCH] Revert "sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks" Matt Fleming
2025-09-26  0:05 ` John Stultz
2025-09-26  0:06   ` John Stultz
2025-09-26  2:43   ` K Prateek Nayak
2025-09-26 15:34     ` Matt Fleming
2025-09-29  3:53       ` K Prateek Nayak
2025-10-14 10:15         ` Matt Fleming
2025-10-15  6:03       ` [PATCH v6.12] sched/fair: Block delayed tasks on throttled hierarchy during dequeue K Prateek Nayak
2025-10-15  6:14         ` Greg Kroah-Hartman
2025-10-15  6:27           ` K Prateek Nayak [this message]
2025-10-15  7:27             ` Greg Kroah-Hartman
2025-10-15  8:22               ` Peter Zijlstra
2025-10-23  4:03       ` [PATCH 6.17] " K Prateek Nayak
2025-09-29 10:38     ` [PATCH] Revert "sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks" Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe9320d4-9da0-4de8-8e1e-ec03ecf582a1@amd.com \
    --to=kprateek.nayak@amd.com \
    --cc=bsegall@google.com \
    --cc=carges@cloudflare.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@cloudflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@readmodwrite.com \
    --cc=mfleming@cloudflare.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.