All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: kernel test robot <lkp@intel.com>, Prathamesh Shete <pshete@nvidia.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 2/2] pinctrl: tegra: Add pinmux support for Tegra194
Date: Fri, 29 Apr 2022 08:20:13 +0200	[thread overview]
Message-ID: <0fffaa30-6e4c-177c-d757-e7e4608f4557@kernel.org> (raw)
In-Reply-To: <202111060119.T02XJFAA-lkp@intel.com>

On 05/11/2021 18:49, kernel test robot wrote:
> Hi Prathamesh,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on tegra/for-next]
> [also build test WARNING on v5.15]
> [cannot apply to linusw-pinctrl/devel next-20211105]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]

(...)

                        \
>                               ^~
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1113:27: warning: unused variable 'sdmmc1_hv_trim_pins' [-Wunused-const-variable]
>    static const unsigned int sdmmc1_hv_trim_pins[] = {
>                              ^
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1119:27: warning: unused variable 'sdmmc3_hv_trim_pins' [-Wunused-const-variable]
>    static const unsigned int sdmmc3_hv_trim_pins[] = {
>                              ^
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1128:27: warning: unused variable 'sys_reset_n_pins' [-Wunused-const-variable]
>    static const unsigned int sys_reset_n_pins[] = {
>                              ^

Hi Prathamesh,

I stumbled on issue with your commit and now I found that this was
already reported 4 times to you:
https://lore.kernel.org/all/?q=sys_reset_n_pins

Never fixed by the author.

Why these reports about errors in your commit where ignored? It's your
commit so leaving it as is in kernel is not responsible...

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] pinctrl: tegra: Add pinmux support for Tegra194
Date: Fri, 29 Apr 2022 08:20:13 +0200	[thread overview]
Message-ID: <0fffaa30-6e4c-177c-d757-e7e4608f4557@kernel.org> (raw)
In-Reply-To: <202111060119.T02XJFAA-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

On 05/11/2021 18:49, kernel test robot wrote:
> Hi Prathamesh,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on tegra/for-next]
> [also build test WARNING on v5.15]
> [cannot apply to linusw-pinctrl/devel next-20211105]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]

(...)

                        \
>                               ^~
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1113:27: warning: unused variable 'sdmmc1_hv_trim_pins' [-Wunused-const-variable]
>    static const unsigned int sdmmc1_hv_trim_pins[] = {
>                              ^
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1119:27: warning: unused variable 'sdmmc3_hv_trim_pins' [-Wunused-const-variable]
>    static const unsigned int sdmmc3_hv_trim_pins[] = {
>                              ^
>>> drivers/pinctrl/tegra/pinctrl-tegra194.c:1128:27: warning: unused variable 'sys_reset_n_pins' [-Wunused-const-variable]
>    static const unsigned int sys_reset_n_pins[] = {
>                              ^

Hi Prathamesh,

I stumbled on issue with your commit and now I found that this was
already reported 4 times to you:
https://lore.kernel.org/all/?q=sys_reset_n_pins

Never fixed by the author.

Why these reports about errors in your commit where ignored? It's your
commit so leaving it as is in kernel is not responsible...

Best regards,
Krzysztof

  reply	other threads:[~2022-04-29  6:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 12:18 [PATCH 1/2] pinctrl: tegra: include lpdr pin properties Prathamesh Shete
2021-10-18 12:18 ` [PATCH 2/2] pinctrl: tegra: Add pinmux support for Tegra194 Prathamesh Shete
2021-10-24 21:25   ` Linus Walleij
2021-11-05 17:49   ` kernel test robot
2021-11-05 17:49     ` kernel test robot
2022-04-29  6:20     ` Krzysztof Kozlowski [this message]
2022-04-29  6:20       ` Krzysztof Kozlowski
2021-10-19 23:00 ` [PATCH 1/2] pinctrl: tegra: include lpdr pin properties Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fffaa30-6e4c-177c-d757-e7e4608f4557@kernel.org \
    --to=krzk@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=pshete@nvidia.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.