[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Nobuhiro Iwamatsu]

Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
use, we will need to disable the GPIO key and remodeling of the board.
Therefore status of hscif1 does not set the "okay".

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 V2: Remove hscif1_clk from renesas,groups. This pin does not use.
 
 arch/arm/boot/dts/r8a7791-koelsch.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index b2e6616..0992673 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -22,6 +22,7 @@
 	aliases {
 		serial6 = &scif0;
 		serial7 = &scif1;
+		serial16 = &hscif1;
 	};
 
 	chosen {
@@ -258,6 +259,11 @@
 		renesas,function = "scif1";
 	};
 
+	hscif1_pins: serial2 {
+		renesas,groups = "hscif1_data", "hscif1_ctrl";
+		renesas,function = "hscif1";
+	};
+
 	ether_pins: ether {
 		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
 		renesas,function = "eth";
@@ -334,6 +340,11 @@
 	status = "okay";
 };
 
+&hscif1 {
+	pinctrl-0 = <&hscif1_pins>;
+	pinctrl-names = "default";
+};
+
 &sdhi0 {
 	pinctrl-0 = <&sdhi0_pins>;
 	pinctrl-names = "default";
-- 
2.0.0

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Nobuhiro Iwamatsu]

Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
use, we will need to disable the GPIO key and remodeling of the board.
Therefore status of hscif1 does not set the "okay".

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 V2: Remove hscif1_clk from renesas,groups. This pin does not use.
 
 arch/arm/boot/dts/r8a7791-koelsch.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index b2e6616..0992673 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -22,6 +22,7 @@
 	aliases {
 		serial6 = &scif0;
 		serial7 = &scif1;
+		serial16 = &hscif1;
 	};
 
 	chosen {
@@ -258,6 +259,11 @@
 		renesas,function = "scif1";
 	};
 
+	hscif1_pins: serial2 {
+		renesas,groups = "hscif1_data", "hscif1_ctrl";
+		renesas,function = "hscif1";
+	};
+
 	ether_pins: ether {
 		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
 		renesas,function = "eth";
@@ -334,6 +340,11 @@
 	status = "okay";
 };
 
+&hscif1 {
+	pinctrl-0 = <&hscif1_pins>;
+	pinctrl-names = "default";
+};
+
 &sdhi0 {
 	pinctrl-0 = <&sdhi0_pins>;
 	pinctrl-names = "default";
-- 
2.0.0

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Magnus Damm]

Hi Iwamatsu-san,

On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
> use, we will need to disable the GPIO key and remodeling of the board.
> Therefore status of hscif1 does not set the "okay".
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  V2: Remove hscif1_clk from renesas,groups. This pin does not use.

Thanks for updating the patch. This looks fine to me.

Acked-by: Magnus Damm <damm+renesas@opensource.se>

Cheers,

/ magnus

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Magnus Damm]

Hi Iwamatsu-san,

On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
> use, we will need to disable the GPIO key and remodeling of the board.
> Therefore status of hscif1 does not set the "okay".
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  V2: Remove hscif1_clk from renesas,groups. This pin does not use.

Thanks for updating the patch. This looks fine to me.

Acked-by: Magnus Damm <damm+renesas@opensource.se>

Cheers,

/ magnus

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> Hi Iwamatsu-san,
> 
> On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
> > use, we will need to disable the GPIO key and remodeling of the board.
> > Therefore status of hscif1 does not set the "okay".
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > ---
> >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> 
> Thanks for updating the patch. This looks fine to me.
> 
> Acked-by: Magnus Damm <damm+renesas@opensource.se>

Thanks, I will queue this up.

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> Hi Iwamatsu-san,
> 
> On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want to
> > use, we will need to disable the GPIO key and remodeling of the board.
> > Therefore status of hscif1 does not set the "okay".
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > ---
> >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> 
> Thanks for updating the patch. This looks fine to me.
> 
> Acked-by: Magnus Damm <damm+renesas@opensource.se>

Thanks, I will queue this up.

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Simon,

On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want
> > > to use, we will need to disable the GPIO key and remodeling of the
> > > board. Therefore status of hscif1 does not set the "okay".
> > > 
> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > ---
> > > 
> > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > 
> > Thanks for updating the patch. This looks fine to me.
> > 
> > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> 
> Thanks, I will queue this up.

Sorry for the late reply, but I have some doubts about this. The HRX0 and HTX0 
signals are connected to push buttons and used as GPIOs. Beside, they're not 
routed to serial port transceiver. If we want to use HSCIF0 on those pins on 
Koelsch and extension board must be connected to the EXIO C connector, and two 
resistors and two capacitors should be unsoldered. I thus don't think the 
Koeslch DT should contain pinmux data for the HSCIF0 device. If an extension 
board is used and HSCIF0 needed, then the DT file for the extension board 
should define pinmuxing for the serial port.

-- 
Regards,

Laurent Pinchart

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Simon,

On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want
> > > to use, we will need to disable the GPIO key and remodeling of the
> > > board. Therefore status of hscif1 does not set the "okay".
> > > 
> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > ---
> > > 
> > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > 
> > Thanks for updating the patch. This looks fine to me.
> > 
> > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> 
> Thanks, I will queue this up.

Sorry for the late reply, but I have some doubts about this. The HRX0 and HTX0 
signals are connected to push buttons and used as GPIOs. Beside, they're not 
routed to serial port transceiver. If we want to use HSCIF0 on those pins on 
Koelsch and extension board must be connected to the EXIO C connector, and two 
resistors and two capacitors should be unsoldered. I thus don't think the 
Koeslch DT should contain pinmux data for the HSCIF0 device. If an extension 
board is used and HSCIF0 needed, then the DT file for the extension board 
should define pinmuxing for the serial port.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want
> > > > to use, we will need to disable the GPIO key and remodeling of the
> > > > board. Therefore status of hscif1 does not set the "okay".
> > > > 
> > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > > ---
> > > > 
> > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > > 
> > > Thanks for updating the patch. This looks fine to me.
> > > 
> > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> > 
> > Thanks, I will queue this up.
> 
> Sorry for the late reply, but I have some doubts about this. The HRX0 and
> HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> they're not routed to serial port transceiver. If we want to use HSCIF0
> on those pins on Koelsch and extension board must be connected to the
> EXIO C connector, and two resistors and two capacitors should be
> unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> then the DT file for the extension board should define pinmuxing for the
> serial port.

If you would like me to revert this patch I am happy to consider doing so.

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we want
> > > > to use, we will need to disable the GPIO key and remodeling of the
> > > > board. Therefore status of hscif1 does not set the "okay".
> > > > 
> > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > > ---
> > > > 
> > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > > 
> > > Thanks for updating the patch. This looks fine to me.
> > > 
> > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> > 
> > Thanks, I will queue this up.
> 
> Sorry for the late reply, but I have some doubts about this. The HRX0 and
> HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> they're not routed to serial port transceiver. If we want to use HSCIF0
> on those pins on Koelsch and extension board must be connected to the
> EXIO C connector, and two resistors and two capacitors should be
> unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> then the DT file for the extension board should define pinmuxing for the
> serial port.

If you would like me to revert this patch I am happy to consider doing so.

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Simon,

On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
> > > > > want
> > > > > to use, we will need to disable the GPIO key and remodeling of the
> > > > > board. Therefore status of hscif1 does not set the "okay".
> > > > > 
> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > > > ---
> > > > > 
> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > > > 
> > > > Thanks for updating the patch. This looks fine to me.
> > > > 
> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> > > 
> > > Thanks, I will queue this up.
> > 
> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> > they're not routed to serial port transceiver. If we want to use HSCIF0
> > on those pins on Koelsch and extension board must be connected to the
> > EXIO C connector, and two resistors and two capacitors should be
> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> > then the DT file for the extension board should define pinmuxing for the
> > serial port.
> 
> If you would like me to revert this patch I am happy to consider doing so.

That's one option, but I'd like to get feedback on my point of view before 
reverting it. Who knows, I might be wrong ;-)

-- 
Regards,

Laurent Pinchart

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Simon,

On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
> > > > > want
> > > > > to use, we will need to disable the GPIO key and remodeling of the
> > > > > board. Therefore status of hscif1 does not set the "okay".
> > > > > 
> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > > > ---
> > > > > 
> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> > > > 
> > > > Thanks for updating the patch. This looks fine to me.
> > > > 
> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> > > 
> > > Thanks, I will queue this up.
> > 
> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> > they're not routed to serial port transceiver. If we want to use HSCIF0
> > on those pins on Koelsch and extension board must be connected to the
> > EXIO C connector, and two resistors and two capacitors should be
> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> > then the DT file for the extension board should define pinmuxing for the
> > serial port.
> 
> If you would like me to revert this patch I am happy to consider doing so.

That's one option, but I'd like to get feedback on my point of view before 
reverting it. Who knows, I might be wrong ;-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Geert Uytterhoeven]

On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Friday 13 June 2014 16:43:07 Simon Horman wrote:
>> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
>> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
>> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
>> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
>> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
>> > > > > want
>> > > > > to use, we will need to disable the GPIO key and remodeling of the
>> > > > > board. Therefore status of hscif1 does not set the "okay".
>> > > > >
>> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > > > > ---
>> > > > >
>> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
>> > > >
>> > > > Thanks for updating the patch. This looks fine to me.
>> > > >
>> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
>> > >
>> > > Thanks, I will queue this up.
>> >
>> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
>> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
>> > they're not routed to serial port transceiver. If we want to use HSCIF0
>> > on those pins on Koelsch and extension board must be connected to the
>> > EXIO C connector, and two resistors and two capacitors should be
>> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
>> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
>> > then the DT file for the extension board should define pinmuxing for the
>> > serial port.

You mean HRX1, HTX1, and HSCIF1?

HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
zero-Ohm resisters to R834 and R835.

About your comment about the resistors and capacitors, which applies to
both HSCIF0 and HSCIF1: probably the serial port will still work if
these are present.

>> If you would like me to revert this patch I am happy to consider doing so.
>
> That's one option, but I'd like to get feedback on my point of view before
> reverting it. Who knows, I might be wrong ;-)

Nevertheless, I agree with Laurent.

HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
should not be present in the plain Koelsch DTS.  They should be put in
an overlay
DTS instead.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Geert Uytterhoeven]

On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Friday 13 June 2014 16:43:07 Simon Horman wrote:
>> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
>> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
>> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
>> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
>> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
>> > > > > want
>> > > > > to use, we will need to disable the GPIO key and remodeling of the
>> > > > > board. Therefore status of hscif1 does not set the "okay".
>> > > > >
>> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > > > > ---
>> > > > >
>> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
>> > > >
>> > > > Thanks for updating the patch. This looks fine to me.
>> > > >
>> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
>> > >
>> > > Thanks, I will queue this up.
>> >
>> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
>> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
>> > they're not routed to serial port transceiver. If we want to use HSCIF0
>> > on those pins on Koelsch and extension board must be connected to the
>> > EXIO C connector, and two resistors and two capacitors should be
>> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
>> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
>> > then the DT file for the extension board should define pinmuxing for the
>> > serial port.

You mean HRX1, HTX1, and HSCIF1?

HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
zero-Ohm resisters to R834 and R835.

About your comment about the resistors and capacitors, which applies to
both HSCIF0 and HSCIF1: probably the serial port will still work if
these are present.

>> If you would like me to revert this patch I am happy to consider doing so.
>
> That's one option, but I'd like to get feedback on my point of view before
> reverting it. Who knows, I might be wrong ;-)

Nevertheless, I agree with Laurent.

HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
should not be present in the plain Koelsch DTS.  They should be put in
an overlay
DTS instead.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Geert,

On Friday 13 June 2014 13:16:34 Geert Uytterhoeven wrote:
> On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart wrote:
> > On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> >> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> >> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> >> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> >> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> >> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if
> >> > > > > we want to use, we will need to disable the GPIO key and
> >> > > > > remodeling of the board. Therefore status of hscif1 does not set
> >> > > > > the "okay".
> >> > > > > 
> >> > > > > Signed-off-by: Nobuhiro Iwamatsu
> >> > > > > <nobuhiro.iwamatsu.yj@renesas.com>
> >> > > > > ---
> >> > > > > 
> >> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not
> >> > > > >  use.
> >> > > > 
> >> > > > Thanks for updating the patch. This looks fine to me.
> >> > > > 
> >> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> >> > > 
> >> > > Thanks, I will queue this up.
> >> > 
> >> > Sorry for the late reply, but I have some doubts about this. The HRX0
> >> > and HTX0 signals are connected to push buttons and used as GPIOs.
> >> > Beside, they're not routed to serial port transceiver. If we want to
> >> > use HSCIF0 on those pins on Koelsch and extension board must be
> >> > connected to the EXIO C connector, and two resistors and two capacitors
> >> > should be unsoldered. I thus don't think the Koeslch DT should contain
> >> > pinmux data for the HSCIF0 device. If an extension board is used and
> >> > HSCIF0 needed, then the DT file for the extension board should define
> >> > pinmuxing for the serial port.
> 
> You mean HRX1, HTX1, and HSCIF1?

*sigh*... :-)

> HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
> zero-Ohm resisters to R834 and R835.
> 
> About your comment about the resistors and capacitors, which applies to
> both HSCIF0 and HSCIF1: probably the serial port will still work if
> these are present.

With a 4.7µF capacitive load on the transmission line, assuming a drive 
strength of 40mA (which is pretty high), switching between 0V and 3.3V takes 
388µs, corresponding to 2579 Hz. You'll have to reduce the baud rate :-)

> >> If you would like me to revert this patch I am happy to consider doing
> >> so.
> > 
> > That's one option, but I'd like to get feedback on my point of view before
> > reverting it. Who knows, I might be wrong ;-)
> 
> Nevertheless, I agree with Laurent.
> 
> HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
> should not be present in the plain Koelsch DTS.  They should be put in
> an overlay DTS instead.

-- 
Regards,

Laurent Pinchart

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Laurent Pinchart]

Hi Geert,

On Friday 13 June 2014 13:16:34 Geert Uytterhoeven wrote:
> On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart wrote:
> > On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> >> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> >> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> >> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> >> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> >> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if
> >> > > > > we want to use, we will need to disable the GPIO key and
> >> > > > > remodeling of the board. Therefore status of hscif1 does not set
> >> > > > > the "okay".
> >> > > > > 
> >> > > > > Signed-off-by: Nobuhiro Iwamatsu
> >> > > > > <nobuhiro.iwamatsu.yj@renesas.com>
> >> > > > > ---
> >> > > > > 
> >> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not
> >> > > > >  use.
> >> > > > 
> >> > > > Thanks for updating the patch. This looks fine to me.
> >> > > > 
> >> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> >> > > 
> >> > > Thanks, I will queue this up.
> >> > 
> >> > Sorry for the late reply, but I have some doubts about this. The HRX0
> >> > and HTX0 signals are connected to push buttons and used as GPIOs.
> >> > Beside, they're not routed to serial port transceiver. If we want to
> >> > use HSCIF0 on those pins on Koelsch and extension board must be
> >> > connected to the EXIO C connector, and two resistors and two capacitors
> >> > should be unsoldered. I thus don't think the Koeslch DT should contain
> >> > pinmux data for the HSCIF0 device. If an extension board is used and
> >> > HSCIF0 needed, then the DT file for the extension board should define
> >> > pinmuxing for the serial port.
> 
> You mean HRX1, HTX1, and HSCIF1?

*sigh*... :-)

> HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
> zero-Ohm resisters to R834 and R835.
> 
> About your comment about the resistors and capacitors, which applies to
> both HSCIF0 and HSCIF1: probably the serial port will still work if
> these are present.

With a 4.7?F capacitive load on the transmission line, assuming a drive 
strength of 40mA (which is pretty high), switching between 0V and 3.3V takes 
388?s, corresponding to 2579 Hz. You'll have to reduce the baud rate :-)

> >> If you would like me to revert this patch I am happy to consider doing
> >> so.
> > 
> > That's one option, but I'd like to get feedback on my point of view before
> > reverting it. Who knows, I might be wrong ;-)
> 
> Nevertheless, I agree with Laurent.
> 
> HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
> should not be present in the plain Koelsch DTS.  They should be put in
> an overlay DTS instead.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Geert Uytterhoeven]

Hi Laurent,

On Fri, Jun 13, 2014 at 3:24 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>> About your comment about the resistors and capacitors, which applies to
>> both HSCIF0 and HSCIF1: probably the serial port will still work if
>> these are present.
>
> With a 4.7µF capacitive load on the transmission line, assuming a drive
> strength of 40mA (which is pretty high), switching between 0V and 3.3V takes
> 388µs, corresponding to 2579 Hz. You'll have to reduce the baud rate :-)

Right, 4.7µF is a bit high. So at least the capacitor has to go for today's
typical serial speeds.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Geert Uytterhoeven]

Hi Laurent,

On Fri, Jun 13, 2014 at 3:24 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>> About your comment about the resistors and capacitors, which applies to
>> both HSCIF0 and HSCIF1: probably the serial port will still work if
>> these are present.
>
> With a 4.7?F capacitive load on the transmission line, assuming a drive
> strength of 40mA (which is pretty high), switching between 0V and 3.3V takes
> 388?s, corresponding to 2579 Hz. You'll have to reduce the baud rate :-)

Right, 4.7?F is a bit high. So at least the capacitor has to go for today's
typical serial speeds.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Fri, Jun 13, 2014 at 01:16:34PM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> >> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> >> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> >> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> >> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> >> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
> >> > > > > want
> >> > > > > to use, we will need to disable the GPIO key and remodeling of the
> >> > > > > board. Therefore status of hscif1 does not set the "okay".
> >> > > > >
> >> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >> > > > > ---
> >> > > > >
> >> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> >> > > >
> >> > > > Thanks for updating the patch. This looks fine to me.
> >> > > >
> >> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> >> > >
> >> > > Thanks, I will queue this up.
> >> >
> >> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
> >> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> >> > they're not routed to serial port transceiver. If we want to use HSCIF0
> >> > on those pins on Koelsch and extension board must be connected to the
> >> > EXIO C connector, and two resistors and two capacitors should be
> >> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> >> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> >> > then the DT file for the extension board should define pinmuxing for the
> >> > serial port.
> 
> You mean HRX1, HTX1, and HSCIF1?
> 
> HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
> zero-Ohm resisters to R834 and R835.
> 
> About your comment about the resistors and capacitors, which applies to
> both HSCIF0 and HSCIF1: probably the serial port will still work if
> these are present.
> 
> >> If you would like me to revert this patch I am happy to consider doing so.
> >
> > That's one option, but I'd like to get feedback on my point of view before
> > reverting it. Who knows, I might be wrong ;-)
> 
> Nevertheless, I agree with Laurent.
> 
> HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
> should not be present in the plain Koelsch DTS.  They should be put in
> an overlay
> DTS instead.

Thanks, I have reverted this patch and will probably subsequently
drop it and the revert when I rebase my branches on top of v3.16-rc1
(due to ARM-SoC process requirements).

Lets revisit this if necessary.

[PATCH v2] ARM: shmobile: koelsch: Add support HSCIF1

[Simon Horman]

On Fri, Jun 13, 2014 at 01:16:34PM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 13, 2014 at 12:49 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Friday 13 June 2014 16:43:07 Simon Horman wrote:
> >> On Fri, Jun 13, 2014 at 09:01:27AM +0200, Laurent Pinchart wrote:
> >> > On Tuesday 10 June 2014 16:00:48 Simon Horman wrote:
> >> > > On Tue, Jun 10, 2014 at 01:14:27PM +0900, Magnus Damm wrote:
> >> > > > On Tue, Jun 10, 2014 at 11:34 AM, Nobuhiro Iwamatsu wrote:
> >> > > > > Koelsch can use HSCIF1 insetead of SCIF1 as serial port. But if we
> >> > > > > want
> >> > > > > to use, we will need to disable the GPIO key and remodeling of the
> >> > > > > board. Therefore status of hscif1 does not set the "okay".
> >> > > > >
> >> > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >> > > > > ---
> >> > > > >
> >> > > > >  V2: Remove hscif1_clk from renesas,groups. This pin does not use.
> >> > > >
> >> > > > Thanks for updating the patch. This looks fine to me.
> >> > > >
> >> > > > Acked-by: Magnus Damm <damm+renesas@opensource.se>
> >> > >
> >> > > Thanks, I will queue this up.
> >> >
> >> > Sorry for the late reply, but I have some doubts about this. The HRX0 and
> >> > HTX0 signals are connected to push buttons and used as GPIOs. Beside,
> >> > they're not routed to serial port transceiver. If we want to use HSCIF0
> >> > on those pins on Koelsch and extension board must be connected to the
> >> > EXIO C connector, and two resistors and two capacitors should be
> >> > unsoldered. I thus don't think the Koeslch DT should contain pinmux data
> >> > for the HSCIF0 device. If an extension board is used and HSCIF0 needed,
> >> > then the DT file for the extension board should define pinmuxing for the
> >> > serial port.
> 
> You mean HRX1, HTX1, and HSCIF1?
> 
> HTX1 and HRX1 can be connected to the DEBUG1 transceiver by stuffing
> zero-Ohm resisters to R834 and R835.
> 
> About your comment about the resistors and capacitors, which applies to
> both HSCIF0 and HSCIF1: probably the serial port will still work if
> these are present.
> 
> >> If you would like me to revert this patch I am happy to consider doing so.
> >
> > That's one option, but I'd like to get feedback on my point of view before
> > reverting it. Who knows, I might be wrong ;-)
> 
> Nevertheless, I agree with Laurent.
> 
> HSCIF1 (and HSCIF0) cannot be used on the Koelsch board as-is, hence they
> should not be present in the plain Koelsch DTS.  They should be put in
> an overlay
> DTS instead.

Thanks, I have reverted this patch and will probably subsequently
drop it and the revert when I rebase my branches on top of v3.16-rc1
(due to ARM-SoC process requirements).

Lets revisit this if necessary.