All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: george anzinger <george@mvista.com>, linux-kernel@vger.kernel.org
Cc: Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [PATCH] improve spinlock debugging
Date: 04 Dec 2001 15:51:41 -0500	[thread overview]
Message-ID: <1007499102.1303.24.camel@phantasy> (raw)
In-Reply-To: <3C0D3283.4DA4DD2B@mvista.com>
In-Reply-To: <3C0BDC33.6E18C815@colorfullife.com>  <3C0D3283.4DA4DD2B@mvista.com>

On Tue, 2001-12-04 at 15:30, george anzinger wrote:

> spin_lockirq
> 
> spin_unlock
> 
> restore_irq

Given this order, couldn't we _always_ not touch the preempt count since
irq's are off?

Further, since I doubt we ever see:

	spin_lock_irq
	restore_irq
	spin_unlock

and the common use is:

	spin_lock_irq
	spin_unlock_irq

Isn't it safe to have spin_lock_irq *never* touch the preempt count?

	Robert Love


  reply	other threads:[~2001-12-04 20:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-03 20:10 [PATCH] improve spinlock debugging Manfred Spraul
2001-12-04  4:21 ` David S. Miller
2001-12-04  4:30   ` Robert Love
2001-12-04 20:30 ` george anzinger
2001-12-04 20:51   ` Robert Love [this message]
2001-12-04 21:25     ` george anzinger
2001-12-04 21:39       ` Robert Love
2001-12-04 22:06     ` Nigel Gamble
2001-12-04 22:23       ` Robert Love
2001-12-05  1:13         ` Roman Zippel
2001-12-05  7:41           ` george anzinger
2001-12-04 20:53   ` Manfred Spraul
2001-12-05  0:54     ` george anzinger
2001-12-04 21:20   ` Nigel Gamble
2001-12-04 21:27     ` george anzinger
2001-12-05  8:47 ` Giuliano Pochini
2001-12-05 15:42   ` Manfred Spraul
     [not found] ` <20011219025332.GA18344@krispykreme>
2001-12-20 17:08   ` Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1007499102.1303.24.camel@phantasy \
    --to=rml@tech9.net \
    --cc=george@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.