Potential Problems in glibc-package.bbclass

* Potential Problems in glibc-package.bbclass
@ 2007-02-28 16:25 Hans Henry von Tresckow
  2007-03-08 14:32 ` Jan Janssens
  2007-03-08 14:39 ` Koen Kooi
  0 siblings, 2 replies; 6+ messages in thread
From: Hans Henry von Tresckow @ 2007-02-28 16:25 UTC (permalink / raw)
  To: openembedded-devel

I think I may have stumbled across some potential bugs in glibc-package.bbclass:

it seems like the standard value for datadir is /usr/share which will
cause the following problems in output_locale_binary:

1) i18npath will be set to /usr/share/i18n instead of
treedir/usr/share/i18n becouse path.join is too braindead to remove
leading / on path entries.
2) the --inputfile option in localdef opts uses datadir instead of
treedir, so it looks like it would use the locale files installed on
the host instead of the ones we are buildig for.

Am I missing something here or should I file this as a bug?

-------------source starts here------------------------------------
def output_locale_binary(name, locale, encoding):
		target_arch = bb.data.getVar("TARGET_ARCH", d, 1)
		qemu = "qemu-%s -r 2.6.16" % target_arch
		pkgname = 'locale-base-' + legitimize_package_name(name)
		m = re.match("(.*)\.(.*)", name)
		if m:
			glibc_name = "%s.%s" % (m.group(1), m.group(2).lower().replace("-",""))
		else:
			glibc_name = name
		bb.data.setVar('RDEPENDS_%s' % pkgname,
legitimize_package_name('glibc-binary-localedata-%s' % glibc_name), d)
		rprovides = 'virtual-locale-%s' % legitimize_package_name(name)
		m = re.match("(.*)_(.*)", name)
		if m:
			rprovides += ' virtual-locale-%s' % m.group(1)
		bb.data.setVar('RPROVIDES_%s' % pkgname, rprovides, d)
		bb.data.setVar('ALLOW_EMPTY_%s' % pkgname, '1', d)
		bb.data.setVar('PACKAGES', '%s %s' % (pkgname,
bb.data.getVar('PACKAGES', d, 1)), d)

		treedir = os.path.join(bb.data.getVar("WORKDIR", d, 1), "locale-tree")
		path = bb.data.getVar("PATH", d, 1)
		i18npath = os.path.join(treedir, datadir, "i18n")

		localedef_opts = "--force --old-style --no-archive --prefix=%s
--inputfile=%s/i18n/locales/%s --charmap=%s %s" % (treedir, datadir,
locale, encoding, name)
		cmd = "PATH=\"%s\" I18NPATH=\"%s\" %s -L %s %s/bin/localedef %s" %
(path, i18npath, qemu, treedir, treedir, localedef_opts)
		bb.note("generating locale %s (%s)" % (locale, encoding))
		if os.system(cmd):
			raise bb.build.FuncFailed("localedef returned an error (command was
%s)." % cmd)

^ permalink raw reply	[flat|nested] 6+ messages in thread