From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/14] ARM: shmobile: Rename to emev2_init_early(), use smp_set_ops()
Date: Fri, 09 Aug 2013 10:41:30 +0000 [thread overview]
Message-ID: <10195347.M6JWNyZrex@avalon> (raw)
In-Reply-To: <20130809094936.6530.31840.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Friday 09 August 2013 18:49:36 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Rename emev2_init_delay() into emev2_init_early()
> to make the function name show that more than just
> delay setup will happen.
>
> Also, instead of specifying the smp ops in DT_MACHINE
> convert the EMEV2 SoC code to install the smp ops
> from emev2_init_early().
Could you please explain in the commit message why this is needed ? Same
comment for the other patches in this series.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/mach-shmobile/board-kzm9d-reference.c | 3 +--
> arch/arm/mach-shmobile/board-kzm9d.c | 3 +--
> arch/arm/mach-shmobile/include/mach/emev2.h | 2 +-
> arch/arm/mach-shmobile/setup-emev2.c | 8 +++++---
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/board-kzm9d-reference.c
> +++ work/arch/arm/mach-shmobile/board-kzm9d-reference.c 2013-08-08
> 16:18:34.000000000 +0900 @@ -38,9 +38,8 @@ static const char
> *kzm9d_boards_compat_d
> };
>
> DT_MACHINE_START(KZM9D_DT, "kzm9d")
> - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .init_machine = kzm9d_add_standard_devices,
> .init_late = shmobile_init_late,
> .dt_compat = kzm9d_boards_compat_dt,
> --- 0001/arch/arm/mach-shmobile/board-kzm9d.c
> +++ work/arch/arm/mach-shmobile/board-kzm9d.c 2013-08-08
16:18:17.000000000
> +0900 @@ -83,9 +83,8 @@ static const char *kzm9d_boards_compat_d
> };
>
> DT_MACHINE_START(KZM9D_DT, "kzm9d")
> - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .init_machine = kzm9d_add_standard_devices,
> .init_late = shmobile_init_late,
> .dt_compat = kzm9d_boards_compat_dt,
> --- 0001/arch/arm/mach-shmobile/include/mach/emev2.h
> +++ work/arch/arm/mach-shmobile/include/mach/emev2.h 2013-08-08
> 16:17:57.000000000 +0900 @@ -2,7 +2,7 @@
> #define __ASM_EMEV2_H__
>
> extern void emev2_map_io(void);
> -extern void emev2_init_delay(void);
> +extern void emev2_init_early(void);
> extern void emev2_add_standard_devices(void);
> extern void emev2_clock_init(void);
>
> --- 0001/arch/arm/mach-shmobile/setup-emev2.c
> +++ work/arch/arm/mach-shmobile/setup-emev2.c 2013-08-08
16:17:47.000000000
> +0900 @@ -190,9 +190,12 @@ void __init emev2_add_standard_devices(v
> emev2_register_pmu();
> }
>
> -void __init emev2_init_delay(void)
> +void __init emev2_init_early(void)
> {
> shmobile_setup_delay(533, 1, 3); /* Cortex-A9 @ 533MHz */
> +#ifdef CONFIG_SMP
> + smp_set_ops(&emev2_smp_ops);
> +#endif
> }
>
> #ifdef CONFIG_USE_OF
> @@ -203,9 +206,8 @@ static const char *emev2_boards_compat_d
> };
>
> DT_MACHINE_START(EMEV2_DT, "Generic Emma Mobile EV2 (Flattened Device
> Tree)") - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .dt_compat = emev2_boards_compat_dt,
> MACHINE_END
>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/14] ARM: shmobile: Rename to emev2_init_early(), use smp_set_ops()
Date: Fri, 09 Aug 2013 12:41:30 +0200 [thread overview]
Message-ID: <10195347.M6JWNyZrex@avalon> (raw)
In-Reply-To: <20130809094936.6530.31840.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Friday 09 August 2013 18:49:36 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Rename emev2_init_delay() into emev2_init_early()
> to make the function name show that more than just
> delay setup will happen.
>
> Also, instead of specifying the smp ops in DT_MACHINE
> convert the EMEV2 SoC code to install the smp ops
> from emev2_init_early().
Could you please explain in the commit message why this is needed ? Same
comment for the other patches in this series.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/mach-shmobile/board-kzm9d-reference.c | 3 +--
> arch/arm/mach-shmobile/board-kzm9d.c | 3 +--
> arch/arm/mach-shmobile/include/mach/emev2.h | 2 +-
> arch/arm/mach-shmobile/setup-emev2.c | 8 +++++---
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/board-kzm9d-reference.c
> +++ work/arch/arm/mach-shmobile/board-kzm9d-reference.c 2013-08-08
> 16:18:34.000000000 +0900 @@ -38,9 +38,8 @@ static const char
> *kzm9d_boards_compat_d
> };
>
> DT_MACHINE_START(KZM9D_DT, "kzm9d")
> - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .init_machine = kzm9d_add_standard_devices,
> .init_late = shmobile_init_late,
> .dt_compat = kzm9d_boards_compat_dt,
> --- 0001/arch/arm/mach-shmobile/board-kzm9d.c
> +++ work/arch/arm/mach-shmobile/board-kzm9d.c 2013-08-08
16:18:17.000000000
> +0900 @@ -83,9 +83,8 @@ static const char *kzm9d_boards_compat_d
> };
>
> DT_MACHINE_START(KZM9D_DT, "kzm9d")
> - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .init_machine = kzm9d_add_standard_devices,
> .init_late = shmobile_init_late,
> .dt_compat = kzm9d_boards_compat_dt,
> --- 0001/arch/arm/mach-shmobile/include/mach/emev2.h
> +++ work/arch/arm/mach-shmobile/include/mach/emev2.h 2013-08-08
> 16:17:57.000000000 +0900 @@ -2,7 +2,7 @@
> #define __ASM_EMEV2_H__
>
> extern void emev2_map_io(void);
> -extern void emev2_init_delay(void);
> +extern void emev2_init_early(void);
> extern void emev2_add_standard_devices(void);
> extern void emev2_clock_init(void);
>
> --- 0001/arch/arm/mach-shmobile/setup-emev2.c
> +++ work/arch/arm/mach-shmobile/setup-emev2.c 2013-08-08
16:17:47.000000000
> +0900 @@ -190,9 +190,12 @@ void __init emev2_add_standard_devices(v
> emev2_register_pmu();
> }
>
> -void __init emev2_init_delay(void)
> +void __init emev2_init_early(void)
> {
> shmobile_setup_delay(533, 1, 3); /* Cortex-A9 @ 533MHz */
> +#ifdef CONFIG_SMP
> + smp_set_ops(&emev2_smp_ops);
> +#endif
> }
>
> #ifdef CONFIG_USE_OF
> @@ -203,9 +206,8 @@ static const char *emev2_boards_compat_d
> };
>
> DT_MACHINE_START(EMEV2_DT, "Generic Emma Mobile EV2 (Flattened Device
> Tree)") - .smp = smp_ops(emev2_smp_ops),
> .map_io = emev2_map_io,
> - .init_early = emev2_init_delay,
> + .init_early = emev2_init_early,
> .dt_compat = emev2_boards_compat_dt,
> MACHINE_END
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-08-09 10:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:47 [PATCH 00/14] ARM: shmobile: Cleanups and machine descriptor rework Magnus Damm
2013-08-09 9:47 ` Magnus Damm
2013-08-09 9:47 ` [PATCH 01/14] ARM: shmobile: r8a7779: Remove ->init_machine() special case Magnus Damm
2013-08-09 9:47 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 02/14] ARM: shmobile: r8a7740: " Magnus Damm
2013-08-09 9:48 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 03/14] ARM: shmobile: sh7372: " Magnus Damm
2013-08-09 9:48 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 04/14] ARM: shmobile: sh73a0: " Magnus Damm
2013-08-09 9:48 ` Magnus Damm
2013-08-09 10:47 ` Laurent Pinchart
2013-08-09 10:47 ` Laurent Pinchart
2013-08-28 6:40 ` Magnus Damm
2013-08-28 6:40 ` Magnus Damm
2013-08-28 12:08 ` Laurent Pinchart
2013-08-28 12:08 ` Laurent Pinchart
2013-08-28 12:19 ` Magnus Damm
2013-08-28 12:19 ` Magnus Damm
2013-08-30 0:30 ` Laurent Pinchart
2013-08-30 0:30 ` Laurent Pinchart
2013-08-30 6:58 ` Magnus Damm
2013-08-30 6:58 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 05/14] ARM: shmobile: Remove r8a7740_add_early_devices_dt() Magnus Damm
2013-08-09 9:48 ` Magnus Damm
2013-08-09 9:48 ` [PATCH 06/14] ARM: shmobile: Remove sh73a0_init_irq_dt() Magnus Damm
2013-08-09 9:48 ` Magnus Damm
2013-08-09 9:49 ` [PATCH 07/14] ARM: shmobile: Remove r8a7779 ->nr_irqs Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 9:49 ` [PATCH 08/14] ARM: shmobile: Remove sh73a0 ->nr_irqs Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 9:49 ` [PATCH 09/14] ARM: shmobile: Rename to sh7372_init_early() Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 10:40 ` Laurent Pinchart
2013-08-09 10:40 ` Laurent Pinchart
2013-08-09 9:49 ` [PATCH 10/14] ARM: shmobile: Rename to emev2_init_early(), use smp_set_ops() Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 10:41 ` Laurent Pinchart [this message]
2013-08-09 10:41 ` Laurent Pinchart
2013-08-28 7:03 ` Magnus Damm
2013-08-28 7:03 ` Magnus Damm
2013-08-28 7:53 ` Laurent Pinchart
2013-08-28 7:53 ` Laurent Pinchart
2013-08-09 9:49 ` [PATCH 11/14] ARM: shmobile: Rename to r8a7779_init_early(), " Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 9:49 ` [PATCH 12/14] ARM: shmobile: Rename to r8a7740_init_early() Magnus Damm
2013-08-09 9:49 ` Magnus Damm
2013-08-09 9:50 ` [PATCH 13/14] ARM: shmobile: Rename to r8a7778_init_early() Magnus Damm
2013-08-09 9:50 ` Magnus Damm
2013-08-09 9:50 ` [PATCH 14/14] ARM: shmobile: Rename to sh73a0_init_early(), use smp_set_ops() Magnus Damm
2013-08-09 9:50 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10195347.M6JWNyZrex@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.