From: Bob Peterson <rpeterso@redhat.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: dev@openvswitch.org, linux-s390@vger.kernel.org,
linux-media@vger.kernel.org, linux-scsi@vger.kernel.org,
dccp@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
cluster-devel@redhat.com, amd-gfx@lists.freedesktop.org,
Namhyung Kim <namhyung@kernel.org>,
linux-ext4@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
linux-arm-kernel@lists.infradead.org,
esc storagedev <esc.storagedev@microsemi.com>
Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 2 Jan 2018 08:56:27 -0500 (EST) [thread overview]
Message-ID: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com>
----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
|
| Hi Julia,
|
| NACK.
|
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
|
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 2 Jan 2018 08:56:27 -0500 (EST) [thread overview]
Message-ID: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com>
----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
|
| Hi Julia,
|
| NACK.
|
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
|
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 02 Jan 2018 13:56:27 +0000 [thread overview]
Message-ID: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com>
----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
|
| Hi Julia,
|
| NACK.
|
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
|
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: dev@openvswitch.org, linux-s390@vger.kernel.org,
linux-media@vger.kernel.org, linux-scsi@vger.kernel.org,
dccp@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
cluster-devel@redhat.com, amd-gfx@lists.freedesktop.org,
Namhyung Kim <namhyung@kernel.org>,
linux-ext4@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
linux-arm-kernel@lists.infradead.org,
esc storagedev <esc.storagedev@microsemi.com>
Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 02 Jan 2018 13:56:27 +0000 [thread overview]
Message-ID: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com>
----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
|
| Hi Julia,
|
| NACK.
|
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
|
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
WARNING: multiple messages have this Message-ID (diff)
From: rpeterso@redhat.com (Bob Peterson)
To: linux-arm-kernel@lists.infradead.org
Subject: [Cluster-devel] [PATCH 00/12] drop unneeded newline
Date: Tue, 2 Jan 2018 08:56:27 -0500 (EST) [thread overview]
Message-ID: <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com>
----- Original Message -----
| ----- Original Message -----
| | Drop newline at the end of a message string when the printing function adds
| | a newline.
|
| Hi Julia,
|
| NACK.
|
| As much as it's a pain when searching the source code for output strings,
| this patch set goes against the accepted Linux coding style document. See:
|
| https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages,
and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
next prev parent reply other threads:[~2018-01-02 13:56 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 14:51 [PATCH 00/12] drop unneeded newline Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [Cluster-devel] " Julia Lawall
2017-12-27 14:51 ` [PATCH 01/12] dac960: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [Cluster-devel] [PATCH 02/12] dlm: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [PATCH 04/12] ext2: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-28 4:30 ` Theodore Ts'o
2017-12-28 4:30 ` Theodore Ts'o
2018-01-02 13:42 ` Jan Kara
2018-01-02 13:42 ` Jan Kara
2017-12-27 14:51 ` [PATCH 05/12] openvswitch: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2018-01-02 18:50 ` David Miller
2018-01-02 18:50 ` David Miller
2017-12-27 14:51 ` [PATCH 06/12] [S390] dasd: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [PATCH 07/12] ARM: davinci: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2018-01-05 13:56 ` Sekhar Nori
2018-01-05 13:57 ` Sekhar Nori
2018-01-05 13:56 ` Sekhar Nori
2017-12-27 14:51 ` [PATCH 08/12] perf test: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [PATCH 09/12] [media] pvrusb2: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` [PATCH 10/12] hpsa: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2018-01-04 4:29 ` Martin K. Petersen
2018-01-04 4:29 ` Martin K. Petersen
2017-12-27 14:51 ` [PATCH 11/12] drm/amd/powerplay: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
[not found] ` <1514386305-7402-12-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2017-12-27 15:40 ` Michel Dänzer
2017-12-27 15:40 ` Michel Dänzer
2017-12-27 15:40 ` Michel Dänzer
2017-12-27 20:11 ` Julia Lawall
2017-12-27 20:11 ` Julia Lawall
2017-12-27 20:11 ` Julia Lawall
2018-01-01 21:07 ` Alex Deucher
2018-01-01 21:07 ` Alex Deucher
2018-01-01 21:07 ` Alex Deucher
2017-12-27 14:51 ` [PATCH 12/12] hpfs: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2018-01-01 20:23 ` Mikulas Patocka
2018-01-01 20:23 ` Mikulas Patocka
2018-01-02 13:52 ` [Cluster-devel] [PATCH 00/12] " Bob Peterson
2018-01-02 13:52 ` Bob Peterson
2018-01-02 13:52 ` Bob Peterson
2018-01-02 13:52 ` Bob Peterson
2018-01-02 13:52 ` Bob Peterson
2018-01-02 13:52 ` Bob Peterson
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:56 ` Bob Peterson [this message]
2018-01-02 13:56 ` Bob Peterson
2018-01-02 13:56 ` Bob Peterson
2018-01-02 13:56 ` Bob Peterson
2018-01-02 13:56 ` Bob Peterson
[not found] ` <1019862289.2632779.1514901387442.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-02 14:00 ` Julia Lawall
2018-01-02 14:00 ` Julia Lawall
2018-01-02 14:00 ` Julia Lawall
2018-01-02 14:00 ` Julia Lawall
2018-01-02 14:00 ` Julia Lawall
2018-01-02 14:00 ` Julia Lawall
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:16 ` Julia Lawall
2018-01-02 15:16 ` Julia Lawall
2018-01-02 15:16 ` Julia Lawall
2018-01-02 15:16 ` Julia Lawall
2018-01-02 15:16 ` Julia Lawall
2018-01-02 15:16 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2017-12-27 14:51 [PATCH 03/12] net: dccp: " Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2017-12-27 14:51 ` Julia Lawall
2018-01-02 18:50 David Miller
2018-01-02 18:50 ` David Miller
2018-01-02 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cluster-devel@redhat.com \
--cc=dccp@vger.kernel.org \
--cc=dev@openvswitch.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=esc.storagedev@microsemi.com \
--cc=jolsa@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.