[meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Przemyslaw Zegan]

Due to the incorrect subpackage name, the ftdi_eeprom does not placed in the generated image. This patch fixes it.

Signed-off-by: Przemyslaw Zegan <przemyslaw.zegan@gmail.com>
---
 meta-oe/recipes-support/libftdi/libftdi_1.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libftdi/libftdi_1.5.bb b/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
index eae1c02f0..ed989a311 100644
--- a/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
+++ b/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
@@ -36,5 +36,5 @@ BBCLASSEXTEND = "native nativesdk"
 
 PACKAGES =+ "${PN}-python ftdi-eeprom"
 
-FILES:ftdi-eeprom = "${bindir}/ftdi_eeprom"
+FILES:${PN}-ftdi-eeprom = "${bindir}/ftdi_eeprom"
 FILES:${PN}-python = "${PYTHON_SITEPACKAGES_DIR}/"
-- 
2.34.1

Re: [oe] [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

Przemyslaw Zegan via lists.openembedded.org <przemyslaw.zegan=
gmail.com@lists.openembedded.org> escreveu (segunda, 29/07/2024 à(s) 19:25):

> Due to the incorrect subpackage name, the ftdi_eeprom does not placed in
> the generated image. This patch fixes it.
>

What is the package name you are using to install the ftdi_eeprom on the
image?
Should be the 'ftdi-eeprom' package


>
> Signed-off-by: Przemyslaw Zegan <przemyslaw.zegan@gmail.com>
> ---
>  meta-oe/recipes-support/libftdi/libftdi_1.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
> b/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
> index eae1c02f0..ed989a311 100644
> --- a/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
> +++ b/meta-oe/recipes-support/libftdi/libftdi_1.5.bb
> @@ -36,5 +36,5 @@ BBCLASSEXTEND = "native nativesdk"
>
>  PACKAGES =+ "${PN}-python ftdi-eeprom"
>

Above the packages provided by this recipe are 'libftdi', 'libftdi--python'
and 'ftdi-eeprom'.


>
> -FILES:ftdi-eeprom = "${bindir}/ftdi_eeprom"
> +FILES:${PN}-ftdi-eeprom = "${bindir}/ftdi_eeprom"
>

This package 'libftdi-ftdi-eeprom' doesn't exist and with this patch you
are making it install the ftdi_eeprom
on the default 'libftdi' package.

Jose

 FILES:${PN}-python = "${PYTHON_SITEPACKAGES_DIR}/"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111474):
> https://lists.openembedded.org/g/openembedded-devel/message/111474
> Mute This Topic: https://lists.openembedded.org/mt/107614478/5052612
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 3972 bytes --]

Re: [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Przemyslaw Zegan]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi,

Package ftdi-eeprom does not exist separate, it is part of libftdi package.
My configuration in local.conf:
IMAGE_INSTALL:append = " libftdi"
PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"

This patch does not make ftdi_eeprom install by default.
Second line in my configuration enables this feature, if you remove this line ftdi_eeprom will not be build and place in the generated image.

Przemyslaw Zegan

[-- Attachment #2: Type: text/html, Size: 530 bytes --]

Re: [oe] [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

Przemyslaw Zegan via lists.openembedded.org <przemyslaw.zegan=
gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 12:02):

> Hi,
>
> Package ftdi-eeprom does not exist separate, it is part of libftdi package.
> My configuration in local.conf:
> IMAGE_INSTALL:append = " libftdi"
>

The problem is there ^
To install the ftdi-eeprom binary on the target you need to use:

IMAGE_INSTALL:append = " ftdi-eeprom"
PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"

Can you please try that?

Jose

PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>
> This patch does not make ftdi_eeprom install by default.
> Second line in my configuration enables this feature, if you remove this
> line ftdi_eeprom will not be build and place in the generated image.
>
> Przemyslaw Zegan
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111478):
> https://lists.openembedded.org/g/openembedded-devel/message/111478
> Mute This Topic: https://lists.openembedded.org/mt/107614478/5052612
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 2640 bytes --]

Re: [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Przemyslaw Zegan]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

In the following configuration as you suggested, ftdi-eeprom option is still explicitly enabled in libftdi package, which is a bit confusing.
IMAGE_INSTALL:append = " ftdi-eeprom"
PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"

Once you apply my patch, you can either select libftdi as a separate package or explicitly add the ftdi-eeprom option:
IMAGE_INSTALL:append = " libftdi"
PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"

Przemyslaw Zegan

[-- Attachment #2: Type: text/html, Size: 530 bytes --]

Re: [oe] [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

Przemyslaw Zegan via lists.openembedded.org <przemyslaw.zegan=
gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 13:15):

> In the following configuration as you suggested, ftdi-eeprom option is
> still explicitly enabled in libftdi package, which is a bit confusing.
>

Sometimes bitbake is a little confusing but this is the way it works you
can inspect the packages produced using the following:

# this will build the ftdi-eeprom tool provided by the libftdi project
echo 'PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"' >> conf/local.conf

# this will build the package
bitbake libftdi -f -c do_package

# with this you can inspect the packages produced by bitbake as well as its
content:
tree tmp/work/*/libftdi/*/packages-split

# and with this you install the package from the above options on the image
echo 'IMAGE_INSTALL:append = " ftdi-eeprom"' >> conf/local.conf


Everything you need is already there, just choose the right one.

Jose

IMAGE_INSTALL:append = " ftdi-eeprom"
> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>
> Once you apply my patch, you can either select libftdi as a separate
> package or explicitly add the ftdi-eeprom option:
> IMAGE_INSTALL:append = " libftdi"
> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>
> Przemyslaw Zegan
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111480):
> https://lists.openembedded.org/g/openembedded-devel/message/111480
> Mute This Topic: https://lists.openembedded.org/mt/107614478/5052612
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 3313 bytes --]

Re: [oe] [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]

Hi,

I just noticed that this patch was integrated so it should be reverted.
There is no problem installing the ftdi-eeprom package.

Jose

Jose Quaresma via lists.openembedded.org <quaresma.jose=
gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 16:26):

>
>
> Przemyslaw Zegan via lists.openembedded.org <przemyslaw.zegan=
> gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 13:15):
>
>> In the following configuration as you suggested, ftdi-eeprom option is
>> still explicitly enabled in libftdi package, which is a bit confusing.
>>
>
> Sometimes bitbake is a little confusing but this is the way it works you
> can inspect the packages produced using the following:
>
> # this will build the ftdi-eeprom tool provided by the libftdi project
> echo 'PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"' >> conf/local.conf
>
> # this will build the package
> bitbake libftdi -f -c do_package
>
> # with this you can inspect the packages produced by bitbake as well as
> its content:
> tree tmp/work/*/libftdi/*/packages-split
>
> # and with this you install the package from the above options on the image
> echo 'IMAGE_INSTALL:append = " ftdi-eeprom"' >> conf/local.conf
>
>
> Everything you need is already there, just choose the right one.
>
> Jose
>
> IMAGE_INSTALL:append = " ftdi-eeprom"
>> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>>
>> Once you apply my patch, you can either select libftdi as a separate
>> package or explicitly add the ftdi-eeprom option:
>> IMAGE_INSTALL:append = " libftdi"
>> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>>
>> Przemyslaw Zegan
>>
>>
>>
>>
>
> --
> Best regards,
>
> José Quaresma
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111482):
> https://lists.openembedded.org/g/openembedded-devel/message/111482
> Mute This Topic: https://lists.openembedded.org/mt/107614478/5052612
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4212 bytes --]

Re: [oe] [meta-oe,scarthgap][PATCH] libftdi: Fix missing ftdi_eeprom

[Khem Raj]

On Mon, Aug 5, 2024 at 6:40 AM Jose Quaresma via
lists.openembedded.org
<quaresma.jose=gmail.com@lists.openembedded.org> wrote:
>
> Hi,
>
> I just noticed that this patch was integrated so it should be reverted.
> There is no problem installing the ftdi-eeprom package.

Yeah a last time oversight, I have staged a revert in master-next
>
> Jose
>
> Jose Quaresma via lists.openembedded.org <quaresma.jose=gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 16:26):
>>
>>
>>
>> Przemyslaw Zegan via lists.openembedded.org <przemyslaw.zegan=gmail.com@lists.openembedded.org> escreveu (terça, 30/07/2024 à(s) 13:15):
>>>
>>> In the following configuration as you suggested, ftdi-eeprom option is still explicitly enabled in libftdi package, which is a bit confusing.
>>
>>
>> Sometimes bitbake is a little confusing but this is the way it works you can inspect the packages produced using the following:
>>
>> # this will build the ftdi-eeprom tool provided by the libftdi project
>> echo 'PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"' >> conf/local.conf
>>
>> # this will build the package
>> bitbake libftdi -f -c do_package
>>
>> # with this you can inspect the packages produced by bitbake as well as its content:
>> tree tmp/work/*/libftdi/*/packages-split
>>
>> # and with this you install the package from the above options on the image
>> echo 'IMAGE_INSTALL:append = " ftdi-eeprom"' >> conf/local.conf
>>
>>
>> Everything you need is already there, just choose the right one.
>>
>> Jose
>>
>>> IMAGE_INSTALL:append = " ftdi-eeprom"
>>> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>>>
>>> Once you apply my patch, you can either select libftdi as a separate package or explicitly add the ftdi-eeprom option:
>>> IMAGE_INSTALL:append = " libftdi"
>>> PACKAGECONFIG:pn-libftdi = "ftdi-eeprom"
>>>
>>> Przemyslaw Zegan
>>>
>>>
>>>
>>
>>
>> --
>> Best regards,
>>
>> José Quaresma
>>
>>
>>
>
>
> --
> Best regards,
>
> José Quaresma
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111512): https://lists.openembedded.org/g/openembedded-devel/message/111512
> Mute This Topic: https://lists.openembedded.org/mt/107614478/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>