* [PATCH] lockd and rpciod do not correctly drop locks
@ 2002-07-20 20:22 Robert Love
0 siblings, 0 replies; only message in thread
From: Robert Love @ 2002-07-20 20:22 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
Linus,
lockd and rpciod exit without properly relinquishing the locks they
hold. This pisses off the preempt_count debugging in do_exit.
While in this case it is safe since the lock is the BKL, it is unclean
in my opinion.
I also hate seeing the debug message on unmount ;)
Patch is against 2.5.27, please apply.
Robert Love
diff -urN linux-2.5.27/fs/lockd/svc.c linux/fs/lockd/svc.c
--- linux-2.5.27/fs/lockd/svc.c Sat Jul 20 12:11:25 2002
+++ linux/fs/lockd/svc.c Sat Jul 20 12:52:21 2002
@@ -203,6 +203,7 @@
rpciod_down();
/* Release module */
+ unlock_kernel();
MOD_DEC_USE_COUNT;
}
diff -urN linux-2.5.27/net/sunrpc/sched.c linux/net/sunrpc/sched.c
--- linux-2.5.27/net/sunrpc/sched.c Sat Jul 20 12:11:22 2002
+++ linux/net/sunrpc/sched.c Sat Jul 20 12:52:21 2002
@@ -1030,6 +1030,7 @@
wake_up(assassin);
dprintk("RPC: rpciod exiting\n");
+ unlock_kernel();
MOD_DEC_USE_COUNT;
return 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-07-20 20:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-20 20:22 [PATCH] lockd and rpciod do not correctly drop locks Robert Love
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.