data-logging-20 BUG?!

data-logging-20 BUG?!

[Manuel Krause]

Hi all!

I'm currently using:
2.4.19-rc3
+ reiserfs-pending: 01.change_help_wording.diff
                     02.change_menu_wording.diff
                     03.confusing_journal_replay_warning_removal.diff
                     05.hash_on_empty_fs-1.diff
+ mason: 01-relocation-4.diff
          02-commit_super-8-relocation.diff
          03-beta-data-logging-20.diff
          04-write_times.diff
          05-search_reada-4.diff
+ rml: preempt-kernel-rml-2.4.19-rc3-1.patch


After having upgraded from data-logging -19 to -20 and using it for some 
hours I keep getting this bug (kernel BUG at journal.c:724!):


ksymoops 2.4.0 on i686 2.4.19-rc3.  Options used
      -V (specified)
      -k /proc/ksyms (default)
      -l /proc/modules (default)
      -o /lib/modules/2.4.19-rc3/ (default)
      -m /boot/System.map (specified)

Warning (compare_maps): mismatch on symbol packet_socks_nr  , af_packet 
says e09e7124, /lib/modules/2.4.19-rc3/kernel/net/packet/af_packet.o 
says e09e7044.  Ignoring 
/lib/modules/2.4.19-rc3/kernel/net/packet/af_packet.o entry
Warning (compare_maps): mismatch on symbol proc_scsi  , scsi_mod says 
e08f5c10, /lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o says 
e08f5554.  Ignoring 
/lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o entry
Warning (compare_maps): mismatch on symbol scsi_devicelist  , scsi_mod 
says e08f5c3c, /lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o 
says e08f5580.  Ignoring 
/lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o entry
Warning (compare_maps): mismatch on symbol scsi_hostlist  , scsi_mod 
says e08f5c38, /lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o 
says e08f557c.  Ignoring 
/lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o entry
Warning (compare_maps): mismatch on symbol scsi_hosts  , scsi_mod says 
e08f5c40, /lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o says 
e08f5584.  Ignoring 
/lib/modules/2.4.19-rc3/kernel/drivers/scsi/scsi_mod.o entry
kernel BUG at journal.c:724!
invalid operand: 0000
CPU:    0
EIP:    0010:[<c0176f8a>]    Tainted: PF
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010202
eax: df51ea34   ebx: df51e9e0   ecx: e090d060   edx: c15c0400
esi: 00000000   edi: c15c0400   ebp: 00000c89   esp: ccd9fda4
ds: 0018   es: 0018   ss: 0018
Process kdeinit (pid: 2639, stackpage=ccd9f000)
Stack: 00000014 00000000 00000014 df51e9e0 df51e9e0 c0177485 c15c0400 
00000282
        00000000 00000000 c017768d c15c0400 df51e9e0 00000001 df51e9e0 
00000000
        00000014 df51e9e0 ce798f74 ce798f64 00000000 00000000 00000000 
c0177fc7
Call Trace:    [<c0177485>] [<c017768d>] [<c0177fc7>] [<c017b048>] 
[<c017b90a>]
   [<c017a676>] [<c01608ec>] [<c0140f74>] [<c014111b>] [<c0135c4b>] 
[<c0135f9b>]
   [<c0108843>]
Code: 0f 0b d4 02 55 ea 21 c0 e9 1a 03 00 00 83 7b 08 00 75 13 0f

 >>EIP; c0176f8a <flush_commit_list+42/374>   <=====
Trace; c0177485 <update_journal_header_block+15/2c>
Trace; c017768d <flush_journal_list+e9/534>
Trace; c0177fc7 <flush_used_journal_lists+97/a4>
Trace; c017b048 <flush_old_journal_lists+34/40>
Trace; c017b90a <do_journal_end+8b6/a54>
Trace; c017a676 <journal_end+ba/c4>
Trace; c01608ec <reiserfs_create+150/160>
Trace; c0140f74 <vfs_create+94/f0>
Trace; c014111b <open_namei+14b/558>
Trace; c0135c4b <filp_open+3b/5c>
Trace; c0135f9b <sys_open+37/98>
Trace; c0108843 <system_call+33/38>
Code;  c0176f8a <flush_commit_list+42/374>
00000000 <_EIP>:
Code;  c0176f8a <flush_commit_list+42/374>   <=====
    0:   0f 0b                     ud2a      <=====
Code;  c0176f8c <flush_commit_list+44/374>
    2:   d4 02                     aam    $0x2
Code;  c0176f8e <flush_commit_list+46/374>
    4:   55                        push   %ebp
Code;  c0176f8f <flush_commit_list+47/374>
    5:   ea 21 c0 e9 1a 03 00      ljmp   $0x3,$0x1ae9c021
Code;  c0176f96 <flush_commit_list+4e/374>
    c:   00 83 7b 08 00 75         add    %al,0x7500087b(%ebx)
Code;  c0176f9c <flush_commit_list+54/374>
   12:   13 0f                     adc    (%edi),%ecx


5 warnings issued.  Results may not be reliable.


The processes triggering the bug vary from time to time but it always 
leads to a completely unusable system some minutes after hitting the bug.

I didn't have these problems with the same set of patches and 
data-logging-19 (or the previous versions).

It seems I should go back immediately?! ;-)


Best wishes,

Manuel

Re: data-logging-20 BUG?!

[Manuel Krause]

Hi!

On 07/29/2002 11:17 AM, Tamas Gergely wrote:
> Hi!
> 
> On Sat, Jul 27, 2002 at 12:10:01PM +0200, Manuel Krause wrote:
>  > Hi all!
>  > 
>  > I'm currently using:
>  > 2.4.19-rc3
>  > + reiserfs-pending: 01.change_help_wording.diff
>  >                     02.change_menu_wording.diff
>  >                     03.confusing_journal_replay_warning_removal.diff
>  >                     05.hash_on_empty_fs-1.diff
>  > + mason: 01-relocation-4.diff
>  >          02-commit_super-8-relocation.diff
>  >          03-beta-data-logging-20.diff
>  >          04-write_times.diff
>  >          05-search_reada-4.diff
>  > + rml: preempt-kernel-rml-2.4.19-rc3-1.patch
>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Where did you get this one from? All I was able to find was one for
> -rc3-ac3-1?
> 
> Thanks in advance,
> Gergely
> 

Sorry, I was a bit inaccurate. Thanks, for pointing this out!

I took the patch preempt-kernel-rml-2.4.19-rc2-1.patch from 
ftp://ftp.kernel.org/pub/linux/kernel/people/rml/preempt-kernel/v2.4/
-- it applied and compiled cleanly.

I don't have the reported problems with 03-beta-data-logging-19.diff at all.


Best wishes,

Manuel

Re: data-logging-20 BUG?!

[Chris Mason]

On Sat, 2002-07-27 at 06:10, Manuel Krause wrote:

> 
> After having upgraded from data-logging -19 to -20 and using it for some 
> hours I keep getting this bug (kernel BUG at journal.c:724!):

Ok, I've uploaded -21, and it should fix the BUG().  It was a debugging
check to make sure the journal code had properly sent all the ordered
buffers to disk before sending the commit down.  There was a race in -20
that broke this rule.

The oops should not have caused any corruptions, the incremental from
-20 to -21 is below.

-chris

diff -u comp/fs/reiserfs/journal.c comp/fs/reiserfs/journal.c
--- comp/fs/reiserfs/journal.c	Fri Jul 26 10:06:44 2002
+++ comp/fs/reiserfs/journal.c	Mon Jul 29 13:07:31 2002
@@ -3652,6 +3652,9 @@
 
   SB_JOURNAL(p_s_sb)->j_current_jl = alloc_journal_list(p_s_sb);
 
+  /* write any buffers that must hit disk before the commit is done */
+  fsync_buffers_list(&jl->j_ordered_bh_list);
+
   /* now it is safe to insert this transaction on the main list */
   list_add_tail(&jl->j_list, &SB_JOURNAL(p_s_sb)->j_journal_list);
   list_add_tail(&jl->j_working_list, &SB_JOURNAL(p_s_sb)->j_working_list);
@@ -3738,9 +3741,6 @@
   if (!(SB_JOURNAL(p_s_sb)->j_current_jl->j_list_bitmap)) {
     reiserfs_panic(p_s_sb, "journal-1996: do_journal_end, could not get a list bitmap\n") ;
   }
-
-  /* write any buffers that must hit disk before the commit is done */
-  fsync_buffers_list(&jl->j_ordered_bh_list);
 
   unlock_journal(p_s_sb) ;
   atomic_set(&(SB_JOURNAL(p_s_sb)->j_jlock), 0) ;

Re: data-logging-20 BUG?!

[Manuel Krause]

On 07/29/2002 09:29 PM, Chris Mason wrote:
> On Sat, 2002-07-27 at 06:10, Manuel Krause wrote:
> 
> 
>>After having upgraded from data-logging -19 to -20 and using it for some 
>>hours I keep getting this bug (kernel BUG at journal.c:724!):
> 
> 
> Ok, I've uploaded -21, and it should fix the BUG().  It was a debugging
> check to make sure the journal code had properly sent all the ordered
> buffers to disk before sending the commit down.  There was a race in -20
> that broke this rule.
> 
> The oops should not have caused any corruptions, the incremental from
> -20 to -21 is below.
> 
> -chris
> 

Hi!

The new -21 patch works fine on here. After going back to -19 I found 
out -20 really didn't cause any corruptions.  :-))


Thank you, Chris!

Manuel