From: Paul Larson <plars@linuxtestproject.org>
To: Ed Tomlinson <tomlins@cam.org>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: 2.5.x opps stopping serial
Date: 15 Oct 2002 15:33:07 -0500 [thread overview]
Message-ID: <1034713993.17565.34.camel@plars> (raw)
In-Reply-To: <200210110845.24687.tomlins@cam.org>
On Fri, 2002-10-11 at 07:45, Ed Tomlinson wrote:
> Hi,
>
> I have been seeing this during shutdown ever since I started using 2.5. Figured
> I really should report it... There are three serial ports. One for a serial console,
> the second for a backUPS ups, the third for a (real) modem. Dist is debian sid.
>
> Saving state of known serial devices... Unable to handle kernel NULL pointer dereference at virtual addres
Looks like it might be similar to one I saw with smatch recently. There
are several places in core.c that check info->tty before dereferencing
it, but others that don't. I don't think this will fix the one you are
seeing, but if it's easily reproducible you could try doing something
similar in uart_block_til_ready.
--- linux-2.5/drivers/serial/core.c Wed Oct 9 13:45:11 2002
+++ linux-corefix/drivers/serial/core.c Wed Oct 9 13:50:09 2002
@@ -207,7 +207,7 @@
* Setup the RTS and DTR signals once the
* port is open and ready to respond.
*/
- if (info->tty->termios->c_cflag & CBAUD)
+ if (info->tty && (info->tty->termios->c_cflag & CBAUD))
uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
}
Thanks,
Paul Larson
WARNING: multiple messages have this Message-ID (diff)
From: Paul Larson <plars@linuxtestproject.org>
To: Ed Tomlinson <tomlins@cam.org>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: 2.5.x opps stopping serial
Date: 15 Oct 2002 15:33:07 -0500 [thread overview]
Message-ID: <1034713993.17565.34.camel@plars> (raw)
In-Reply-To: <200210110845.24687.tomlins@cam.org>
On Fri, 2002-10-11 at 07:45, Ed Tomlinson wrote:
> Hi,
>
> I have been seeing this during shutdown ever since I started using 2.5. Figured
> I really should report it... There are three serial ports. One for a serial console,
> the second for a backUPS ups, the third for a (real) modem. Dist is debian sid.
>
> Saving state of known serial devices... Unable to handle kernel NULL pointer dereference at virtual addres
Looks like it might be similar to one I saw with smatch recently. There
are several places in core.c that check info->tty before dereferencing
it, but others that don't. I don't think this will fix the one you are
seeing, but if it's easily reproducible you could try doing something
similar in uart_block_til_ready.
--- linux-2.5/drivers/serial/core.c Wed Oct 9 13:45:11 2002
+++ linux-corefix/drivers/serial/core.c Wed Oct 9 13:50:09 2002
@@ -207,7 +207,7 @@
* Setup the RTS and DTR signals once the
* port is open and ready to respond.
*/
- if (info->tty->termios->c_cflag & CBAUD)
+ if (info->tty && (info->tty->termios->c_cflag & CBAUD))
uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
}
Thanks,
Paul Larson
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-10-15 20:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-11 7:55 2.5.41-mm3 Andrew Morton
2002-10-11 12:18 ` 2.5.41-mm3 Ed Tomlinson
2002-10-11 12:37 ` 2.5.41-mm3 Ed Tomlinson
2002-10-11 12:37 ` 2.5.41-mm3 Ed Tomlinson
2002-10-12 14:21 ` 2.5.41-mm3 Ed Tomlinson
2002-10-12 14:21 ` 2.5.41-mm3 Ed Tomlinson
2002-10-11 12:40 ` 2.5.41+ shutdown problems Ed Tomlinson
2002-10-11 12:40 ` Ed Tomlinson
2002-10-12 14:18 ` Ed Tomlinson
2002-10-12 14:18 ` Ed Tomlinson
2002-10-12 22:32 ` Bjoern A. Zeeb
2002-10-12 22:32 ` Bjoern A. Zeeb
2002-10-11 12:45 ` 2.5.x opps stopping serial Ed Tomlinson
2002-10-11 12:45 ` Ed Tomlinson
2002-10-12 14:18 ` Ed Tomlinson
2002-10-12 14:18 ` Ed Tomlinson
2002-10-15 20:33 ` Paul Larson [this message]
2002-10-15 20:33 ` Paul Larson
[not found] ` <20021015230733.E7702@flint.arm.linux.org.uk>
2002-10-16 1:50 ` Ed Tomlinson
2002-10-16 1:50 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034713993.17565.34.camel@plars \
--to=plars@linuxtestproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tomlins@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.