All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ARM: shmobile: marzen-reference: Set SMSC lan to use irq-push-pull
Date: Wed, 15 May 2013 09:15:01 +0000	[thread overview]
Message-ID: <10371644.BMkVSLAUGy@avalon> (raw)
In-Reply-To: <1368586650-26263-5-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thanks for the patch.

On Wednesday 15 May 2013 11:57:30 Simon Horman wrote:
> This change makes the DTS consistent with the platform data
> that exists in board-marzen.c.
> 
> Empirically it does not appear to be necessary.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7779-marzen-reference.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> b/arch/arm/boot/dts/r8a7779-marzen-reference.dts index 10cfc7f..fe32e1a
> 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> @@ -40,6 +40,7 @@
>  		phy-mode = "mii";
>  		interrupt-parent = <&irqpin0>;
>  		interrupts = <1 0x4>;
> +		smsc,irq-push-pull;
>  		reg-io-width = <4>;
>  		vddvario-supply = <&fixedregulator3v3>;
>  		vdd33a-supply = <&fixedregulator3v3>;
-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: shmobile: marzen-reference: Set SMSC lan to use irq-push-pull
Date: Wed, 15 May 2013 11:15:01 +0200	[thread overview]
Message-ID: <10371644.BMkVSLAUGy@avalon> (raw)
In-Reply-To: <1368586650-26263-5-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thanks for the patch.

On Wednesday 15 May 2013 11:57:30 Simon Horman wrote:
> This change makes the DTS consistent with the platform data
> that exists in board-marzen.c.
> 
> Empirically it does not appear to be necessary.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7779-marzen-reference.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> b/arch/arm/boot/dts/r8a7779-marzen-reference.dts index 10cfc7f..fe32e1a
> 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen-reference.dts
> @@ -40,6 +40,7 @@
>  		phy-mode = "mii";
>  		interrupt-parent = <&irqpin0>;
>  		interrupts = <1 0x4>;
> +		smsc,irq-push-pull;
>  		reg-io-width = <4>;
>  		vddvario-supply = <&fixedregulator3v3>;
>  		vdd33a-supply = <&fixedregulator3v3>;
-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2013-05-15  9:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15  2:57 [PATCH v2 0/4] marzen-reference ethernet patches Simon Horman
2013-05-15  2:57 ` Simon Horman
2013-05-15  2:57 ` [PATCH v2 1/4] ARM: shmobile: marzen-reference: Reference the correct IRQ for ethernet Simon Horman
2013-05-15  2:57   ` Simon Horman
2013-05-15  2:57 ` [PATCH v2 2/4] ARM: shmobile: marzen-reference: Update lan device name in pinctrl maps Simon Horman
2013-05-15  2:57   ` Simon Horman
2013-05-15  2:57 ` [PATCH v2 3/4] ARM: shmobile: marzen-reference: Initialise irqpin Simon Horman
2013-05-15  2:57   ` Simon Horman
2013-05-15  9:28   ` Laurent Pinchart
2013-05-15  9:28     ` Laurent Pinchart
2013-05-15 23:56     ` Simon Horman
2013-05-15 23:56       ` Simon Horman
2013-05-15  2:57 ` [PATCH v2 4/4] ARM: shmobile: marzen-reference: Set SMSC lan to use irq-push-pull Simon Horman
2013-05-15  2:57   ` Simon Horman
2013-05-15  9:15   ` Laurent Pinchart [this message]
2013-05-15  9:15     ` Laurent Pinchart
2014-05-12 22:26     ` Laurent Pinchart
2014-05-12 22:26       ` Laurent Pinchart
2014-05-13  1:11       ` Simon Horman
2014-05-13  1:11         ` Simon Horman
2014-05-13  7:07         ` Simon Horman
2014-05-13  7:07           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10371644.BMkVSLAUGy@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.