From: Tanushree Shah <tshah@linux.ibm.com>
To: Matt Turner <mattst88@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] powerpc/perf: mpc7450: Event 0x30d does not use the threshold
Date: Fri, 13 Nov 2026 23:08:06 +0530 [thread overview]
Message-ID: <1044b867-fa18-4654-baf7-dd1e3a5562ef@linux.ibm.com> (raw)
In-Reply-To: <20261109-ppc32-perf-v1-1-a6e8a55b3b48@gmail.com>
On 11/10/26 7:17 AM, Matt Turner wrote:
> mpc7450_threshold_use() reports event 0x30d (PMC3 select 13, FPR issue
> queue entries) as using MMCR0[THRESHOLD], and the comment above it marks
> the event with a question mark. The manual (MPC7450UM Rev. 5, Table
> 11-11) says the event counts the valid FPR issue queue entries each
> cycle, with no threshold. PMC3 select 12, the GPR rename buffer event
> next to it, is the one that uses the threshold.
>
> The only effect is that r30d cannot be counted together with a threshold
> event that uses a different threshold. Drop it from the list.
>
> Fixes: 7325927e5a20 ("perf_counter: powerpc: Add processor back-end for MPC7450 family")
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Hi Matt,
I checked Table 11-11 in the manual: PMC3 select 13 (0x30d) counts valid
FPR issue queue entries every cycle and has no threshold. On PMC3 only
select 12 (0x30c) and select 17 (0x311) use MMCR0[THRESHOLD]. That
matches with the code change.
Reviewed-by: Tanushree Shah <tshah@linux.ibm.com>
Thanks
Tanushree Shah
> ---
> arch/powerpc/perf/mpc7450-pmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/perf/mpc7450-pmu.c b/arch/powerpc/perf/mpc7450-pmu.c
> index db451b9aac35..564f6dac3a00 100644
> --- a/arch/powerpc/perf/mpc7450-pmu.c
> +++ b/arch/powerpc/perf/mpc7450-pmu.c
> @@ -65,7 +65,6 @@ static int mpc7450_classify_event(u32 event)
> * 12b Y PM_LD_MISS_EXCEED_L1_CYC
> * 220 N PM_CQ_EXCEED_CYC
> * 30c N PM_GPR_RB_EXCEED_CYC
> - * 30d ? PM_FPR_IQ_EXCEED_CYC ?
> * 311 Y PM_ITLB_SEARCH_EXCEED
> * 410 N PM_GPR_IQ_EXCEED_CYC
> */
> @@ -92,7 +91,7 @@ static int mpc7450_threshold_use(u32 event)
> return 1;
> break;
> case 3:
> - if (sel == 0xc || sel == 0xd)
> + if (sel == 0xc)
> return 1;
> if (sel == 0x11)
> return 2;
>
next prev parent reply other threads:[~2026-11-13 17:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 1:46 [PATCH 0/8] powerpc/perf: mpc7450: Event fixes, SIAR sampling and sysfs event names Matt Turner
2026-11-10 1:47 ` [PATCH 1/8] powerpc/perf: mpc7450: Event 0x30d does not use the threshold Matt Turner
2026-11-13 17:38 ` Tanushree Shah [this message]
2026-11-10 1:47 ` [PATCH 2/8] powerpc/perf: mpc7450: Event 0x634 counts L2 prefetches, not L1I Matt Turner
2026-11-17 15:25 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 3/8] powerpc/perf: mpc7450: Remove the snoop retry alternatives Matt Turner
2026-11-17 15:28 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 4/8] powerpc/perf: mpc7450: Fill in the L1 data cache events Matt Turner
2026-11-17 15:36 ` Tanushree Shah
2026-11-17 17:41 ` Matt Turner
2026-11-10 1:47 ` [PATCH 5/8] powerpc/perf: mpc7450: Add the PMC6 L3 events to the alternatives table Matt Turner
2026-11-17 15:39 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 6/8] powerpc/perf: mpc7450: Export the event format in sysfs Matt Turner
2026-11-17 16:01 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 7/8] powerpc/perf: Use SIAR for sample addresses on 32-bit Matt Turner
2026-11-17 16:11 ` Tanushree Shah
2026-11-17 17:42 ` Matt Turner
2026-11-10 1:47 ` [PATCH 8/8] powerpc/perf: mpc7450: Export event names in sysfs Matt Turner
2026-11-17 16:17 ` Tanushree Shah
2026-11-10 1:55 ` [PATCH 0/8] powerpc/perf: mpc7450: Event fixes, SIAR sampling and sysfs event names Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1044b867-fa18-4654-baf7-dd1e3a5562ef@linux.ibm.com \
--to=tshah@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.