From: Tanushree Shah <tshah@linux.ibm.com>
To: Matt Turner <mattst88@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] powerpc/perf: mpc7450: Fill in the L1 data cache events
Date: Tue, 17 Nov 2026 21:06:02 +0530 [thread overview]
Message-ID: <6d067199-3077-48a2-80cc-e21352f5c837@linux.ibm.com> (raw)
In-Reply-To: <20261109-ppc32-perf-v1-4-a6e8a55b3b48@gmail.com>
On 11/10/26 7:17 AM, Matt Turner wrote:
> The L1D row of the cache event table has load and store misses but no
> accesses, and nothing for prefetches, so L1-dcache-loads,
> L1-dcache-stores and L1-dcache-prefetch-misses are not supported.
>
> The MPC7450 has no L1 data cache access event, so approximate the
> accesses with PMC2 select 26 (load instructions completed) and select
> 20 (store instructions completed, PMC1 or PMC2). These also count
> cache-inhibited accesses. PMC2 select 38 counts dcbt, dcbtst and dst
> line fetches that miss in the L1 data cache.
>
> On a 7448, a loop with one store in every 32 instructions counted
> 645840841 instructions and 19773839 L1-dcache-stores, about one store
> per 33 instructions.
>
> Loads and load misses are both PMC2-only events, so perf multiplexes
> L1-dcache-loads and L1-dcache-load-misses when both are requested, and
> refuses them in one group.
>
> Signed-off-by: Matt Turner <mattst88@gmail.com>
Hi Matt,
I checked the new L1D entries against MPC7450UM Rev. 5:
0x21a PMC2 select 26 (Table 11-10), "Load instructions completed"
0x014 select 20 (Tables 11-9 and 11-10), "Store instructions
completed", valid on PMC1 or PMC2
0x226 PMC2 select 38 (Table 11-10), "L1 data touch miss"
The codes match the descriptions in the commit message. 0x014 falls
in the "PMC1 or PMC2" class in mpc7450_classify_event(), and 0x21a and
0x226 are PMC2-only, which agrees with your note that perf can't put
L1-dcache-loads and L1-dcache-load-misses in one group.
Using completed load/store instructions for the L1D access slots is an
approximation, but I think it's reasonable given there is no L1D access
event, and x86 does something similar. I'll leave it to the maintainers
if they feel differently.
If you have a quick load-only run for 0x21a,
it would be nice to see the numbers, but that's not a blocker.
Reviewed-by: Tanushree Shah <tshah@linux.ibm.com>
Thanks
Tanushree Shah
> ---
> arch/powerpc/perf/mpc7450-pmu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/perf/mpc7450-pmu.c b/arch/powerpc/perf/mpc7450-pmu.c
> index 9890c87c58ef..27337a03ebde 100644
> --- a/arch/powerpc/perf/mpc7450-pmu.c
> +++ b/arch/powerpc/perf/mpc7450-pmu.c
> @@ -362,9 +362,9 @@ static int mpc7450_generic_events[] = {
> */
> static u64 mpc7450_cache_events[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
> [C(L1D)] = { /* RESULT_ACCESS RESULT_MISS */
> - [C(OP_READ)] = { 0, 0x225 },
> - [C(OP_WRITE)] = { 0, 0x227 },
> - [C(OP_PREFETCH)] = { 0, 0 },
> + [C(OP_READ)] = { 0x21a, 0x225 },
> + [C(OP_WRITE)] = { 0x014, 0x227 },
> + [C(OP_PREFETCH)] = { 0, 0x226 },
> },
> [C(L1I)] = { /* RESULT_ACCESS RESULT_MISS */
> [C(OP_READ)] = { 0x129, 0x115 },
>
next prev parent reply other threads:[~2026-11-17 15:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 1:46 [PATCH 0/8] powerpc/perf: mpc7450: Event fixes, SIAR sampling and sysfs event names Matt Turner
2026-11-10 1:47 ` [PATCH 1/8] powerpc/perf: mpc7450: Event 0x30d does not use the threshold Matt Turner
2026-11-13 17:38 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 2/8] powerpc/perf: mpc7450: Event 0x634 counts L2 prefetches, not L1I Matt Turner
2026-11-17 15:25 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 3/8] powerpc/perf: mpc7450: Remove the snoop retry alternatives Matt Turner
2026-11-17 15:28 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 4/8] powerpc/perf: mpc7450: Fill in the L1 data cache events Matt Turner
2026-11-17 15:36 ` Tanushree Shah [this message]
2026-11-17 17:41 ` Matt Turner
2026-11-10 1:47 ` [PATCH 5/8] powerpc/perf: mpc7450: Add the PMC6 L3 events to the alternatives table Matt Turner
2026-11-17 15:39 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 6/8] powerpc/perf: mpc7450: Export the event format in sysfs Matt Turner
2026-11-17 16:01 ` Tanushree Shah
2026-11-10 1:47 ` [PATCH 7/8] powerpc/perf: Use SIAR for sample addresses on 32-bit Matt Turner
2026-11-17 16:11 ` Tanushree Shah
2026-11-17 17:42 ` Matt Turner
2026-11-10 1:47 ` [PATCH 8/8] powerpc/perf: mpc7450: Export event names in sysfs Matt Turner
2026-11-17 16:17 ` Tanushree Shah
2026-11-10 1:55 ` [PATCH 0/8] powerpc/perf: mpc7450: Event fixes, SIAR sampling and sysfs event names Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d067199-3077-48a2-80cc-e21352f5c837@linux.ibm.com \
--to=tshah@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.