Re: [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20

[Norbert Kiesel <nkiesel@tbdnetworks.com>]

Hi,

Alan included my 2.4.20 patches - including the one for acm.c - in
2.4.21-pre5-ac1, so I expect them to show up in mainline someday.  Still
working on delivering some of the 2.5.x ones...

--nk

On Thu, 2003-03-06 at 11:58, Pavel Machek wrote:
> Hi!
> 
> > >  
> > > -	if (!urb->status & !acm->throttle)  {
> > > +	if (!urb->status && !acm->throttle)  {
> > >  		for (i = 0; i < urb->actual_length && !acm->throttle; i++) {
> 
> > To summarize, I'd probably not be amused if you would change any of my
> > code which takes advantage of such programming finess.  I would probably
> > have added appropriate comments to explain the code but nevertheless,
> > replacing the more efficient code with some which is easier to
> > understand should probably be considered on a case by case basis.
> 
> Actually I feel co-responsible for acm.c,
> and this *is* typo. acm is for modems,
> thats *not* performance critical, and certainly
> not worth code obfuscation.
-- 
Norbert Kiesel <nkiesel@tbdnetworks.com>
TBD Networks