All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonino Daplas <adaplas@pol.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: James Simmons <jsimmons@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: Much better framebuffer fixes.
Date: 28 Mar 2003 03:15:23 +0800	[thread overview]
Message-ID: <1048792147.1086.28.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.GSO.4.21.0303271016300.26358-100000@vervain.sonytel.be>

On Thu, 2003-03-27 at 17:18, Geert Uytterhoeven wrote:
> On Thu, 27 Mar 2003, James Simmons wrote:
> >  drivers/video/logo/logo.c       |   69 +++++------
> 
> Are you sure the change from logo type to logo depth in (fb_)find_logo() won't
> have any side effects? After this change, you may receive a different type of
> logo than you requested.
> 


I agree.  Take the case of Directcolor. At 16-bpp, it needs
linux_logo_vga16, not linux_logo_clut224. Also, monochrome at 8bpp needs
linux_logo_mono, certainly not linux_logo_clut224.  There are obviously
other similar cases.

I think the original logo code in both logo.c and fbmem.c, though a bit
more confusing, provides better ways of choosing the correct logo.

Tony




-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en

WARNING: multiple messages have this Message-ID (diff)
From: Antonino Daplas <adaplas@pol.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: James Simmons <jsimmons@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Fbdev development list 
	<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [Linux-fbdev-devel] Much better framebuffer fixes.
Date: 28 Mar 2003 03:15:23 +0800	[thread overview]
Message-ID: <1048792147.1086.28.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.GSO.4.21.0303271016300.26358-100000@vervain.sonytel.be>

On Thu, 2003-03-27 at 17:18, Geert Uytterhoeven wrote:
> On Thu, 27 Mar 2003, James Simmons wrote:
> >  drivers/video/logo/logo.c       |   69 +++++------
> 
> Are you sure the change from logo type to logo depth in (fb_)find_logo() won't
> have any side effects? After this change, you may receive a different type of
> logo than you requested.
> 


I agree.  Take the case of Directcolor. At 16-bpp, it needs
linux_logo_vga16, not linux_logo_clut224. Also, monochrome at 8bpp needs
linux_logo_mono, certainly not linux_logo_clut224.  There are obviously
other similar cases.

I think the original logo code in both logo.c and fbmem.c, though a bit
more confusing, provides better ways of choosing the correct logo.

Tony



  reply	other threads:[~2003-03-27 19:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-27  0:18 Much better framebuffer fixes James Simmons
2003-03-27  3:29 ` [Linux-fbdev-devel] " Antonino Daplas
2003-03-27  9:33   ` Helge Hafting
2003-03-27  9:33     ` [Linux-fbdev-devel] " Helge Hafting
2003-03-27 17:16     ` Thomas Schlichter
2003-03-27 17:16       ` [Linux-fbdev-devel] " Thomas Schlichter
2003-03-27 19:15       ` Antonino Daplas
2003-03-27 19:15         ` [Linux-fbdev-devel] " Antonino Daplas
2003-03-27  9:18 ` Geert Uytterhoeven
2003-03-27  9:18   ` [Linux-fbdev-devel] " Geert Uytterhoeven
2003-03-27 19:15   ` Antonino Daplas [this message]
2003-03-27 19:15     ` Antonino Daplas
2003-03-27  9:58 ` Helge Hafting
2003-03-27  9:58   ` Helge Hafting
2003-03-27 15:58   ` Thomas Molina
2003-03-27 15:58     ` Thomas Molina
2003-03-27 16:09   ` Mike Houston
2003-03-27 10:16 ` Michael Dreher
     [not found] <20030327002012$0b44@gated-at.bofh.it>
2003-04-02 21:00 ` Lars Noschinski
     [not found] <20030402211245Z20779-11684+4820@humbolt.nl.linux.org>
2003-04-02 21:59 ` James Simmons
     [not found] <20030402221008$2d6c@gated-at.bofh.it>
     [not found] ` <20030402221008$69b9@gated-at.bofh.it>
2003-04-03 15:25   ` Lars Noschinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1048792147.1086.28.camel@localhost.localdomain \
    --to=adaplas@pol.net \
    --cc=geert@linux-m68k.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.