From: Paolo Bonzini <pbonzini@redhat.com>
To: Keith Busch <keith.busch@intel.com>, Li Qiang <liq3ea@gmail.com>
Cc: kwolf@redhat.com, mreitz@redhat.com, ppandit@redhat.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)
Date: Tue, 13 Nov 2018 19:26:58 +0100 [thread overview]
Message-ID: <104e542e-4678-13bf-4378-e378dede71ba@redhat.com> (raw)
In-Reply-To: <20181102154019.GB26292@localhost.localdomain>
On 02/11/2018 16:40, Keith Busch wrote:
> Hey, so why is this memory region access even considered valid if the
> request is out of range from what NVMe had registered for its
> MemoryRegion? Wouldn't it be better to not call the mr->ops->read/write
> if it's out of bounds? Otherwise every MemoryRegion needs to duplicate
> the same check, right?
Because some crazy devices have misaligned registers.
But actually this is not a problem because NVMe doesn't set
ops->impl.unaligned to true, so indeed no change is needed.
Paolo
> Would something like the following work (minimally tested)?
next prev parent reply other threads:[~2018-11-13 18:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 1:22 [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847) Li Qiang
2018-11-02 7:51 ` Philippe Mathieu-Daudé
2018-11-02 10:54 ` Kevin Wolf
2018-11-02 15:00 ` Keith Busch
2018-11-02 15:22 ` Li Qiang
2018-11-02 15:42 ` Kevin Wolf
2018-11-05 1:49 ` Li Qiang
2018-11-02 15:40 ` Keith Busch
2018-11-05 1:56 ` Li Qiang
2018-11-13 18:26 ` Paolo Bonzini [this message]
2018-11-13 1:45 ` Li Qiang
2018-11-13 10:17 ` Kevin Wolf
2018-11-13 10:24 ` Li Qiang
2018-11-13 18:27 ` Paolo Bonzini
2018-11-14 1:38 ` Li Qiang
2018-11-14 15:44 ` Paolo Bonzini
2018-11-15 3:14 ` Li Qiang
2018-11-15 18:10 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104e542e-4678-13bf-4378-e378dede71ba@redhat.com \
--to=pbonzini@redhat.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=liq3ea@gmail.com \
--cc=mreitz@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.