From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] Yet more i2c driver changes for 2.5.69
Date: Thu, 19 May 2005 06:23:56 +0000 [thread overview]
Message-ID: <1053385947386@kroah.com> (raw)
In-Reply-To: <1053385947756@kroah.com>
In-Reply-To: <20030323081431.GF26145@kroah.com>
ChangeSet 1.1093.2.3, 2003/05/19 10:37:20-07:00, warp@mercury.d2dc.net
[PATCH] I2C: And yet another it87 patch.
Trivial, but important.
Somehow in the patching the bk tree somehow got two memset's to clear
new_client in it87_detect, normally while this would be bad, it would
not be critical.
However one of the two happens BEFORE the variable is set, and thus
things go badly.
drivers/i2c/chips/it87.c | 1 -
1 files changed, 1 deletion(-)
diff -Nru a/drivers/i2c/chips/it87.c b/drivers/i2c/chips/it87.c
--- a/drivers/i2c/chips/it87.c Mon May 19 15:58:52 2003
+++ b/drivers/i2c/chips/it87.c Mon May 19 15:58:52 2003
@@ -630,7 +630,6 @@
}
}
}
- memset (new_client, 0x00, sizeof(struct i2c_client) + sizeof(struct it87_data));
/* OK. For now, we presume we have a valid client. We now create the
client structure, even though we cannot fill it completely yet.
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] Yet more i2c driver changes for 2.5.69
Date: Mon, 19 May 2003 16:12:27 -0700 [thread overview]
Message-ID: <1053385947386@kroah.com> (raw)
In-Reply-To: <1053385947756@kroah.com>
ChangeSet 1.1093.2.3, 2003/05/19 10:37:20-07:00, warp@mercury.d2dc.net
[PATCH] I2C: And yet another it87 patch.
Trivial, but important.
Somehow in the patching the bk tree somehow got two memset's to clear
new_client in it87_detect, normally while this would be bad, it would
not be critical.
However one of the two happens BEFORE the variable is set, and thus
things go badly.
drivers/i2c/chips/it87.c | 1 -
1 files changed, 1 deletion(-)
diff -Nru a/drivers/i2c/chips/it87.c b/drivers/i2c/chips/it87.c
--- a/drivers/i2c/chips/it87.c Mon May 19 15:58:52 2003
+++ b/drivers/i2c/chips/it87.c Mon May 19 15:58:52 2003
@@ -630,7 +630,6 @@
}
}
}
- memset (new_client, 0x00, sizeof(struct i2c_client) + sizeof(struct it87_data));
/* OK. For now, we presume we have a valid client. We now create the
client structure, even though we cannot fill it completely yet.
next prev parent reply other threads:[~2005-05-19 6:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 23:11 [BK PATCH] Yet more i2c driver changes for 2.5.69 Greg KH
2005-05-19 6:23 ` Greg KH
2003-05-19 23:12 ` [PATCH] " Greg KH
2005-05-19 6:23 ` Greg KH
2003-05-19 23:12 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-05-19 23:12 ` Greg KH [this message]
2005-05-19 6:23 ` Greg KH
2003-05-19 23:12 ` Greg KH
2005-05-19 6:23 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2003-03-23 8:07 [BK PATCH] Yet more i2c driver changes for 2.5.65 Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-23 8:14 ` [PATCH] " Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-23 8:14 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-23 8:14 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-03-23 8:15 ` Greg KH
2005-05-19 6:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1053385947386@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.