From: Steven Cole <elenstev@mesatop.com>
To: Larry McVoy <lm@bitmover.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Chris Heath <chris@heathens.co.nz>,
linux-kernel@vger.kernel.org
Subject: Re: coding style (was Re: [PATCH][2.5] UTF-8 support in console)
Date: 31 May 2003 11:14:08 -0600 [thread overview]
Message-ID: <1054401248.2900.124.camel@spc> (raw)
In-Reply-To: <20030531153940.GA1280@work.bitmover.com>
On Sat, 2003-05-31 at 09:39, Larry McVoy wrote:
> On Sat, May 31, 2003 at 04:01:50PM +0100, Dave Jones wrote:
> > Saving a line over readability is utterly bogus.
>
> I agree 100%. If you have anything more complex than
>
> if (error) return (error);
>
> I want it to look like
>
> if ((expr) || (expr2) || (expr3)) {
> return (error);
> }
>
This may just be pedantic minutiae, but aren't those parenthesis around
"error" unnecessary?
Here is a proposal for coding style: Only use parenthesis in the return
statement when needed.
return -ETOSENDERADDRESSUNKNOWN; /* this is OK */
return (value & ZORRO_MASK); /* so is this */
return (-ENOTENOUGHCOFFEE); /* bogus parenthesis */
Steven
next prev parent reply other threads:[~2003-05-31 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-31 14:10 [PATCH][2.5] UTF-8 support in console Chris Heath
2003-05-31 14:21 ` Christoph Hellwig
2003-05-31 14:43 ` coding style (was Re: [PATCH][2.5] UTF-8 support in console) Larry McVoy
2003-05-31 15:01 ` Dave Jones
2003-05-31 15:39 ` Larry McVoy
2003-05-31 17:14 ` Steven Cole [this message]
2003-05-31 17:56 ` viro
2003-05-31 19:37 ` [PATCH][2.5] UTF-8 support in console Chris Heath
-- strict thread matches above, loose matches on Subject: below --
2003-05-31 16:06 coding style (was Re: [PATCH][2.5] UTF-8 support in console) john
2003-06-01 4:41 ` Matt Mackall
2003-06-01 5:18 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1054401248.2900.124.camel@spc \
--to=elenstev@mesatop.com \
--cc=chris@heathens.co.nz \
--cc=davej@codemonkey.org.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm@bitmover.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.