From: Christoph Hellwig <hch@infradead.org>
To: Chris Heath <chris@heathens.co.nz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.5] UTF-8 support in console
Date: Sat, 31 May 2003 15:21:33 +0100 [thread overview]
Message-ID: <20030531152133.A32144@infradead.org> (raw)
In-Reply-To: <20030531095521.5576.CHRIS@heathens.co.nz>; from chris@heathens.co.nz on Sat, May 31, 2003 at 10:10:54AM -0400
+static void set_inverse_trans_unicode(struct vc_data *conp, struct uni_pagedir *p)
Please linewrap after 80 chars.
+{
+ int i, j, k, glyph;
+ u16 **p1, *p2;
+ u16 *q;
+
+ if (!p) return;
Please split this into two lines. Can p ever be null_
+ q = p->inverse_trans_unicode;
+
+ if (!q) {
Kill the blank line above.
+ q = p->inverse_trans_unicode = (u16 *)
+ kmalloc(MAX_GLYPH * sizeof(u16), GFP_KERNEL);
The cast is not needed. And btw, where is q freed?
+ if (!q) return;
Two lines again.
next prev parent reply other threads:[~2003-05-31 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-31 14:10 [PATCH][2.5] UTF-8 support in console Chris Heath
2003-05-31 14:21 ` Christoph Hellwig [this message]
2003-05-31 14:43 ` coding style (was Re: [PATCH][2.5] UTF-8 support in console) Larry McVoy
2003-05-31 15:01 ` Dave Jones
2003-05-31 15:39 ` Larry McVoy
2003-05-31 17:14 ` Steven Cole
2003-05-31 17:56 ` viro
2003-05-31 19:37 ` [PATCH][2.5] UTF-8 support in console Chris Heath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030531152133.A32144@infradead.org \
--to=hch@infradead.org \
--cc=chris@heathens.co.nz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.