From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/4] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
Date: Thu, 12 Mar 2015 00:30:14 +0100 [thread overview]
Message-ID: <10565603.LCTpLmy44N@phil> (raw)
In-Reply-To: <1426112117-18220-4-git-send-email-dianders@chromium.org>
Am Mittwoch, 11. M?rz 2015, 15:15:17 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
This one looks good to me and I'll take it into my dts branch.
But due to the deferal issue fixed in patch1, I'll wait a bit for patch1
hopefully getting applied, so that we have a "clean" behaviour when everything
reaches linux-next.
> ---
> Changes in v4:
> - Add vcc_sd regulator which is present on EVB 2.0 boards
>
> Changes in v3: None
> Changes in v2:
> - Fix subject line
>
> arch/arm/boot/dts/rk3288-evb.dtsi | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 5e895a5..6d4ae9f 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -103,6 +103,23 @@
> regulator-always-on;
> regulator-boot-on;
> };
> +
> + /*
> + * NOTE: vcc_sd isn't hooked up on v1.0 boards where power comes from
> + * vcc_io directly. Those boards won't be able to power cycle SD cards
> + * but it shouldn't hurt to toggle this pin there anyway.
> + */
> + vcc_sd: sdmmc-regulator {
> + compatible = "regulator-fixed";
> + gpio = <&gpio7 11 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_pwr>;
> + regulator-name = "vcc_sd";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + startup-delay-us = <100000>;
> + vin-supply = <&vcc_io>;
> + };
> };
>
> &emmc {
> @@ -132,6 +149,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
> status = "okay";
> + vmmc-supply = <&vcc_sd>;
> + vqmmc-supply = <&vccio_sd>;
> };
>
> &i2c0 {
> @@ -223,6 +242,10 @@
> sdmmc_cmd: sdmmc-cmd {
> rockchip,pins = <6 21 RK_FUNC_1 &pcfg_pull_up_drv_8ma>;
> };
> +
> + sdmmc_pwr: sdmmc-pwr {
> + rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> };
>
> usb {
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Mark Brown <broonie@kernel.org>,
Alexandru Stan <amstan@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sonny Rao <sonnyrao@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Addy Ke <addy.ke@rock-chips.com>,
javier.martinez@collabora.co.uk,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
Date: Thu, 12 Mar 2015 00:30:14 +0100 [thread overview]
Message-ID: <10565603.LCTpLmy44N@phil> (raw)
In-Reply-To: <1426112117-18220-4-git-send-email-dianders@chromium.org>
Am Mittwoch, 11. März 2015, 15:15:17 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
This one looks good to me and I'll take it into my dts branch.
But due to the deferal issue fixed in patch1, I'll wait a bit for patch1
hopefully getting applied, so that we have a "clean" behaviour when everything
reaches linux-next.
> ---
> Changes in v4:
> - Add vcc_sd regulator which is present on EVB 2.0 boards
>
> Changes in v3: None
> Changes in v2:
> - Fix subject line
>
> arch/arm/boot/dts/rk3288-evb.dtsi | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 5e895a5..6d4ae9f 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -103,6 +103,23 @@
> regulator-always-on;
> regulator-boot-on;
> };
> +
> + /*
> + * NOTE: vcc_sd isn't hooked up on v1.0 boards where power comes from
> + * vcc_io directly. Those boards won't be able to power cycle SD cards
> + * but it shouldn't hurt to toggle this pin there anyway.
> + */
> + vcc_sd: sdmmc-regulator {
> + compatible = "regulator-fixed";
> + gpio = <&gpio7 11 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_pwr>;
> + regulator-name = "vcc_sd";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + startup-delay-us = <100000>;
> + vin-supply = <&vcc_io>;
> + };
> };
>
> &emmc {
> @@ -132,6 +149,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
> status = "okay";
> + vmmc-supply = <&vcc_sd>;
> + vqmmc-supply = <&vccio_sd>;
> };
>
> &i2c0 {
> @@ -223,6 +242,10 @@
> sdmmc_cmd: sdmmc-cmd {
> rockchip,pins = <6 21 RK_FUNC_1 &pcfg_pull_up_drv_8ma>;
> };
> +
> + sdmmc_pwr: sdmmc-pwr {
> + rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> };
>
> usb {
next prev parent reply other threads:[~2015-03-11 23:30 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 22:15 [PATCH v4 1/4] mmc: dw_mmc: Don't try to enable the CD until we're sure we're not deferring Doug Anderson
2015-03-11 22:15 ` Doug Anderson
2015-03-11 22:15 ` [PATCH v4 2/4] mmc: core: Add mmc_regulator_set_vqmmc() Doug Anderson
2015-03-11 22:15 ` Doug Anderson
2015-03-16 14:05 ` Ulf Hansson
2015-03-16 14:05 ` Ulf Hansson
2015-03-16 15:12 ` Doug Anderson
2015-03-16 15:12 ` Doug Anderson
2015-03-17 10:23 ` Ulf Hansson
2015-03-17 10:23 ` Ulf Hansson
2015-03-17 10:38 ` Mark Brown
2015-03-17 10:38 ` Mark Brown
2015-03-17 10:38 ` Mark Brown
2015-03-17 11:28 ` Ulf Hansson
2015-03-17 11:28 ` Ulf Hansson
2015-03-17 11:28 ` Ulf Hansson
2015-03-19 4:09 ` Doug Anderson
2015-03-19 4:09 ` Doug Anderson
2015-03-19 4:09 ` Doug Anderson
2015-03-19 11:14 ` Ulf Hansson
2015-03-19 11:14 ` Ulf Hansson
[not found] ` <CAPDyKFrkznbW7k_=BDo99jJhWzDbUgbeU+MXWB_E_UWXh=56Eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-19 11:36 ` Mark Brown
2015-03-19 11:36 ` Mark Brown
2015-03-19 11:36 ` Mark Brown
2015-03-20 10:55 ` Ulf Hansson
2015-03-20 10:55 ` Ulf Hansson
2015-03-20 10:55 ` Ulf Hansson
[not found] ` <CAPDyKFroe9N3j9oMWKknH5huv7j8fkrBr5UKjjp190hkqNsNRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-20 11:28 ` Mark Brown
2015-03-20 11:28 ` Mark Brown
2015-03-20 11:28 ` Mark Brown
2015-04-07 20:05 ` Doug Anderson
2015-04-07 20:05 ` Doug Anderson
2015-04-07 20:05 ` Doug Anderson
[not found] ` <CAD=FV=WpDE_iEFWFw094WBfBH2TgRi+1OGk3E3qQ3t1EfyrnJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-08 11:28 ` Mark Brown
2015-04-08 11:28 ` Mark Brown
2015-04-08 11:28 ` Mark Brown
2015-03-11 22:15 ` [PATCH v4 3/4] mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch Doug Anderson
2015-03-11 22:15 ` Doug Anderson
2015-03-11 22:15 ` [PATCH v4 4/4] ARM: dts: Specify VMMC and VQMMC on rk3288-evb Doug Anderson
2015-03-11 22:15 ` Doug Anderson
2015-03-11 22:15 ` Doug Anderson
2015-03-11 23:30 ` Heiko Stuebner [this message]
2015-03-11 23:30 ` Heiko Stuebner
2015-04-07 21:37 ` Heiko Stübner
2015-04-07 21:37 ` Heiko Stübner
2015-03-13 11:32 ` [PATCH v4 1/4] mmc: dw_mmc: Don't try to enable the CD until we're sure we're not deferring Jaehoon Chung
2015-03-13 11:32 ` Jaehoon Chung
2015-03-13 12:10 ` Heiko Stuebner
2015-03-13 12:10 ` Heiko Stuebner
2015-03-13 12:10 ` Heiko Stuebner
2015-03-16 2:09 ` Jaehoon Chung
2015-03-16 2:09 ` Jaehoon Chung
2015-03-27 5:55 ` Jaehoon Chung
2015-03-27 5:55 ` Jaehoon Chung
2015-03-27 15:46 ` Doug Anderson
2015-03-27 15:46 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10565603.LCTpLmy44N@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.