* [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined
@ 2003-07-06 22:43 Mikael Pettersson
2003-07-07 5:51 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Mikael Pettersson @ 2003-07-06 22:43 UTC (permalink / raw)
To: benh; +Cc: linux-kernel
Compiling 2.4.22-pre3 for a 6xx-class PowerPC fails in cpu_setup_6xx.S:
ppc-unknown-linux-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/tmp/linux-2.4.22-pre3/include -I/tmp/linux-2.4.22-pre3/arch/ppc -c -o cpu_setup_6xx.o cpu_setup_6xx.S
cpu_setup_6xx.S: Assembler messages:
cpu_setup_6xx.S:325: Error: unsupported relocation against SPRN_HID2
cpu_setup_6xx.S:416: Error: unsupported relocation against SPRN_HID2
make[1]: *** [cpu_setup_6xx.o] Error 1
make[1]: Leaving directory `/tmp/linux-2.4.22-pre3/arch/ppc/kernel'
make: *** [_dir_arch/ppc/kernel] Error 2
SPRN_HID2 should be a #defined constant, but it isn't. The patch
below from 2.4.21-ben2 (rediffed for 2.4.22-pre3) fixes the problem.
/Mikael
diff -ruN linux-2.4.22-pre3/include/asm-ppc/processor.h linux-2.4.22-pre3.ppc-hid2-fix/include/asm-ppc/processor.h
--- linux-2.4.22-pre3/include/asm-ppc/processor.h 2003-07-06 18:37:48.000000000 +0200
+++ linux-2.4.22-pre3.ppc-hid2-fix/include/asm-ppc/processor.h 2003-07-06 22:24:10.000000000 +0200
@@ -248,6 +248,7 @@
#define HID0_NOPDST (1<<1) /* No-op dst, dstt, etc. instr. */
#define HID0_NOPTI (1<<0) /* No-op dcbt and dcbst instr. */
#define SPRN_HID1 0x3F1 /* Hardware Implementation Register 1 */
+#define SPRN_HID2 0x3F8 /* Hardware Implementation Register 2 */
#define SPRN_IABR 0x3F2 /* Instruction Address Breakpoint Register */
#define SPRN_IAC1 0x3F4 /* Instruction Address Compare 1 */
#define SPRN_IAC2 0x3F5 /* Instruction Address Compare 2 */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined
2003-07-06 22:43 [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined Mikael Pettersson
@ 2003-07-07 5:51 ` Benjamin Herrenschmidt
2003-07-07 6:45 ` Paul Mackerras
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2003-07-07 5:51 UTC (permalink / raw)
To: Mikael Pettersson, Marcelo Tosatti; +Cc: linux-kernel mailing list
On Mon, 2003-07-07 at 00:43, Mikael Pettersson wrote:
> Compiling 2.4.22-pre3 for a 6xx-class PowerPC fails in cpu_setup_6xx.S:
>
> ppc-unknown-linux-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/tmp/linux-2.4.22-pre3/include -I/tmp/linux-2.4.22-pre3/arch/ppc -c -o cpu_setup_6xx.o cpu_setup_6xx.S
> cpu_setup_6xx.S: Assembler messages:
> cpu_setup_6xx.S:325: Error: unsupported relocation against SPRN_HID2
> cpu_setup_6xx.S:416: Error: unsupported relocation against SPRN_HID2
> make[1]: *** [cpu_setup_6xx.o] Error 1
> make[1]: Leaving directory `/tmp/linux-2.4.22-pre3/arch/ppc/kernel'
> make: *** [_dir_arch/ppc/kernel] Error 2
>
> SPRN_HID2 should be a #defined constant, but it isn't. The patch
> below from 2.4.21-ben2 (rediffed for 2.4.22-pre3) fixes the problem.
Yup, Marcelo, please apply.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined
2003-07-07 5:51 ` Benjamin Herrenschmidt
@ 2003-07-07 6:45 ` Paul Mackerras
2003-07-07 18:30 ` Marcelo Tosatti
0 siblings, 1 reply; 4+ messages in thread
From: Paul Mackerras @ 2003-07-07 6:45 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Mikael Pettersson, Marcelo Tosatti, linux-kernel mailing list
Benjamin Herrenschmidt writes:
> > SPRN_HID2 should be a #defined constant, but it isn't. The patch
> > below from 2.4.21-ben2 (rediffed for 2.4.22-pre3) fixes the problem.
>
> Yup, Marcelo, please apply.
Um, I have that in the for-marcelo-ppc tree already, which I hope
Marcelo will pull before pre4.
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined
2003-07-07 6:45 ` Paul Mackerras
@ 2003-07-07 18:30 ` Marcelo Tosatti
0 siblings, 0 replies; 4+ messages in thread
From: Marcelo Tosatti @ 2003-07-07 18:30 UTC (permalink / raw)
To: Paul Mackerras
Cc: Benjamin Herrenschmidt, Mikael Pettersson,
linux-kernel mailing list
On Mon, 7 Jul 2003, Paul Mackerras wrote:
> Benjamin Herrenschmidt writes:
>
> > > SPRN_HID2 should be a #defined constant, but it isn't. The patch
> > > below from 2.4.21-ben2 (rediffed for 2.4.22-pre3) fixes the problem.
> >
> > Yup, Marcelo, please apply.
>
> Um, I have that in the for-marcelo-ppc tree already, which I hope
> Marcelo will pull before pre4.
Just pushed it and pulled to bkbits.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-07-07 18:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-06 22:43 [PATCH][2.4.22-pre3] fix PPC32 compile failure due to SPRN_HID2 being undefined Mikael Pettersson
2003-07-07 5:51 ` Benjamin Herrenschmidt
2003-07-07 6:45 ` Paul Mackerras
2003-07-07 18:30 ` Marcelo Tosatti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.