From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [DLM PATCH] DLM: Don't save callbacks after accept
Date: Wed, 19 Oct 2016 11:37:11 -0400 (EDT) [thread overview]
Message-ID: <1058410649.9549156.1476891431289.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <418069748.3262986.1474655006158.JavaMail.zimbra@redhat.com>
----- Original Message -----
| Hi,
|
| When DLM calls accept() on a socket, the comm code copies the sk
| after we've saved its callbacks. Afterward, it calls add_sock which
| saves the callbacks a second time. Since the error reporting function
| lowcomms_error_report calls the previous callback too, this results
| in a recursive call to itself. This patch adds a new parameter to
| function add_sock to tell whether to save the callbacks. Function
| tcp_accept_from_sock (and its sctp counterpart) then calls it with
| false to avoid the recursion.
|
| Signed-off-by: Bob Peterson <rpeterso@redhat.com>
| ---
Hi Dave,
Any word on this patch from 23 September?
Regards,
Bob Peterson
Red Hat File Systems
prev parent reply other threads:[~2016-10-19 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2142176787.3261374.1474654582584.JavaMail.zimbra@redhat.com>
2016-09-23 18:23 ` [Cluster-devel] [DLM PATCH] DLM: Don't save callbacks after accept Bob Peterson
2016-10-19 15:37 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058410649.9549156.1476891431289.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.